Geoffrey Young wrote:
Also I'd like to suggest another change. If you introduce key=>val
arguments, the old arg should support that as well, like so:
generate_script( file => 't/TEST',
bugreport => My::Foo::bugreport());
What do you think? And we keep the back-compat:
gene
Also I'd like to suggest another change. If you introduce key=>val
arguments, the old arg should support that as well, like so:
generate_script( file => 't/TEST',
bugreport => My::Foo::bugreport());
What do you think? And we keep the back-compat:
generate_script('t/TEST');
Geoffrey Young wrote:
but I kinda thought the delayed eval made it a bit
neater - that's the added value :)
Delayed eval? I fail to see where the delay is coming from? You run
eval {} in generate_script,
don't take delay too literally. it was just a bad choice of words on my
part - we bot
but I kinda thought the delayed eval made it a bit
neater - that's the added value :)
Delayed eval? I fail to see where the delay is coming from? You run eval
{} in generate_script,
don't take delay too literally. it was just a bad choice of words on my
part - we both know what the code is d
Geoffrey Young wrote:
Cool.
Though I'm not sure about the CODEREF part. bugreport is a just a
function to run if 'make test' fails. Though you hardcoded it to be a
function to print something. Since eval of that CODEREF happens during
generate_script() you could just do it and pass that return
Cool.
Though I'm not sure about the CODEREF part. bugreport is a just a
function to run if 'make test' fails. Though you hardcoded it to be a
function to print something. Since eval of that CODEREF happens during
generate_script() you could just do it and pass that return value to
bugreport.
Geoffrey Young wrote:
the attached patch makes it possible to use -bugreport with the
Apache::TestRun(Perl)->generate_script() form
You do: eval { $report->() } but don't check for [EMAIL PROTECTED] Better just drop eval {}
and let it fail.
sorry, I meant to include examples. with this patch,
the attached patch makes it possible to use -bugreport with the
Apache::TestRun(Perl)->generate_script() form
sorry, I meant to include examples. with this patch, you can use the
following formats in your Makefile.PL
# scalars are printed in the post-error banner
Apache::TestRun(Perl)->generat
[EMAIL PROTECTED] wrote:
stas2003/11/05 01:52:18
Modified:.Makefile.PL Changes
ModPerl-Registry/t TEST.PL
lib/ModPerl TestRun.pm
Log:
When 'make test' fails we now print the info on what to do next
the attached patch makes it possible to
