Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-26 Thread Philippe M. Chiasson
Stas Bekman wrote: > Philippe M. Chiasson wrote: > [...] > >>Yes! That's also another _very_ good reason to type comparaisons with the >>constant >>on the left side. I always try to write it in that order, and by now, my brain >>is fully adjusted to it. >> >>if("Inherit" eq $var) { >>elsif ("

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Stas Bekman
Philippe M. Chiasson wrote: [...] Yes! That's also another _very_ good reason to type comparaisons with the constant on the left side. I always try to write it in that order, and by now, my brain is fully adjusted to it. if("Inherit" eq $var) { elsif ("Enable" eq $var) { elsif ("Disable" eq

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philip M. Gollucci
Just for the record, I was disputing the correctness and am amazed how many responses I got from it. It just caught my eye as odd as I personally have never used that form. EGAD that was supposed to be wasN'T disputing not was *sigh* Too much Percoset I guess. -- --

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philippe M. Chiasson
Philip M. Gollucci wrote: >>A quick grep shows this is indeed the only instance, but there are quite a few >>similar usages in [httpd/modules/ldap/*, so I am not alone at the ASF ;-) > > Just for the record, I was disputing the correctness and am amazed how many > responses I got from it. It jus

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philippe M. Chiasson
Malcolm J Harwood wrote: > On Wednesday 25 January 2006 11:29 pm, Philip M. Gollucci wrote: > > >>>-if(0 == strncasecmp(arg, "+inherit", 8)) { >>>+if (0 == strncasecmp(arg, "+inherit", 8)) { >>>modperl_cmd_options(parms, mconfig, "+InheritSwitches"); >>>} >>>else { >> >>Is

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philip M. Gollucci
A quick grep shows this is indeed the only instance, but there are quite a few similar usages in [httpd/modules/ldap/*, so I am not alone at the ASF ;-) Just for the record, I was disputing the correctness and am amazed how many responses I got from it. It just caught my eye as odd as I personal

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philippe M. Chiasson
Philip M. Gollucci wrote: >>-if(0 == strncasecmp(arg, "+inherit", 8)) { >>+if (0 == strncasecmp(arg, "+inherit", 8)) { >>modperl_cmd_options(parms, mconfig, "+InheritSwitches"); >>} >>else { >> > Isn't the normal c idiom > if (!strncasecmp() ? > > I don't think I've ev

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Malcolm J Harwood
On Wednesday 25 January 2006 11:29 pm, Philip M. Gollucci wrote: > >-if(0 == strncasecmp(arg, "+inherit", 8)) { > >+if (0 == strncasecmp(arg, "+inherit", 8)) { > > modperl_cmd_options(parms, mconfig, "+InheritSwitches"); > > } > > else { > > Isn't the normal c idiom > if (!

Re: svn commit: r372010 - /perl/modperl/trunk/src/modules/perl/modperl_cmd.c

2006-01-25 Thread Philip M. Gollucci
-if(0 == strncasecmp(arg, "+inherit", 8)) { +if (0 == strncasecmp(arg, "+inherit", 8)) { modperl_cmd_options(parms, mconfig, "+InheritSwitches"); } else { Isn't the normal c idiom if (!strncasecmp() ? I don't think I've ever seen that form (though correct)