Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-08-27 Thread Geoffrey Young
>> $Apache::Server::SaveConfig is now $Apache::PerlSections::Save >> Reviewed by:gozer > > > Hmm, reading the docs, I think it'll be more intuitive to have it > renamed to: $Apache::PerlSections::SaveConfig since it doesn't save > PerlSections, it saves the results of running those secti

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-08-25 Thread Stas Bekman
[EMAIL PROTECTED] wrote: geoff 2004/08/23 14:16:27 Modified:.Changes lib/Apache PerlSections.pm Status.pm src/modules/perl modperl_cmd.c t/conf extra.last.conf.in Log: $Apache::Server::SaveConfig is now $Apache::PerlSections::Sa

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-08-08 Thread Philippe M. Chiasson
Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/08/08 16:50:49 Modified:t/conf extra.last.conf.in Log: authen was recently renamed to authen_basic and authen_digest, fixing 2 little rename omissions thanks for the fix, philippe. I've just noticed it and cvs up solved it

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-08-08 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/08/08 16:50:49 Modified:t/conf extra.last.conf.in Log: authen was recently renamed to authen_basic and authen_digest, fixing 2 little rename omissions thanks for the fix, philippe. I've just noticed it and cvs up solved it :) -- __

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-02-11 Thread Philippe M. Chiasson
On Tue, 2004-02-10 at 17:30 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/10 09:45:22 > [...] > > +open my $fh, ">$file" || die $!; > > nice try of adding 'die' without adding it ;) > > % perl -MO=Deparse,-p -e 'open my $fh, ">$file" || die $!;' > open(my $fh,

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in

2004-02-10 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/10 09:45:22 [...] +open my $fh, ">$file" || die $!; nice try of adding 'die' without adding it ;) % perl -MO=Deparse,-p -e 'open my $fh, ">$file" || die $!;' open(my $fh, (">$file" || die($!))); which is equal to: open my $fh, ">$file"; but you

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-10 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 17:58 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > >>>What's the advantage of using A::TC::writefile instead ? > >> > >>It doesn't cleanup the files and doesn't log what it does. I see no reason why > >>would you want to delete it. t_write_file is for the test

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: What's the advantage of using A::TC::writefile instead ? It doesn't cleanup the files and doesn't log what it does. I see no reason why would you want to delete it. t_write_file is for the test run-time. I can't really call Apache::TestConfig->new from within the se

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 16:38 -0800, Stas Bekman wrote: > Philippe M. Chiasson wrote: > > On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: > > > >>[EMAIL PROTECTED] wrote: > >> > >>>gozer 2004/02/09 14:20:53 > >>> > >>> Modified:t/conf extra.last.conf.in > >>> Removed: t/conf

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
Philippe M. Chiasson wrote: On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in Removed: t/conf perlsection.conf Log: To test recursive/re-entrant sections, autogenerate the included fi

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 15:15 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/09 14:20:53 > > > > Modified:t/conf extra.last.conf.in > > Removed: t/conf perlsection.conf > > Log: > > To test recursive/re-entrant sections, autogenerate the included fi

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Philippe M. Chiasson
On Mon, 2004-02-09 at 14:35 -0800, Stas Bekman wrote: > [EMAIL PROTECTED] wrote: > > gozer 2004/02/09 14:20:53 > > > > Modified:t/conf extra.last.conf.in > [...] > >#Handle re-entrant sections > > > > -$Include = "@ServerRoot@/conf/perlsection.conf"; > > require File::Spe

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in Removed: t/conf perlsection.conf Log: To test recursive/re-entrant sections, autogenerate the included file instead of having to keep t/conf/perlsection.conf in CVS Revision Cha

Re: cvs commit: modperl-2.0/t/conf extra.last.conf.in perlsection.conf

2004-02-09 Thread Stas Bekman
[EMAIL PROTECTED] wrote: gozer 2004/02/09 14:20:53 Modified:t/conf extra.last.conf.in [...] #Handle re-entrant sections -$Include = "@ServerRoot@/conf/perlsection.conf"; require File::Spec; missing? +my $file = File::Spec->catfile('@ServerRoot@', 'conf', 'perlsectio