Doug, I have these two questions regarding the logic in modperl_filter.c
RCS file: /home/cvs/modperl-2.0/src/modules/perl/modperl_filter.c,v
retrieving revision 1.36
diff -u -r1.36 modperl_filter.c
--- src/modules/perl/modperl_filter.c 29 Jun 2002 20:38:33 -0000 1.36
+++ src/modules/perl/modperl_filter.c 6 Jul 2002 17:00:20 -0000
@@ -300,6 +300,7 @@
buf_len);
}
else {
+ /* XXX: why this error gets ignored in the normal mode? */
MP_TRACE_f(MP_FUNC,
"apr_bucket_read error: %s\n",
modperl_apr_strerror(filter->rc));
@@ -392,6 +393,9 @@
case OK:
return APR_SUCCESS;
case DECLINED:
+ /* XXX: shouldn't we check here if the handler didn't
+ * destroy bb, even though returning DECLINE? smells like a
+ * place where SEGV may happen */
return ap_pass_brigade(f->next, bb);
default:
return status; /*XXX*/
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
