Re: svn commit: r280495 - /perl/modperl/trunk/lib/ModPerl/Config.pm

2005-09-13 Thread Philip M. Gollucci
Stas Bekman wrote: Please note that I've quoted the specific part of the code I was talking about. That part is remarkable indentical :) Just go for lower granularity. Sounds good to me. -- END What doesn't kill us can only make

Re: svn commit: r280495 - /perl/modperl/trunk/lib/ModPerl/Config.pm

2005-09-13 Thread Stas Bekman
Philip M. Gollucci wrote: Stas Bekman wrote: [EMAIL PROTECTED] wrote: code duplication detected :) whenever you find yourself duplicating code you should immediately consider refactoring. Otherwise the future won't be too good... :) This code should live in Apache::TestConfig and used here

Re: svn commit: r280495 - /perl/modperl/trunk/lib/ModPerl/Config.pm

2005-09-13 Thread Philip M. Gollucci
Stas Bekman wrote: [EMAIL PROTECTED] wrote: code duplication detected :) whenever you find yourself duplicating code you should immediately consider refactoring. Otherwise the future won't be too good... :) This code should live in Apache::TestConfig and used here as a function call. I saw

Re: svn commit: r280495 - /perl/modperl/trunk/lib/ModPerl/Config.pm

2005-09-13 Thread Stas Bekman
[EMAIL PROTECTED] wrote: Author: pgollucci Date: Mon Sep 12 21:42:31 2005 New Revision: 280495 URL: http://svn.apache.org/viewcvs?rev=280495&view=rev Log: Add a DARWIN constant and add ldd/otool -L output to mp2bug reports Modified: perl/modperl/trunk/lib/ModPerl/Config.pm Modified: perl/