Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm

2006-01-10 Thread Stas Bekman
Geoffrey Young wrote: Philip M. Gollucci wrote: Does this warrant a Changes entry ? I wouldn' think so my $mm_ver = $ExtUtils::MakeMaker::VERSION; +$mm_ver =~ s/_.*//; # handle dev versions like 6.30_01 my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25) isn't 'no warnin

Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm

2006-01-10 Thread Geoffrey Young
my $mm_ver = $ExtUtils::MakeMaker::VERSION; +$mm_ver =~ s/_.*//; # handle dev versions like 6.30_01 my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25) > > Could be... Apache2::Status also does the regex should we swap both ? if they're both doing it then I gue

Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm

2006-01-09 Thread Philip M. Gollucci
Geoffrey Young wrote: Philip M. Gollucci wrote: Does this warrant a Changes entry ? I wouldn' think so my $mm_ver = $ExtUtils::MakeMaker::VERSION; +$mm_ver =~ s/_.*//; # handle dev versions like 6.30_01 my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25) Could be... Apache2

Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm

2006-01-09 Thread Geoffrey Young
Philip M. Gollucci wrote: > Does this warrant a Changes entry ? I wouldn' think so >> my $mm_ver = $ExtUtils::MakeMaker::VERSION; >> +$mm_ver =~ s/_.*//; # handle dev versions like 6.30_01 >> my $pm_to_blib = ($mm_ver >= 6.22 && $mm_ver <= 6.25) isn't 'no warnings (numeric)' a bi

Re: svn commit: r367475 - /perl/modperl/trunk/lib/ModPerl/BuildMM.pm

2006-01-09 Thread Philip M. Gollucci
Does this warrant a Changes entry ? [EMAIL PROTECTED] wrote: Author: pgollucci Date: Mon Jan 9 19:54:39 2006 New Revision: 367475 URL: http://svn.apache.org/viewcvs?rev=367475&view=rev Log: fix this Makefile.PL warning Writing Makefile for X Argument "6.30_01" isn't numeric in numeric ge (>