Here is an attempt at a simple implementation of $r->print(), copied mostly
from mpxs_ap_rvputs().
A few things worth noting:
1. It does support $|
2. It doesn't have timeouts like 1.3 used to have (is it needed anymore?)
3. Should most the tests use $r->print() in the future ? (perl -pi ...)
4.
On Mon, 10 Sep 2001, Doug MacEachern wrote:
> On Mon, 10 Sep 2001, Stas Bekman wrote:
>
> > > you shouldn't have needed to do that. more info on what happened?
> >
> > yes please.
>
> i was asking you for more info on why you had to run 'make source_scan'
I've decided that xs/maps were autogene
I have a simple question ;-)
how come when I ran:
indent -i4 -npsl -di0 -br -nce -d0 -cli0 -npcs -nfc1
as per http://dev.apache.org/styleguide.html
I ended up with a huge diff from the main code
;-p
Just had to be annoying about this one, sorry.
--
Philippe M. Chiasson <[EMAIL PROTECTE
The -c flag might be overkill a bit...
rsync uses the lastmodified time of a file before reverting to using checksums,
so as long as you don't go around modyfiyng files or doing touch * all over
the place, -c isn't strictly necessary. It requires more bandwidth and is heavier
on the cpu of both
On Mon, 10 Sep 2001, Philippe M . Chiasson wrote:
> The -c flag might be overkill a bit...
>
> rsync uses the lastmodified time of a file before reverting to using
> checksums, so as long as you don't go around modyfiyng files or doing
> touch * all over the place, -c isn't strictly necessary. I
On Mon, Sep 10, 2001 at 04:00:01PM +0800, Stas Bekman wrote:
> On Mon, 10 Sep 2001, Philippe M . Chiasson wrote:
>
> > The -c flag might be overkill a bit...
> >
> > rsync uses the lastmodified time of a file before reverting to using
> > checksums, so as long as you don't go around modyfiyng fil
> > However, should threads have different cwds?
>
> Well, if you want to use any modules that chdir() in threaded code, I
> think so. Basically, in a threaded perl, unsafe chdir should be warned
> about or perl should DWIM and emulate chdir per thread (as it does on
> windows). The former is
> On Sun, Sep 09, 2001 at 04:49:50PM -0400, Barrie Slaymaker wrote:
> >
> > > However, should threads have different cwds?
> >
> > Well, if you want to use any modules that chdir() in threaded code, I
> > think so. Basically, in a threaded perl, unsafe chdir should be warned
> > about or perl
OK, so now when bootstrapping is available I'm trying to require all .pm
files in ./t and search for Apache_TEST_CONFIGURE and run it if found.
Index: Apache-Test/lib/Apache/TestConfigPerl.pm
===
RCS file:
/home/cvs/httpd-test/perl-
On Mon, Sep 10, 2001 at 10:31:48AM +0200, Arthur Bergman wrote:
>
> > > How does Apache deal with this?
> >
> > By carefully repeating "Don't Do That" as they code the httpd ;-).
>
> There are good reasons for this :-)
:-)
> I would suspect linux has a process level chdir, not sure thou.
Jus
On Mon, Sep 10, 2001 at 10:49:53AM -0400, Barrie Slaymaker wrote:
> On Mon, Sep 10, 2001 at 10:31:48AM +0200, Arthur Bergman wrote:
> >
> > > > How does Apache deal with this?
> > >
> > > By carefully repeating "Don't Do That" as they code the httpd ;-).
> >
> > There are good reasons for this
On Mon, 10 Sep 2001, Philippe M . Chiasson wrote:
> Here is an attempt at a simple implementation of $r->print(), copied mostly
> from mpxs_ap_rvputs().
great, a few comments..
> A few things worth noting:
>
> 1. It does support $|
> 2. It doesn't have timeouts like 1.3 used to have (is it ne
> > I would suspect linux has a process level chdir, not sure thou.
>
> Just checked, pthread_create() causes all threads to share the cwd and
> umask. By using __clone() directly, they could be set as unshared, I
> think, by passing CLONE_FS.
So we can easily fix it for linux.
> I guess the b
On Mon, 10 Sep 2001, Philippe M . Chiasson wrote:
> how come when I ran:
>
> indent -i4 -npsl -di0 -br -nce -d0 -cli0 -npcs -nfc1
>
> as per http://dev.apache.org/styleguide.html
>
> I ended up with a huge diff from the main code
interesting, i've never run indent before. the changes indent
On Mon, 10 Sep 2001, Stas Bekman wrote:
> +my $configure_sub = *{$module."::APACHE_TEST_CONFIGURE"}{CODE};
would prefer using $module->can('APACHE_TEST_CONFIGURE') here.
> TestModules::cgiupload barks at Apache::OK undefined, patched with:
>
> +use Apache::Const -compile => 'OK
On Mon, 10 Sep 2001, Doug MacEachern wrote:
> On Mon, 10 Sep 2001, Stas Bekman wrote:
>
> > +my $configure_sub = *{$module."::APACHE_TEST_CONFIGURE"}{CODE};
>
> would prefer using $module->can('APACHE_TEST_CONFIGURE') here.
Yup, I was thinking about that, but figured it'd be more
I've investigated the failure of cgi tests under perl patch 11966, the
problem is that STDIN is empty, so they cannot read any data:
apache/cgihandler
modules/cgi
modules/cgiupload
the failing parts are all trying to POST/GET data. The %ENV is fine, but
STDIN is empty so CGI.pm cannot get any re
On Tue, 11 Sep 2001, Stas Bekman wrote:
> Yup, I was thinking about that, but figured it'd be more expensive. I know
> we don't care much about speed in tests :) so can() should be fine.
yeah, the difference in speed here isn't worth it for tests.
> > yeah, the common ones normally compiled in
On Tue, 11 Sep 2001, Stas Bekman wrote:
> I've investigated the failure of cgi tests under perl patch 11966, the
> problem is that STDIN is empty, so they cannot read any data:
i see the same, haven't looked into it yet.
-
To
On Mon, 10 Sep 2001, Doug MacEachern wrote:
> On Tue, 11 Sep 2001, Stas Bekman wrote:
> > doh! I didn't expect code in .h :) sure should have checked that. thanks!
>
> most of the xs/ *.h files have code in them. they are .h because they are
> always #include-d, never compiled into their own ob
On Tue, 11 Sep 2001, Stas Bekman wrote:
> ah, OK, now I recall why did we want to have APACHE_TEST_CONFIGURE at the
> test startup time. We want to access the config object. If I use
> Apache::TestUtil I have no access for example to all the dirs. So if I
> want to write some files which rely on
I know, I realized all that yesterday. And I thought I could simply be lazy,
use indent and not twist my brain a little bit more ;-(
I'll pay more attention to my patche's style, and keep reminding/nudging me
whenever I slip.
I guess that the ASF style document could remove the gun indent part,
I'm about to move the contents of pod/ to the modperl-docs rep, which gets
checks out as docs/ inside modperl-2.0 root tree. There is at least one
test that uses a file from pod/ , should I adjust it to use some other
file, e.g. Changes or should I point it to docs/src/devel/ where the file
is goi
Here is my second attempt at $r->print(), notice I removed the MP_USE_AP_RWRITE
since it wasn't needed anymore.
All test still pass with my patch applied.
Here is the patch #2 and I even think it's proprely indented ;-)
Index: todo/api.txt
===
Doug, shell we nuke the examples/ dir? We have a plenty of tests that
serve as examples. Or did you plan to put something else there in the
future?
_
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://st
Doug, this is something that you wrote a while ago. I thought to add it as
util/perlbloat.pl ?
#!/usr/bin/perl -w
use GTop ();
my $gtop = GTop->new;
my $before = $gtop->proc_mem($$)->size;
for (@ARGV) {
if (eval "require $_") {
eval {
$_->import;
};
}
el
> > So should I just give up the idea of APACHE_TEST_CONFIGURE and move on
> > with Apache::TestUtil like vhost_alias does?
>
> i think so.
>
> > Let's just think for a sec, whether we may have some other reason for
> > having something like APACHE_TEST_CONFIGURE? Was the creation of the files
> >
When I thought I was starting to understand something ;-(
I am trying to implement APR::Table->do(sub { .. });
And I thought it was simply a matter of these few steps:
1. Create xs/APR/Table/APR__Table.h
2. put a prototype in there, like:
static MP_INLINE
void mpxs_APR__Table_do(apr_ta
28 matches
Mail list logo
