Re: rfc: new API to traverse filter chains

2003-04-01 Thread Geoffrey Young
typedef int (ap_filter_chain_traverse_fh_t)(void *data, ap_filter_t *f); int ap_filter_chain_traverse(ap_filter_chain_traverse_fh_t *traverse, void *data, ap_filter_t **chain); if this patch gets accepted, it may provide not only the way to remove a filter but also a

Re: cvs commit: modperl-2.0 Changes

2003-04-01 Thread Geoffrey Young
[EMAIL PROTECTED] wrote: stas2003/03/31 21:20:51 Modified:xs/Apache/Filter Apache__Filter.h xs/maps modperl_functions.map xs/tables/current/ModPerl FunctionTable.pm todo filters.txt .Changes Added: t/f

[patch] TestMM generates default t/TEST

2003-04-01 Thread Geoffrey Young
it's irked me for a while that Apache::Test does so much behind the scenes yet I still have to write a Test.PL template to include what is essentially one line of code. I think we should be able to provide a default harness with minimal intervention. the attached patch allows you to call Apach

Re: cvs commit: modperl-2.0 Changes

2003-04-01 Thread Stas Bekman
Geoffrey Young wrote: [EMAIL PROTECTED] wrote: stas2003/03/31 21:20:51 Modified:xs/Apache/Filter Apache__Filter.h xs/maps modperl_functions.map xs/tables/current/ModPerl FunctionTable.pm todo filters.txt .Cha

Re: rfc: new API to traverse filter chains

2003-04-01 Thread Stas Bekman
Geoffrey Young wrote: typedef int (ap_filter_chain_traverse_fh_t)(void *data, ap_filter_t *f); int ap_filter_chain_traverse(ap_filter_chain_traverse_fh_t *traverse, void *data, ap_filter_t **chain); if this patch gets accepted, it may provide not only the way to remo

Re: [patch] TestMM generates default t/TEST

2003-04-01 Thread Stas Bekman
Geoffrey Young wrote: it's irked me for a while that Apache::Test does so much behind the scenes yet I still have to write a Test.PL template to include what is essentially one line of code. I think we should be able to provide a default harness with minimal intervention. the attached patch al

Re: cvs commit: modperl-2.0 Changes

2003-04-01 Thread Geoffrey Young
if the filter is not in the chain the data will just pass through. I'm not quite sure why it doesn't work for you. Can you uncomment the warn statements in both filters and see whether they are called? yes, I will tomorrow. the second filter: insert_underscores should be always called (2 or 3

Re: [patch] TestMM generates default t/TEST

2003-04-01 Thread Geoffrey Young
Have you looked at Apache::TestRun::generate_script? It does exactly that. bah. thanks, that's exactly what I need. --Geoff - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [patch] TestMM generates default t/TEST

2003-04-01 Thread Stas Bekman
Geoffrey Young wrote: Have you looked at Apache::TestRun::generate_script? It does exactly that. bah. thanks, that's exactly what I need. ;) The only reason it's in TestRun, is because TestReport and TestSmoke has it as well (to generate REPORT and SMOKE scripts). So it's a 1:1 mapping. Wher

Re: [patch] TestMM generates default t/TEST

2003-04-01 Thread Geoffrey Young
Also should probably mention it in the testing.pod doc, if it's not mentioned already. which I couldn't find in the 2.0 distribution, BTW. [EMAIL PROTECTED] modperl-2.0]$ find . -name testing.pod [EMAIL PROTECTED] modperl-2.0]$ is it not part of the 2.0 default document set? it probably should

Re: docs distro

2003-04-01 Thread Stas Bekman
[changing subject] Geoffrey Young wrote: Also should probably mention it in the testing.pod doc, if it's not mentioned already. which I couldn't find in the 2.0 distribution, BTW. [EMAIL PROTECTED] modperl-2.0]$ find . -name testing.pod [EMAIL PROTECTED] modperl-2.0]$ is it not part of the 2.

Re: docs distro

2003-04-01 Thread Geoffrey Young
It's because all the docs live in the modperl-docs rep. modperl-2.0 gets modperl-docs/src/docs/2.0 extracted into modperl-2.0/docs. testing.pod lives in modperl-docs/src/docs/general/testing/testing.pod as it's not 2.0-specific. yes, but Apache::Test is distributed with 2.0 so whatever docs are

ModPerl::ModuleBuildUtil or another name?

2003-04-01 Thread Stas Bekman
Earlier I was thinking to call the helper module ModPerl::MMUtil, but it looks like in a near future MM might have a competitor, so I didn't want to lock into the MM name. So I'm thinking to call the module ModPerl::ModuleBuildUtil, mimicking Module::Build. It's quite long though, any better ide

Re: docs distro

2003-04-01 Thread Stas Bekman
Geoffrey Young wrote: It's because all the docs live in the modperl-docs rep. modperl-2.0 gets modperl-docs/src/docs/2.0 extracted into modperl-2.0/docs. testing.pod lives in modperl-docs/src/docs/general/testing/testing.pod as it's not 2.0-specific. yes, but Apache::Test is distributed with

Re: [mp2] Win32 problems

2003-04-01 Thread Randy Kobes
On Mon, 31 Mar 2003, Stas Bekman wrote: > Randy Kobes wrote: [ .. ] > > - secondly, there's a problem in starting the tests, with a free > > to a wrong pool and then an access violation in the perl58 lib. > > No error log is created, but I've attached a trace from enabling > > PerlTrace All in htt