Re: [mp2] mod_perl test suite fails

2003-12-17 Thread Volker Kroll
Good Morning Stas. On Tue, 2003-12-16 at 21:33, Stas Bekman wrote: > Stas Bekman wrote: > I think I've figured it out. Can you please try with the current cvs or just > apply this patch: > This is the result after updating from CVS: /usr/bin/perl -Iblib/arch -Iblib/lib \ t/TEST -clean *** set

Re: [mp2] mod_perl test suite fails

2003-12-17 Thread Stas Bekman
Volker Kroll wrote: Good Morning Stas. On Tue, 2003-12-16 at 21:33, Stas Bekman wrote: Stas Bekman wrote: I think I've figured it out. Can you please try with the current cvs or just apply this patch: This is the result after updating from CVS: /usr/bin/perl -Iblib/arch -Iblib/lib \ t/TEST -

Re: [mp2] small manpage fix

2003-12-17 Thread Stas Bekman
Andres Salomon wrote: This is a small fix for Apache::TestTrace(3pm); the format of the manpage causes man-db's crontab to complain. --- orig/Apache-Test/lib/Apache/TestTrace.pm +++ mod/Apache-Test/lib/Apache/TestTrace.pm @@ -134,7 +134,7 @@ 1; __END__ - +=head1 NAME =head1 Apache::TestTrace

Re: [mp2] mod_perl test suite fails

2003-12-17 Thread Volker Kroll
On Wed, 2003-12-17 at 10:02, Stas Bekman wrote: > Perfect. Finally the detection is properly working. Now the test suite doesn't > even start, since we can tell ahead that it won't work. > > The next stage will be to find a workaround for the problem. > > Thanks a lot for the testing, Volker.

Re: [mp2] mod_perl test suite fails

2003-12-17 Thread Stas Bekman
Volker Kroll wrote: On Wed, 2003-12-17 at 10:02, Stas Bekman wrote: Perfect. Finally the detection is properly working. Now the test suite doesn't even start, since we can tell ahead that it won't work. The next stage will be to find a workaround for the problem. Thanks a lot for the testing,

[mp2] s/APR::Finfo/APR::FInfo/?

2003-12-17 Thread Stas Bekman
Before we released the new API in the wild, how about s/APR::Finfo/APR::FInfo/ I find myself typing APR::FInfo instead of APR::Finfo all the time, as this is the convention we follow for most modules. __ Stas BekmanJAm_p

[mp2] $r->finfo is misplaced

2003-12-17 Thread Stas Bekman
Why $r->finfo() ended up in the APR::Finfo package? It doesn't seem to belong there. APR classes shouldn't mess up with Apache structs. It should be in Apache::RequestRec (like $r->uri and others). __ Stas BekmanJAm_pH -

Re: [mp2] s/APR::Finfo/APR::FInfo/?

2003-12-17 Thread Geoffrey Young
Stas Bekman wrote: > Before we released the new API in the wild, how about > s/APR::Finfo/APR::FInfo/ I find myself typing APR::FInfo instead of > APR::Finfo all the time, as this is the convention we follow for most > modules. I prefer it the way it is - it's the finfo field in the request rec,

Re: [mp2] $r->finfo is misplaced

2003-12-17 Thread Geoffrey Young
Stas Bekman wrote: > Why $r->finfo() ended up in the APR::Finfo package? It doesn't seem to > belong there. APR classes shouldn't mess up with Apache structs. It > should be in Apache::RequestRec (like $r->uri and others). I'll evaluate this once a kick the flu. --Geoff --

Re: [mp2] $r->finfo is misplaced

2003-12-17 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Why $r->finfo() ended up in the APR::Finfo package? It doesn't seem to belong there. APR classes shouldn't mess up with Apache structs. It should be in Apache::RequestRec (like $r->uri and others). I'll evaluate this once a kick the flu. myself is down wi

Re: [mp2] s/APR::Finfo/APR::FInfo/?

2003-12-17 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: Before we released the new API in the wild, how about s/APR::Finfo/APR::FInfo/ I find myself typing APR::FInfo instead of APR::Finfo all the time, as this is the convention we follow for most modules. I prefer it the way it is - it's the finfo field in th