Re[2]: debian stable 5.6.1 fix

2004-08-23 Thread Jason Woodward
Hi Stas, > Thanks Jason for the spot and the patch. > > After testing is completed I'll apply the following patch (this is sort of > ppport.h, so no code needs to be changed). > > I'll probably release 1.99_16 shortly, as this will be a problem for any > 5.6.x users. Great, thanks! take car

Re: debian stable 5.6.1 fix

2004-08-23 Thread Issac Goldstand
Well: 1) I didn't originally have test failures - my quick scan of the original message was that it fixed a *debian* issue - which pushed me to post my original warning about Debian being about to release their next stable version, which I wanted to make sure didn't have any issues with Jason's pa

Re: debian stable 5.6.1 fix

2004-08-23 Thread Stas Bekman
Issac Goldstand wrote: 2) Now that I ran make test and got failures, I wanted to submit them. Unfortunately, my mails to dev somehow end up going to docs-dev and I haven't figured out what weird config setting is doing that - I assume it's by me. I'll keep looking - maybe this time it will work. T

[mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Stas Bekman
I've noticed that the move from Apache::Server to Apache::ServerRec and ServerUtil is not complete. There are still references to Apache::Server in the code and docs. I'll take care of the other places, but there is $Apache::Server::SaveConfig: ./lib/Apache/PerlSections.pm:sub save { retu

Re: cvs commit: modperl-2.0 Changes

2004-08-23 Thread Philippe M. Chiasson
[EMAIL PROTECTED] wrote: stas2004/08/23 11:31:05 Modified:xs/Apache/Log Apache__Log.h .Changes Log: Fix $s->log->*, $s->log_error and $s->log_serror to again log into the vhost's error_log file (if there is one). Missed this small rename in t/api/aplog

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Geoffrey Young
Stas Bekman wrote: > I've noticed that the move from Apache::Server to Apache::ServerRec and > ServerUtil is not complete. There are still references to Apache::Server > in the code and docs. I'll take care of the other places, but there is > $Apache::Server::SaveConfig: > It should probably be

Re: cvs commit: modperl-2.0 Changes

2004-08-23 Thread Stas Bekman
Philippe M. Chiasson wrote: [EMAIL PROTECTED] wrote: stas2004/08/23 11:31:05 Modified:xs/Apache/Log Apache__Log.h .Changes Log: Fix $s->log->*, $s->log_error and $s->log_serror to again log into the vhost's error_log file (if there is one). Missed thi

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Stas Bekman
Geoffrey Young wrote: Stas Bekman wrote: I've noticed that the move from Apache::Server to Apache::ServerRec and ServerUtil is not complete. There are still references to Apache::Server in the code and docs. I'll take care of the other places, but there is $Apache::Server::SaveConfig: It should pr

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Geoffrey Young
>> $Apache::PerlSections::Strict whoops - that's gone now. I guess I haven't sync'd my checkout in a while :) >> $Apache::PerlSections::Save > > > +1! > > Good idea Geoff! > > and compat.pod to be updated :) > partial patch attached - I'm getting some failures in perldo.t that I can't

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Philippe M. Chiasson
Geoffrey Young wrote: $Apache::PerlSections::Strict whoops - that's gone now. I guess I haven't sync'd my checkout in a while :) $Apache::PerlSections::Save +1! +1 from me too, these configuration variables were 'ported' from mp1 to mp2 as is. And sticking them in $Apache::Server::** didn't

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Philippe M. Chiasson
Geoffrey Young wrote: $Apache::PerlSections::Strict whoops - that's gone now. I guess I haven't sync'd my checkout in a while :) $Apache::PerlSections::Save +1! Good idea Geoff! and compat.pod to be updated :) partial patch attached - I'm getting some failures in perldo.t that I can't figur

Re: cvs commit: modperl-2.0 Changes

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: [EMAIL PROTECTED] wrote: gozer 2004/08/18 11:05:29 +Apache::Module remove_loaded_module re-added [Gozer] + since the addition and removal has happened within the same release, please just unedit the previous entry where you've said that you've remove dit. The purpos

Re: [mp2] $Apache::Server::SaveConfig

2004-08-23 Thread Geoffrey Young
> Can you report that failure --verbose ? Because I just applied your > patch and: > > $> ./t/TEST directive > All tests successful. I think I forgot to re-make after I missed one spot - it all looks fine for me too (now). --Geoff --

Re: [mp2] code freeze

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: in case you haven't noticed i've posted an RC, so we enter the code freeze phase. So please avoid committing code changes, unless they are fixes of something that's broken (e.g. tests). I think we may want to change that practice in order not to create obstacles for new deve

Re: [mp2 rfc] APR::Bucket new methods

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: I've added the $b->destroy and $b->remove methods as suggested by Joe, so now we won't have the (temporary, request or connection long) memory leaks. I'm still trying to find the idiomatic bb processing loop, where only some buckets are modified. The idea is to make the code

Re: eliminating modperl-2.0/patches dir?

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: You discover interesting things when doing release packaging. Apparently we had an apache patch to do static modperl for years at: modperl-2.0/patches/link-hack.pat I suppose it's no longer needed, right Philippe? My godness, we sure don't need that thing around anymore, as it'

Re: [mp2 rfc] APR::Bucket new methods

2004-08-23 Thread Stas Bekman
Philippe M. Chiasson wrote: for (my $b = $bb->first; $b; $b = $bb->next($b)) { last if $b->is_eos; if ($b->read(my $data)) { $b->replace_data(APR::Bucket->new(uc $data)); } } You must have meant : $b->replace_data(uc $data) right ? Yes, thank you :) BTW, the s

Re: [mp2] code freeze

2004-08-23 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: in case you haven't noticed i've posted an RC, so we enter the code freeze phase. So please avoid committing code changes, unless they are fixes of something that's broken (e.g. tests). I think we may want to change that practice in order not to cr

Re: [mp2] code freeze

2004-08-23 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: in case you haven't noticed i've posted an RC, so we enter the code freeze phase. So please avoid committing code changes, unless they are fixes of something that's broken (e.g. tests). I think we may want to change that practice

Re: [mp2] code freeze

2004-08-23 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: Stas Bekman wrote: in case you haven't noticed i've posted an RC, so we enter the code freeze phase. So please avoid committing code changes, unless they are fixes of something that's broken (e.g. tests). I think we may