Re: Preferred MPM?

2004-09-25 Thread David Wheeler
On Sep 24, 2004, at 12:46 PM, Stas Bekman wrote: Threaded mpms work just fine when serving static pages. There are all kind of problems when Perl is involved. Some of the problems are getting resolved, others are still there. It's probably the best to develop with prefork, at least because debug

Re: HEAD failures

2004-09-25 Thread Stas Bekman
Stas Bekman wrote: Philippe M. Chiasson wrote: It's not your tests that are at fault, Stas. Something else is broken, and that commit brought it out. As I said earlier, I've been having segfault problems with mp2 for a few days now (Tuesday it was the send_fd tests, which I wrote about on [EMAIL

Re: mp2 static building problem

2004-09-25 Thread Stas Bekman
Pratik wrote: I was building mp2 statically ( latest cvs version ) with the following : perl Makefile.PL MP_USE_STATIC=1 MP_INST_APACHE2=1 MP_AP_PREFIX=/home/pratik/src/mp2/httpd-2.0.51 MP_MAINTAINER=1 MP_AP_CONFIGURE="--enable-maintainer-mode --enable-so --enable-rewrite --enable-logio --enable-lo

[mp2] bug in PerlPassEnv

2004-09-25 Thread Stas Bekman
So my recent move of some of the tests and their config into their own vhost has exposed a bug in PerlPassEnv handling. If there is a PerlPassEnv entry in httpd.conf and there is no MP_HANDLER_TYPE_PER_SRV phase handler, it'll never be picked. The bug is in modperl_callback_run_handlers. For no

Re: APR::Table lost UTF8 flag

2004-09-25 Thread Stas Bekman
Boris Zentner wrote: Hi, Am 24.09.2004 um 14:30 schrieb Joe Schaefer: Boris Zentner <[EMAIL PROTECTED]> writes: [...] It makes only sense the other way around. A $apr->param('parameter'); must provide a valid object. That's why I suggested subclassing Apache::Request, so you can have param() do wh

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-25 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] trying to understand what the problem is and how to write a test for it and how to fix it. will keep you posted. The problem is that the current modperl_bucket.c implementation needs a proper setaside function. Think about it- the

Re: [mp2] bug in PerlPassEnv

2004-09-25 Thread Geoffrey Young
Stas Bekman wrote: > So my recent move of some of the tests and their config into their own > vhost has exposed a bug in PerlPassEnv handling. If there is a > PerlPassEnv entry in httpd.conf and there is no MP_HANDLER_TYPE_PER_SRV > phase handler, it'll never be picked. The bug is in > modperl_ca

Re: cvs commit: modperl-2.0/t/response/TestDirective env.pm

2004-09-25 Thread Stas Bekman
[EMAIL PROTECTED] wrote: [...] Index: env.pm === RCS file: /home/cvs/modperl-2.0/t/response/TestDirective/env.pm,v retrieving revision 1.5 retrieving revision 1.6 diff -u -u -r1.5 -r1.6 --- env.pm 25 Sep 2004 19:01:15 -00

taint issues (was: Re: cvs commit: modperl-2.0/t/response/TestDirective env.pm)

2004-09-25 Thread Stas Bekman
Stas Bekman wrote: [EMAIL PROTECTED] wrote: [...] Index: env.pm === RCS file: /home/cvs/modperl-2.0/t/response/TestDirective/env.pm,v retrieving revision 1.5 retrieving revision 1.6 diff -u -u -r1.5 -r1.6 --- env.pm25

Re: APR::Table lost UTF8 flag

2004-09-25 Thread Boris Zentner
Hi Stas, Am 25.09.2004 um 21:51 schrieb Stas Bekman: Boris Zentner wrote: Hi, Am 24.09.2004 um 14:30 schrieb Joe Schaefer: Boris Zentner <[EMAIL PROTECTED]> writes: [...] It makes only sense the other way around. A $apr->param('parameter'); must provide a valid object. That's why I suggested subc

Re: APR::Table lost UTF8 flag

2004-09-25 Thread Stas Bekman
Boris Zentner wrote: [...] May be expicitly setting the utf8 flag will work as a temp solution for you? If all your data is stored in utf8, then it will perfectly fine. No, this will not work in my case. Below is the revision of your test program, that does what you want. (If you didn't know, yo

Re: cvs commit: modperl-2.0 Changes

2004-09-25 Thread Stas Bekman
[EMAIL PROTECTED] wrote: stas2004/09/25 20:12:38 Modified:src/modules/perl modperl_callback.c .Changes Log: if some code changes the current interpreter's tainted state to on, the return value from the handler callback will be tainted, and we fail to dea

Re: t/SMOKE points the finger at filter/out_bbs_filebucket.t

2004-09-25 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: The error comes from return $filter->next->pass_brigade($bb2); in sub handler in TestFilter::out_bbs_filebucket; So it's some Apache filter that throws an error, It's wierder than that- the return value is tainted somehow: my $s

[mp2 patch for the archives] "inlining" APR::Error

2004-09-25 Thread Stas Bekman
while I was trying to figure out where the taint problem is coming from and before I've enclosed each callback call into PL_tainted untainting block, I've first ported APR::Error not to be a perl+xs module, but to be a part of the mod_perl.so. Of course there is an ugly part of eval_pv of the p