Re: [mp2] status with perl 5.6

2004-10-06 Thread Joe Orton
On Tue, Sep 28, 2004 at 12:24:12AM -0400, Stas Bekman wrote: > I've gleaned out almost all the issues with mp2 and 5.6, all were just > test tweaks. The only remaining issue is failing: t/perl/api.t, but it > doesn't fail on its own, so I'm running the SMOKE for it now. Hopefully > will know the

Re: [mp2] status with perl 5.6

2004-10-06 Thread Stas Bekman
Joe Orton wrote: On Tue, Sep 28, 2004 at 12:24:12AM -0400, Stas Bekman wrote: I've gleaned out almost all the issues with mp2 and 5.6, all were just test tweaks. The only remaining issue is failing: t/perl/api.t, but it doesn't fail on its own, so I'm running the SMOKE for it now. Hopefully will

Re: $bb->bucket_alloc();

2004-10-06 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] So, based on your experience, should we advise users to use that method just for convenience?. I trust your judgement over my own wrt giving user advice. I think the important thing is that users shouldn't start creating their ow

Re: [mp2] missing Apache::Util::escape_html

2004-10-06 Thread David Wheeler
On Oct 5, 2004, at 5:45 PM, Stas Bekman wrote: I wasn't suggesting that you do that, just asking for your opinion, but if you want to, that's great! There are two places that need to be fixed, on in Util.pm in the modperl source, the other is in src/docs/1.0/api/Apache/Util.pod. Oh, I see it alr

Re: [mp2] missing Apache::Util::escape_html

2004-10-06 Thread Stas Bekman
David Wheeler wrote: On Oct 5, 2004, at 5:45 PM, Stas Bekman wrote: I wasn't suggesting that you do that, just asking for your opinion, but if you want to, that's great! There are two places that need to be fixed, on in Util.pm in the modperl source, the other is in src/docs/1.0/api/Apache/Util.

Re: [mp2] missing Apache::Util::escape_html

2004-10-06 Thread David Wheeler
On Oct 6, 2004, at 2:48 PM, Stas Bekman wrote: Nope. I've just assumed that you already read the doc before submitting a bug report and it wasn't there. Indeed it already covers that :) D'oh! Thanks, David - To unsubscribe, e-mai

[Patch mp2] unescape_url_info

2004-10-06 Thread Philippe M. Chiasson
as per todo/release: Apache->unescape_url{_info}: - not yet implemented. should be moved to Apache::Util (or may be - APR::URI?) unescape_url has already been implemented, so this small patch ports the mp1 code to Apache::URI::unescape_url_info -- --

thread pools & dynamic config (was Re: segfault in worker mpm)

2004-10-06 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: > Joe Schaefer wrote: > >>#ifdef USE_ITHREADS > >> /* XXX: perhaps we can optimize this further. At the moment when > >> * perl w/ ithreads is used, we always deparse the anon subs > >> * before storing them and then eval them each time they a

Re: [Patch mp2] unescape_url_info

2004-10-06 Thread Stas Bekman
Philippe M. Chiasson wrote: as per todo/release: Apache->unescape_url{_info}: - not yet implemented. should be moved to Apache::Util (or may be - APR::URI?) I'd think it should live under ModPerl:: since it's not an Apache API function. But I'm not sure if it'll serve the best the user to

Re: t/TEST t/directive/cmdparms.t segfaults w/5.8.5+ithreads

2004-10-06 Thread Stas Bekman
Joe Schaefer wrote: [...] So it seems Perl_safesysmalloc depends on PERL_SET_CONTEXT. This patch fixes the segfault, but I'm not sure it's an acceptable solution: Index: src/modules/perl/modperl_module.c === RCS file: /home/cvspublic/

Re: [Patch mp2] unescape_url_info

2004-10-06 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: as per todo/release: Apache->unescape_url{_info}: - not yet implemented. should be moved to Apache::Util (or may be - APR::URI?) I'd think it should live under ModPerl:: since it's not an Apache API function. But I'm not sure if it'll serve

Re: t/TEST t/directive/cmdparms.t segfaults w/5.8.5+ithreads

2004-10-06 Thread Joe Schaefer
Stas Bekman <[EMAIL PROTECTED]> writes: [...] > Joe, this still needs to applied? But please make sure that you > restore the context when you are done with it. Look at the other > places where this is done (grep for SET_CONTEXT). AFAICT the only place where the context is "localized" is in modp

Re: [Patch mp2] unescape_url_info

2004-10-06 Thread Stas Bekman
Philippe M. Chiasson wrote: As usual, I usually try and complete the documentation once the code gets a go ;-) of course :) also continuing yesterdays story, this function doesn't know to deal with utf8 strings, right? in which case we might just as well drop it too? is there a CPAN implementati

Re: t/TEST t/directive/cmdparms.t segfaults w/5.8.5+ithreads

2004-10-06 Thread Stas Bekman
Joe Schaefer wrote: Stas Bekman <[EMAIL PROTECTED]> writes: [...] Joe, this still needs to applied? But please make sure that you restore the context when you are done with it. Look at the other places where this is done (grep for SET_CONTEXT). AFAICT the only place where the context is "localize

t/apr/bucket is dumping core on me

2004-10-06 Thread Philippe M. Chiasson
-8<-- Start Bug Report 8<-- 1. Problem Description: ./t/TEST -v apr/bucket is dumping core on me 2. Used Components and their Configuration: *** mod_perl version 1.9917 *** using [modperl-cvs]/lib/Apache/BuildConfig.pm *** Makefile.PL options: MP_APR_LIB

Re: segfault in worker mpm

2004-10-06 Thread Philippe M. Chiasson
I believe I have finally found what is going on, somewhat. Seems that calling Perl_load_module(aTHX_, flags, SV *name, SV *version, ...) should be safe, but it seems something is strange in how it's dealing with va_arg arguments. I've found that this patch seems to get rid of that segfault on my se