Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Geoffrey Young
Geoffrey Young wrote: >>Before I go ahead and check that in, I'd like to at least get a bit more >>feedback from the other folks that had been seeing this segfault, and >>confirmation that this patch _does_ get rid of it. > > > I'll give it a whirl tonight. whee! all tests pass. nice work.

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Philippe M. Chiasson
Geoffrey Young wrote: Geoffrey Young wrote: Before I go ahead and check that in, I'd like to at least get a bit more feedback from the other folks that had been seeing this segfault, and confirmation that this patch _does_ get rid of it. I'll give it a whirl tonight. whee! all tests pass. Good,

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Stas Bekman
Philippe M. Chiasson wrote: So, I guess I should just go ahead with my band-aid fix and we can worry about the _real_ problem later then? +1 -- __ Stas BekmanJAm_pH --> Just Another mod_perl Hacker http://stason.org/

Re: [Patch mp2] unescape_url_info

2004-10-14 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: [...] it's probably always a good idea to discuss first before spending time on things :) So, what do we do about it? Yank it out, document better alternatives, like CGI::Util::unescape() and possibly implement in Apache/compat.pm as : unescape_url

Re: [Patch mp2] segfault in worker mpm

2004-10-14 Thread Philippe M. Chiasson
Stas Bekman wrote: Philippe M. Chiasson wrote: So, I guess I should just go ahead with my band-aid fix and we can worry about the _real_ problem later then? +1 Band-aid applied! -- Philippe M. Chiasson m/gozer\@(apa

Re: [Patch mp2] unescape_url_info

2004-10-14 Thread Stas Bekman
Philippe M. Chiasson wrote: Stas Bekman wrote: Philippe M. Chiasson wrote: [...] it's probably always a good idea to discuss first before spending time on things :) So, what do we do about it? Yank it out, document better alternatives, like CGI::Util::unescape() and possibly implement in Apache