modperl_filter_t question

2010-04-02 Thread Torsten Förtsch
Hi, modperl_filter_t contains 2 bucket brigades: apr_bucket_brigade *bb_in; apr_bucket_brigade *bb_out; Each time a filter is invoked a new modperl_filter_t structure is created by modperl_filter_new. This function sets either bb_in or bb_out bit not both. It seems to me that it is not

Re: sanity check in Makefile.PL

2010-04-02 Thread Philip M. Gollucci
Are you sure? /usr/local is default on fbsd. I've never seen it. On 03/30/10 20:03, Fred Moyer wrote: This throws a warning if you build against httpd installed with prefix '/usr/local'. Is this location not expected? 545 sub system_sanity_check { 546 return if WIN32; 547 548 my $ccf

Re: simplify mod_perl.c a bit

2010-04-02 Thread Philip M. Gollucci
+1 On 03/31/10 15:07, Torsten Förtsch wrote: Hi, the patch below simplifies mod_perl.c a bit. Instead of modperl_response_handler_run(r, finish) { do something if( finish ) { modperl_response_finish() } } and calling that function in one place as modperl_response_handler_run(r

Re: modperl_filter_t question

2010-04-02 Thread Philip M. Gollucci
Yes, I believe you are, but I don't have time to decipher it myself either. On 04/02/10 17:40, Torsten Förtsch wrote: Hi, modperl_filter_t contains 2 bucket brigades: apr_bucket_brigade *bb_in; apr_bucket_brigade *bb_out; Each time a filter is invoked a new modperl_filter_t structu

Re: [patch]avoid closing fd 0/1

2010-04-02 Thread Philip M. Gollucci
God speed messing with PerlIO stuff. On 04/01/10 14:34, Torsten Förtsch wrote: On Wednesday 31 March 2010 17:55:47 Fred Moyer wrote: Can you repost the latest patch inline so that interested parties can add comments and understand what is going on in there? I know that only a few people under

Re: simplify mod_perl.c a bit

2010-04-02 Thread Randy Kobes
+1. -- best regards, Randy On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote: > +1 > > On 03/31/10 15:07, Torsten Förtsch wrote: >> Hi, >> >> the patch below simplifies mod_perl.c a bit. >> >> Instead of >> >> modperl_response_handler_run(r, finish) { >> do something >> if( finish ) {

Re: simplify mod_perl.c a bit

2010-04-02 Thread Fred Moyer
+1 On Fri, Apr 2, 2010 at 11:22 AM, Randy Kobes wrote: > +1. > > -- > best regards, > Randy > > On 2010-04-02, at 1:03 PM, Philip M. Gollucci wrote: > >> +1 >> >> On 03/31/10 15:07, Torsten Förtsch wrote: >>> Hi, >>> >>> the patch below simplifies mod_perl.c a bit. >>> >>> Instead of >>> >>> modp

Re: simplify mod_perl.c a bit

2010-04-02 Thread Philippe M. Chiasson
On 10-03-31 11:07 , Torsten Förtsch wrote: > Hi, > > the patch below simplifies mod_perl.c a bit. > > Instead of > > modperl_response_handler_run(r, finish) { > do something > if( finish ) { > modperl_response_finish() > } > } > > and calling that function in one place as > > modperl

Re: [patch]avoid closing fd 0/1

2010-04-02 Thread Philippe M. Chiasson
On 10-03-31 10:59 , Torsten Förtsch wrote: > On Wednesday 31 March 2010 16:43:04 Torsten Förtsch wrote: >> I believe the IoFLUSH_off in the override function can be omitted since >> this is standard for a new handle. >> > This appears to be true. This is now the final version of the patch. Are > t