Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread Adam Prime
Seems reasonable to me. It seems like it might be a good idea to fold this into 2.0.6 RC3 to me. Thoughts? Adam On 12-03-04 01:29 PM, SalusaSecondus wrote: (Patch and system details at bottom) - To unsubscribe, e-mail:

Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread Fred Moyer
Hi Salusa, Would you or Max be able to construct a unit test that demonstrates this failure condition, and then success once the patch is applied? There should be some example tests in the t/ directory which you can draw on for inspiration. On Sun, Mar 4, 2012 at 10:29 AM, SalusaSecondus wrote:

Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread Salusa Secondus
Adam, We'd love to see this in 2.0.6. This has caused us lots of server problems. Fred, I'll take a look at the tests when I get home to see what I can find. Do you know of any specific tests which deal with multi-threading or potential deadlocks? Greg -

Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread Fred Moyer
On Tue, Mar 6, 2012 at 11:12 AM, Salusa Secondus wrote: > Fred, > > I'll take a look at the tests when I get home to see what I can find. > Do you know of any specific tests which deal with multi-threading or > potential deadlocks? Torsten, Steve H., and Gozer know that part of the code a lot bet

Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread SalusaSecondus
I've looked through those tests, and none seem to apply and I'm not sure how one would even go about writing a unit test for this. We haven't even been able to reproduce the problem on all systems. I suspect the best we can do may simply be manual load tests (such as Max and I have done) showing

Re: [PATCH 2.0.5 futex] Fix to Children stuck on futex problem

2012-03-06 Thread Adam Prime
The bug is a race condition, so as you say, I don't really think it's definitively testable. Adam On 3/6/2012 10:19 PM, SalusaSecondus wrote: I've looked through those tests, and none seem to apply and I'm not sure how one would even go about writing a unit test for this. We haven't even been