Re: mod_perl head build with httpd 2.4.6 on Linux results

2014-01-30 Thread Jan Kaluža
Hi again, I've been able to fix the problem with freezing tests with event MPM using attached patch. The problem is that currently I'm somehow confused by the patched code. Does somebody have an idea why the previous code thought that refcount == 0 means that perl interpreter is still in use

RE: mod_perl head build with httpd 2.4.6 on Linux results

2014-01-30 Thread Steve Hay
Surely the old code is saying that refcount != 0 means the interpreter is still in use?: -if (interp->refcnt != 0) { +if (interp->refcnt > 1) { --interp->refcnt; MP_TRACE_i(MP_FUNC, "interp=0x%lx, refcnt=%d -- interp still in use", (unsigned long)inte

Re: mod_perl head build with httpd 2.4.6 on Linux results

2014-01-30 Thread Jan Kaluža
On 01/30/2014 10:45 AM, Steve Hay wrote: Surely the old code is saying that refcount != 0 means the interpreter is still in use?: -if (interp->refcnt != 0) { +if (interp->refcnt > 1) { --interp->refcnt; MP_TRACE_i(MP_FUNC, "interp=0x%lx, refcnt=%d -- interp still in

RE: mod_perl head build with httpd 2.4.6 on Linux results

2014-01-30 Thread Steve Hay
Ah, sorry, it's making more sense now. I hadn't taken in the fact that refcnt is decremented *before* the MP_TRACE! I think your patch looks good, looking at a larger chunk of code: MP_TRACE_i(MP_FUNC, "unselect(interp=%pp): refcnt=%d", interp, interp->refcnt); if (interp

Re: Please delete old releases from mirroring system

2014-01-30 Thread Steve Hay
On 27 January 2014 23:38, sebb wrote: > On 27 January 2014 21:12, Steve Hay wrote: >> On 27 January 2014 18:12, sebb wrote: >>> On 27 January 2014 09:21, Steve Hay wrote: On 31 December 2013 17:53, sebb wrote: > It's also quite unusual to have a browsable copy of the source on the >>>