[
https://issues.apache.org/jira/browse/PHOENIX-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110395#comment-14110395
]
Jan Van Besien commented on PHOENIX-1204:
-
yes, this is certainly an improvement
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698610
--- Diff:
phoenix-core/src/it/java/org/apace/phoenix/hbase/schema/stats/StatsCollectorIT.java
---
@@ -0,0 +1,260 @@
+package
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698623
--- Diff:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseParallelIteratorsRegionSplitterIT.java
---
@@ -86,10 +87,14 @@ protected void
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698634
--- Diff: phoenix-core/src/main/antlr3/PhoenixSQL.g ---
@@ -104,12 +102,13 @@ tokens
MINVALUE='minvalue';
MAXVALUE='maxvalue';
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698733
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698962
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16698996
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699028
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1594,4 +1775,46 @@ public boolean
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699103
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/parse/UpdateStatisticsStatement.java
---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699116
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
---
@@ -84,7 +84,7 @@
public static final int
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699137
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -461,6 +471,57 @@ public MutationState
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699150
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699156
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
@@ -461,6 +471,57 @@ public MutationState
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699208
--- Diff: phoenix-protocol/src/main/StatisticsCollect.proto ---
@@ -0,0 +1,20 @@
+option java_package = org.apache.phoenix.coprocessor.generated;
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699284
--- Diff:
phoenix-core/src/it/java/org/apace/phoenix/hbase/schema/stats/StatsCollectorIT.java
---
@@ -0,0 +1,260 @@
+package
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699329
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stat/StatisticsScanner.java
---
@@ -0,0 +1,109 @@
+/*
--- End diff --
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699399
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stat/PTableStats.java ---
@@ -22,23 +22,116 @@
import
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699418
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699454
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stat/PTableStatsImpl.java
---
@@ -16,40 +16,249 @@
* limitations under the License.
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699479
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -1594,4 +1775,46 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699532
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stat/StatisticsScanner.java
---
@@ -0,0 +1,109 @@
+/*
--- End diff --
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16699691
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/stat/PTableStatsImpl.java
---
@@ -16,40 +16,249 @@
* limitations under the License.
Github user JamesRTaylor commented on the pull request:
https://github.com/apache/phoenix/pull/8#issuecomment-53386020
One thing I didn't see is how you're handling multiple column families. Is
that still left to be done? Think a bit on when you think is the best time to
merge the
[
https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110456#comment-14110456
]
James Taylor commented on PHOENIX-852:
--
+1. Looks great, [~maryannxue]. Have you
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110506#comment-14110506
]
Sun Fulin commented on PHOENIX-1203:
James Taylor - I rebuilt the latest phoenix
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sun Fulin updated PHOENIX-1203:
---
Comment: was deleted
(was: James Taylor - I rebuilt the latest phoenix version 4.1 RC from here:
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16704394
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16704699
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
---
@@ -664,14 +698,161 @@ private PTable
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16705274
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -806,6 +849,11 @@ public AlterIndexStatement
Github user ramkrish86 commented on the pull request:
https://github.com/apache/phoenix/pull/8#issuecomment-53409242
One thing I didn't see is how you're handling multiple column families.
Is that still left to be done?
No not yet in this patch. I initially created a patch
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16708853
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16720778
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -228,10 +271,10 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16720739
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16720836
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -228,10 +271,10 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16720928
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java ---
@@ -806,6 +849,11 @@ public AlterIndexStatement
[
https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110890#comment-14110890
]
James Taylor commented on PHOENIX-852:
--
And instead of the code below, it'd be
[
https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14110918#comment-14110918
]
Maryann Xue commented on PHOENIX-852:
-
bq. One other question. In HashCacheClient,
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16726689
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16726785
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16728896
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
[
https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111020#comment-14111020
]
Maryann Xue commented on PHOENIX-852:
-
I had not read the new WhereOptimizer code
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16729698
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
[
https://issues.apache.org/jira/browse/PHOENIX-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111030#comment-14111030
]
James Taylor commented on PHOENIX-1204:
---
Yes, I agree too - this was the intention
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/8#discussion_r16730042
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelIteratorRegionSplitter.java
---
@@ -138,14 +146,10 @@ public boolean
[
https://issues.apache.org/jira/browse/PHOENIX-852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111059#comment-14111059
]
James Taylor commented on PHOENIX-852:
--
My top level point is to make sure we have a
Ravi Kishore Valeti created PHOENIX-1212:
Summary: Create table if not exists throws TableNotEnaledException
while promoting Hbase Table to Phoenix
Key: PHOENIX-1212
URL:
[
https://issues.apache.org/jira/browse/PHOENIX-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Kishore Valeti updated PHOENIX-1212:
-
Description:
When multiple threads run create table if not exists concurrently
[
https://issues.apache.org/jira/browse/PHOENIX-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Kishore Valeti updated PHOENIX-1212:
-
Description:
When multiple threads run create table if not exists concurrently
[
https://issues.apache.org/jira/browse/PHOENIX-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Kishore Valeti updated PHOENIX-1212:
-
Description:
When multiple threads run create table if not exists concurrently
[
https://issues.apache.org/jira/browse/PHOENIX-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ravi Kishore Valeti updated PHOENIX-1212:
-
Description:
When multiple threads run create table if not exists concurrently
[
https://issues.apache.org/jira/browse/PHOENIX-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111552#comment-14111552
]
Eli Levine commented on PHOENIX-1204:
-
[~janvanbes...@ngdata.com] Take a look at the
[
https://issues.apache.org/jira/browse/PHOENIX-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111709#comment-14111709
]
Andrew Purtell commented on PHOENIX-1201:
-
Was this just fixed on PHOENIX-1183?
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111739#comment-14111739
]
James Taylor commented on PHOENIX-1203:
---
[~sunfl] Please attach your unit test
[
https://issues.apache.org/jira/browse/PHOENIX-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111745#comment-14111745
]
Andrew Purtell commented on PHOENIX-1107:
-
bq. a single subclass of Replication
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111750#comment-14111750
]
Sun Fulin commented on PHOENIX-1203:
[~jamestaylor] Fine. Following provides the
[
https://issues.apache.org/jira/browse/PHOENIX-1206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Taylor updated PHOENIX-1206:
--
Summary: Decimal serialization broken for negative numbers with more than
19 digits of
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111817#comment-14111817
]
Anoop Sam John commented on PHOENIX-1203:
-
Is it possible to put the test into a
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111831#comment-14111831
]
Anoop Sam John commented on PHOENIX-1203:
-
Sure NP...
Uable to work for count
[
https://issues.apache.org/jira/browse/PHOENIX-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111863#comment-14111863
]
Sun Fulin commented on PHOENIX-1203:
[~anoop.hbase]
Do you have available phoenix
It looks like the version information from pom's isn't being passed down.
This is an ivy report, from SBT, so it could either be some Maven foo is
screwing up Ivy's resolver or there is just a bug. Thoughts?
working@sweettea is my machine.
[info]
[
https://issues.apache.org/jira/browse/PHOENIX-761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111894#comment-14111894
]
James Taylor commented on PHOENIX-761:
--
Looks fantastic, [~kbuzsaki]. Thanks for the
[
https://issues.apache.org/jira/browse/PHOENIX-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14111897#comment-14111897
]
Jan Van Besien commented on PHOENIX-1204:
-
Perfect, no more confusion and both
62 matches
Mail list logo
