[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116659785 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ViewFinder.java --- @@ -0,0 +1,241 @@ +/** + * Licensed to the Apache Software

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116659570 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -535,19 +539,115 @@ public void

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116659343 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/TableViewFinderResult.java --- @@ -0,0 +1,50 @@ +/** + * Licensed to the

[jira] [Updated] (PHOENIX-3854) phoenix can't read some data of hbase table

2017-05-15 Thread Hyunwoo,Han (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hyunwoo,Han updated PHOENIX-3854: - Environment: CentOS release 6.6(64bit), HBase 1.2.4 (was: CentOS release 6.6(64bit)) >

[jira] [Commented] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN

2017-05-15 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011557#comment-16011557 ] Samarth Jain commented on PHOENIX-3822: --- The test reported by QA passes locally. Re-running the

[jira] [Created] (PHOENIX-3854) phoenix can't read some data of hbase table

2017-05-15 Thread Hyunwoo,Han (JIRA)
Hyunwoo,Han created PHOENIX-3854: Summary: phoenix can't read some data of hbase table Key: PHOENIX-3854 URL: https://issues.apache.org/jira/browse/PHOENIX-3854 Project: Phoenix Issue Type:

[jira] [Commented] (PHOENIX-3655) Metrics for PQS

2017-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011520#comment-16011520 ] ASF GitHub Bot commented on PHOENIX-3655: - Github user rahulsIOT commented on the issue:

[GitHub] phoenix issue #242: PQS metrics - https://issues.apache.org/jira/browse/PHOE...

2017-05-15 Thread rahulsIOT
Github user rahulsIOT commented on the issue: https://github.com/apache/phoenix/pull/242 Metrics Snippet **Statement Level -**

[GitHub] phoenix issue #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/248 This is looking really good, @churrodog. For testing purposes, I think it'd be really good if we split the SYSTEM.CATALOG table at points that'll force it to span multiple regions during the

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116626201 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -381,7 +383,8 @@

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116626026 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PColumnImpl.java --- @@ -159,15 +199,6 @@ public SortOrder getSortOrder() {

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116625769 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2324,96 +2488,97 @@ else if (pkCount <=

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116625600 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java --- @@ -107,12 +107,14 @@ public void

[jira] [Commented] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN

2017-05-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011506#comment-16011506 ] Hadoop QA commented on PHOENIX-3822: {color:red}-1 overall{color}. Here are the results of testing

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/248#discussion_r116625014 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/PTableImpl.java --- @@ -500,8 +510,20 @@ private void init(PName tenantId, PName

[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN

2017-05-15 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: (was: PHOENIX-3822.patch) > Surface byte and row estimates in a machine

[jira] [Updated] (PHOENIX-3822) Surface byte and row estimates in a machine readable way when doing EXPLAIN PLAN

2017-05-15 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-3822: -- Attachment: PHOENIX-3822.patch [~jamestaylor], please review. > Surface byte and row

[GitHub] phoenix issue #248: Phoenix 3534

2017-05-15 Thread churrodog
Github user churrodog commented on the issue: https://github.com/apache/phoenix/pull/248 @twdsilva would you mind taking a look as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (PHOENIX-3853) Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch

2017-05-15 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011446#comment-16011446 ] Lars Hofhansl commented on PHOENIX-3853: Hmm... So PHOENIX-3827 introduces a new super-linear

[jira] [Updated] (PHOENIX-3853) Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch

2017-05-15 Thread Mujtaba Chohan (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan updated PHOENIX-3853: Description: HBase 1.3.1 with head of Phoenix 4.x with/without PHOENIX-3827 v2 patch

[jira] [Created] (PHOENIX-3853) Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch

2017-05-15 Thread Mujtaba Chohan (JIRA)
Mujtaba Chohan created PHOENIX-3853: --- Summary: Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch Key: PHOENIX-3853 URL:

[jira] [Updated] (PHOENIX-3853) Local Index - Writes to local index are twice as slow as global and get exponentially slower with PHOENIX-3827_v2 patch

2017-05-15 Thread Mujtaba Chohan (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mujtaba Chohan updated PHOENIX-3853: Attachment: batch_time.png > Local Index - Writes to local index are twice as slow as

[GitHub] phoenix issue #239: Phoenix-3744: Support snapshot scanners for MR-based que...

2017-05-15 Thread akshita-malhotra
Github user akshita-malhotra commented on the issue: https://github.com/apache/phoenix/pull/239 Thanks @JamesRTaylor . I squashed the commits and changed the prefix of the commit message. I will answer/make appropriate changes and upload the patch onto the jira. --- If your project

[jira] [Commented] (PHOENIX-3534) Support multi region SYSTEM.CATALOG table

2017-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011349#comment-16011349 ] ASF GitHub Bot commented on PHOENIX-3534: - Github user JamesRTaylor commented on the issue:

[GitHub] phoenix issue #248: Phoenix 3534

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/248 I'll check it out, but in the meantime would you mind amending your commit message from "Phoenix 3534" to "PHOENIX-3534 Support multi region SYSTEM.CATALOG table" - that way comments on the

[GitHub] phoenix pull request #248: Phoenix 3534

2017-05-15 Thread churrodog
GitHub user churrodog opened a pull request: https://github.com/apache/phoenix/pull/248 Phoenix 3534 I'll squash these down after a review You can merge this pull request into a Git repository by running: $ git pull https://github.com/churrodog/phoenix PHOENIX-3534

Re: Integration Tests hang/fail

2017-05-15 Thread Andrew Purtell
Some IT tests have timed out for me in the past. I think that was with 4.9 though. One thing that helps diagnose such issues is running the tests serially - 'mvn clean install package -DnumForkedIT=1 -DnumForkedUT=1' - so that when you get a hang it is clear which unit is hanging and there are

[GitHub] phoenix issue #239: Phoenix-3744: Support snapshot scanners for MR-based que...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/239 Thanks for the updates, @akshita-malhotra - I made a few comments/questions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116564003 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java --- @@ -592,7 +592,7 @@ private static String

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116562713 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/NonAggregateROUtil.java --- @@ -0,0 +1,355 @@ +package org.apache.phoenix.util; +

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116562096 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java --- @@ -25,6 +25,7 @@ QUERY_TIME("Query times"),

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116561507 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java --- @@ -185,7 +188,10 @@ private QueryPlan

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116560730 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -496,6 +496,17 @@ public

[GitHub] phoenix issue #239: Phoenix-3744: Support snapshot scanners for MR-based que...

2017-05-15 Thread akshita-malhotra
Github user akshita-malhotra commented on the issue: https://github.com/apache/phoenix/pull/239 Sure, I will do that. Thanks @JamesRTaylor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (PHOENIX-3744) Support snapshot scanners for MR-based queries

2017-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011009#comment-16011009 ] ASF GitHub Bot commented on PHOENIX-3744: - Github user JamesRTaylor commented on the issue:

[GitHub] phoenix issue #229: PHOENIX-3572 Support FETCH NEXT|n ROWS query on cursor

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on the issue: https://github.com/apache/phoenix/pull/229 This looks good now, @bijugs - much simpler - nice work. Have you attached a patch in the right format (see https://phoenix.apache.org/contributing.html#Generate_a_patch) to make sure your

[jira] [Commented] (PHOENIX-3572) Support FETCH NEXT| n ROWS from Cursor

2017-05-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011000#comment-16011000 ] ASF GitHub Bot commented on PHOENIX-3572: - Github user JamesRTaylor commented on the issue:

[jira] [Updated] (PHOENIX-3812) Use HBase snapshots in async index building M/R job

2017-05-15 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Taylor updated PHOENIX-3812: -- Summary: Use HBase snapshots in async index building M/R job (was: Explore using HBase

[jira] [Created] (PHOENIX-3852) Support snapshot scanner M/R jobs for aggregate queries

2017-05-15 Thread Akshita Malhotra (JIRA)
Akshita Malhotra created PHOENIX-3852: - Summary: Support snapshot scanner M/R jobs for aggregate queries Key: PHOENIX-3852 URL: https://issues.apache.org/jira/browse/PHOENIX-3852 Project: Phoenix

[jira] [Commented] (PHOENIX-3811) Do not disable index on write failure by default

2017-05-15 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010919#comment-16010919 ] James Taylor commented on PHOENIX-3811: --- The rationale for changing this was explained here:

indexedWALEditCodec may break hbase replication

2017-05-15 Thread Yi Liang
Hi, I am trying use Phoenix to put data, and seems hbase replication can not work. Below is my detail steps I followed. BTW, I am using hbase 1.2.4 and phoenix 4.6 (1) Enable HBase replication, like setting hbase.replication=true. //HBase replication works fine without Phoenix after step (1)

[jira] [Commented] (PHOENIX-3851) Upgrade Joda-Time library to 2.8.1+

2017-05-15 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010759#comment-16010759 ] Ted Yu commented on PHOENIX-3851: - HBASE-15199 is fixed in the upcoming hbase 2.0 release > Upgrade

[jira] [Created] (PHOENIX-3851) Upgrade Joda-Time library to 2.8.1+

2017-05-15 Thread Ted Yu (JIRA)
Ted Yu created PHOENIX-3851: --- Summary: Upgrade Joda-Time library to 2.8.1+ Key: PHOENIX-3851 URL: https://issues.apache.org/jira/browse/PHOENIX-3851 Project: Phoenix Issue Type: Bug

Integration Tests hang/fail

2017-05-15 Thread Lars George
Hi, I am trying to build a 4.8.2 package and when running the ITs, it starts to stall and eventually stops to proceed - without any further feedback - when it gets to the "NeedTheirOwnClusterTests" group. I also get JVM SEGVs at times, and other interesting errors, though in the end the stalls

[jira] [Commented] (PHOENIX-3734) Refactor Phoenix to use TAL instead of direct calls to Tephra

2017-05-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010236#comment-16010236 ] Hadoop QA commented on PHOENIX-3734: {color:red}-1 overall{color}. Here are the results of testing

Re: Question about Git tag for 4.8.2 release and RC2

2017-05-15 Thread Lars George
Hi Josh, I think the point LarsF was making is that there are tags missing for 4.8.2, it is only the commits as you stated. See https://www.dropbox.com/s/xh3g008te08mwbg/Screenshot%202017-05-15%2008.32.45.png?dl=0 for reference of what we are seeing (which has no "tag" link to those commits). No