stoty commented on code in PR #6:
URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946644709
##
.asf.yaml:
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
stoty commented on code in PR #6:
URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946644709
##
.asf.yaml:
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+#
richardantal commented on code in PR #6:
URL: https://github.com/apache/phoenix-thirdparty/pull/6#discussion_r946622496
##
.asf.yaml:
##
@@ -0,0 +1,34 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
gjacoby126 commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r946078799
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
gjacoby126 merged PR #113:
URL: https://github.com/apache/phoenix-omid/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gjacoby126 merged PR #112:
URL: https://github.com/apache/phoenix-omid/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945523712
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
Aarchy commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r945500706
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
stoty commented on code in PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#discussion_r945433122
##
pom.xml:
##
@@ -168,7 +168,7 @@
0.6.1
1.6.2
4.13.1
-1.10.19
+2.28.2
Review Comment:
nit:
AFAIK the mockito
stoty closed pull request #108: OMID-224 Switch default logging backend to
log4j2
URL: https://github.com/apache/phoenix-omid/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stoty commented on PR #108:
URL: https://github.com/apache/phoenix-omid/pull/108#issuecomment-1214627742
Yes, @apurtell , the only log4j dependencies are the test/runtime log4j2
dependencies for tests and benchmarks, examples, etc.
--
This is an automated message from the Apache Git
apurtell opened a new pull request, #113:
URL: https://github.com/apache/phoenix-omid/pull/113
Some snakeyaml versions are no the Snyk naught list.
See https://security.snyk.io/package/maven/org.yaml:snakeyaml
Upgrade it.
--
This is an automated message from the Apache Git
apurtell opened a new pull request, #112:
URL: https://github.com/apache/phoenix-omid/pull/112
Some jcommander versions are on the Snyk naughty list.
https://security.snyk.io/package/maven/com.beust:jcommander
Upgrade it.
--
This is an automated message from the Apache Git
apurtell commented on PR #111:
URL: https://github.com/apache/phoenix-omid/pull/111#issuecomment-1213418408
All unit tests passed for me locally before I pushed this up.
Phoenix itself is using mockito-core 1.x and should align with HBase, which
is using 2.28.2 on branch-2.4 and
apurtell opened a new pull request, #111:
URL: https://github.com/apache/phoenix-omid/pull/111
At some point OMID will upgrade to latest Hadoop 2.10 and HBase 2.4 releases
and will then experience IncompatibleClassChangeErrors in unit tests due to a
conflict between mockito-all used here
apurtell closed pull request #110: OMID-225 Migrate from log4j1 to reload4j
URL: https://github.com/apache/phoenix-omid/pull/110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
apurtell opened a new pull request, #110:
URL: https://github.com/apache/phoenix-omid/pull/110
Log4J1 is abandoned and has a number of significant CVEs filed for it.
[Reload4J](https://reload4j.qos.ch) is a drop in binary compatible replacement
for Log4J1 with all known security issues
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940369614
##
common/src/main/java/org/apache/omid/YAMLUtils.java:
##
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String
defaultResourcePath) throws
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940365337
##
pom.xml:
##
@@ -158,7 +158,7 @@
2.0.0
3.0
6.10
-1.7.36
+1.7.30
Review Comment:
Agree, we want the latest version.
stoty commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r940355736
##
hbase-coprocessor/src/main/java/org/apache/omid/transaction/CellSkipFilterBase.java:
##
@@ -53,21 +53,21 @@ public CellSkipFilterBase(Filter filter) {
*/
richardantal commented on code in PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#discussion_r937688092
##
common/src/main/java/org/apache/omid/YAMLUtils.java:
##
@@ -64,7 +64,6 @@ public Map loadSettings(String resourcePath, String
defaultResourcePath) throws
stoty commented on PR #109:
URL: https://github.com/apache/phoenix-omid/pull/109#issuecomment-1208221678
Thre are still some deprecation warnings:
```
[WARNING]
/home/stoty/workspaces/apache-phoenix/omid/statemachine/src/main/java/org/apache/statemachine/StateMachine.java:[246,24]
stoty commented on code in PR #108:
URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939812812
##
hbase-commit-table/pom.xml:
##
@@ -112,13 +117,32 @@
curator-test
test
+
+
+
+
+
+
gjacoby126 commented on code in PR #108:
URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939545022
##
hbase-commit-table/pom.xml:
##
@@ -112,13 +117,32 @@
curator-test
test
+
+
+
+
+
+
stoty opened a new pull request, #108:
URL: https://github.com/apache/phoenix-omid/pull/108
Replace logging config based on HBase
Change logging configuration for tso-server to match the HBase setup
--
This is an automated message from the Apache Git Service.
To respond to the message,
dependabot[bot] opened a new pull request, #115:
URL: https://github.com/apache/phoenix-tephra/pull/115
Bumps [libthrift](https://github.com/apache/thrift) from 0.9.3-1 to 0.14.0.
Release notes
Sourced from https://github.com/apache/thrift/releases;>libthrift's
releases.
dependabot[bot] opened a new pull request, #107:
URL: https://github.com/apache/phoenix-omid/pull/107
Bumps hadoop-yarn-server-common from 2.10.0 to 2.10.2.
[![Dependabot compatibility
dependabot[bot] opened a new pull request, #106:
URL: https://github.com/apache/phoenix-omid/pull/106
Bumps hadoop-common from 2.10.0 to 3.2.3.
[![Dependabot compatibility
stoty closed pull request #105: OMID-222 Remove HBase1 support and update HBase
2 version to 2.4
URL: https://github.com/apache/phoenix-omid/pull/105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stoty commented on PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1157352943
Fixed both versions, @gjacoby126.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788305
##
pom.xml:
##
@@ -190,8 +175,8 @@
1.10
1.3
-2.13.0
-3.4.9
+4.3.0
Review Comment:
Right again, fixing it.
--
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898788288
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898299565
##
pom.xml:
##
@@ -190,8 +175,8 @@
1.10
1.3
-2.13.0
-3.4.9
+4.3.0
Review Comment:
I believe in
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r898298858
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
stoty commented on PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1154680247
I had to pause working on 5.2 stuff due to @dayjob deadlines, but now I can
resume work on it. (Bar the usual summer PTOs)
Can you please re-review @gjacoby126 ?
We can
dependabot[bot] opened a new pull request, #114:
URL: https://github.com/apache/phoenix-tephra/pull/114
Bumps [gson](https://github.com/google/gson) from 2.2.4 to 2.8.9.
Release notes
Sourced from https://github.com/google/gson/releases;>gson's
releases.
Gson 2.8.9
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445938
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445600
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875445204
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875444085
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875443116
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875439934
##
pom.xml:
##
@@ -612,20 +570,28 @@
hbase-1
-
-
-
-
-hbase-2
-
-
stoty commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875438343
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875233006
##
pom.xml:
##
@@ -147,33 +146,19 @@
-
-hbase1.x
-hbase2.x
-
-
omid-hbase-shims-${hbase1.artifactId.suffix}
-
gjacoby126 commented on code in PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#discussion_r875216816
##
hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java:
##
@@ -137,7 +136,7 @@ public void testCorrectMapingOfCellsToShadowCells() throws
stoty commented on PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129271715
The failure with hbase-1 profile is intentional, as it is no longer
supported.
I'm going to update the test job.
--
This is an automated message from the Apache Git Service.
To
gjacoby126 commented on PR #105:
URL: https://github.com/apache/phoenix-omid/pull/105#issuecomment-1129262892
Build fails with an enforcer rule to always fail?
`[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce) @ omid ---
[WARNING] Rule 0:
stoty closed pull request #103: Bump junit from 4.13 to 4.13.1
URL: https://github.com/apache/phoenix-omid/pull/103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] commented on PR #103:
URL: https://github.com/apache/phoenix-omid/pull/103#issuecomment-1108790486
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor version,
stoty commented on PR #103:
URL: https://github.com/apache/phoenix-omid/pull/103#issuecomment-1108790443
Merged from a cloned commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stoty closed pull request #104: OMID-221 Bump junit from 4.13 to 4.13.1
URL: https://github.com/apache/phoenix-omid/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stoty opened a new pull request, #104:
URL: https://github.com/apache/phoenix-omid/pull/104
Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1.
- [Release notes](https://github.com/junit-team/junit4/releases)
-
dependabot[bot] opened a new pull request, #103:
URL: https://github.com/apache/phoenix-omid/pull/103
Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1.
Release notes
Sourced from https://github.com/junit-team/junit4/releases;>junit's
releases.
JUnit
stoty closed pull request #102: OMID-220 Update netty to 4.1.76.Final
URL: https://github.com/apache/phoenix-omid/pull/102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
stoty closed pull request #101: OMID-219 Update to phoenix-thirdparty 2.0
URL: https://github.com/apache/phoenix-omid/pull/101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dependabot[bot] commented on PR #113:
URL: https://github.com/apache/phoenix-tephra/pull/113#issuecomment-1097821338
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor
stoty closed pull request #113: Bump hadoop-common from 2.2.0 to 3.2.3
URL: https://github.com/apache/phoenix-tephra/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
stoty commented on PR #113:
URL: https://github.com/apache/phoenix-tephra/pull/113#issuecomment-1097821271
No way, Jose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #113:
URL: https://github.com/apache/phoenix-tephra/pull/113
Bumps hadoop-common from 2.2.0 to 3.2.3.
[