Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/186#discussion_r73024725
--- Diff: bin/sqlline-thin.py ---
@@ -18,64 +18,58 @@
# limitations under the License
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/186#discussion_r73024268
--- Diff: bin/sqlline-thin.py ---
@@ -86,73 +80,83 @@ def get_serialization():
return default_serialization
return stdout
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/186#discussion_r73024052
--- Diff: bin/sqlline-thin.py ---
@@ -18,64 +18,58 @@
# limitations under the License
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/186
Great! I've given you karma and assigned PHOENIX-3132 to you.
> I was waiting for a response do this PR before I took on more refactoring
;)
Hah! Smart :)
>
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/186
Hi @btbytes! Thanks for the changes so far. A couple of things:
1. Have you opened a JIRA issue which captures the changes you'd like to
make? We want to make sure that JIRA is the source
Github user joshelser closed the pull request at:
https://github.com/apache/phoenix/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/183
Thanks for all of the help everyone. This was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/183
@apurtell I got some emails from you on the naming of the tarballs, but I'm
struggling to find the thread here on GH. I'm not actually 100% positive if the
artifacts being named "ph
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/183
Thanks again for taking a look at this, Sean! You found some really nice
brain farts from me.
Changes made:
* Clarified CDDL 1.0 and 1.1 references in LICENSE
* Included CDDL 1.0
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71731461
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71731040
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71729382
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71728385
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71727249
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71727042
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71724651
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71724269
--- Diff: dev/release_files/LICENSE ---
@@ -201,28 +201,1238 @@
See the License for the specific language governing permissions
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71724215
--- Diff: NOTICE ---
@@ -1,37 +1,18 @@
+Apache Phoenix
+Copyright 2013-2016 The Apache Software Foundation
+
This product includes
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71724014
--- Diff: NOTICE ---
@@ -1,37 +1,18 @@
+Apache Phoenix
+Copyright 2013-2016 The Apache Software Foundation
+
This product includes
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/183
Ok, I think this one is good to go. Any chance I could bug some folks to
glance over these changes (I know they're massive). @billierinaldi, @joewitt,
@apurtell, @busbey
FYI
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71407328
--- Diff: LICENSE ---
@@ -200,3 +200,90 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License
Github user joshelser commented on the issue:
https://github.com/apache/phoenix/pull/183
7d9adab removes the license headers from `examples/**/*.sql` and re-adds
the exclusions to apache-rat-plugin. Filed
https://issues.apache.org/jira/browse/PHOENIX-3099 to track it.
---
If your
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71396909
--- Diff: LICENSE ---
@@ -200,3 +200,90 @@
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/183#discussion_r71396256
--- Diff: examples/STOCK_SYMBOL.sql ---
@@ -1,3 +1,19 @@
+-- Licensed to the Apache Software Foundation (ASF) under one
+-- or more contributor
GitHub user joshelser opened a pull request:
https://github.com/apache/phoenix/pull/183
PHOENIX-3084 source release licensing issues.
Fixes for the Apache Phoenix source release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66113124
--- Diff: phoenix-client/pom.xml ---
@@ -0,0 +1,381 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66099747
--- Diff: bin/queryserver.py ---
@@ -119,7 +119,7 @@
# The command is run through subprocess so environment variables are
automatically
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66099573
--- Diff: phoenix-client/pom.xml ---
@@ -0,0 +1,381 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66097370
--- Diff: phoenix-assembly/src/build/components/all-common-jars.xml ---
@@ -88,12 +93,12 @@
${project.basedir}/../phoenix-server/target
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66096699
--- Diff: phoenix-client/pom.xml ---
@@ -0,0 +1,381 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66093991
--- Diff: phoenix-client/pom.xml ---
@@ -0,0 +1,381 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66094212
--- Diff: bin/queryserver.py ---
@@ -119,7 +119,7 @@
# The command is run through subprocess so environment variables are
automatically
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66094042
--- Diff: phoenix-server/pom.xml ---
@@ -7,52 +30,98 @@
4.8.0-HBase-1.2-SNAPSHOT
phoenix-server
- Phoenix Query Server
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/159#discussion_r66094488
--- Diff: phoenix-client/pom.xml ---
@@ -0,0 +1,381 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w
Github user joshelser commented on the pull request:
https://github.com/apache/phoenix/pull/155#issuecomment-211454505
@ss77892 one more nit-pick, it seems like you removed the version for some
of the entries in the pom but then added `${hadoop-two.version}` for others. I
would
Github user joshelser commented on the pull request:
https://github.com/apache/phoenix/pull/155#issuecomment-210678972
Recent improvements look good! The new integration test is *very* nice. The
ObjectInspector stuff isn't a huge deal to replace, but it's something that can
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59953321
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java ---
@@ -6,9 +6,9 @@
* to you under the Apache License, Version 2.0
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59953160
--- Diff: phoenix-hive/pom.xml ---
@@ -117,66 +93,44 @@
- org.apache.hbase
- hbase-common
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59558697
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/mapreduce/PhoenixResultWritable.java
---
@@ -0,0 +1,215 @@
+/**
+ * Licensed
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59558405
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java
---
@@ -0,0 +1,150
Github user joshelser commented on the pull request:
https://github.com/apache/phoenix/pull/155#issuecomment-208626268
> it's hard to get all those miniclusters run together. I still hope to get
it resolved. That's why the pom contains dependencies on calcite, hbase-test
and oth
Github user joshelser commented on the pull request:
https://github.com/apache/phoenix/pull/155#issuecomment-208542873
Some general thoughts (I stopped leaving them inline everytime I saw them).
I'm guessing you "inherited" some of these from JeongMin's original work.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59272080
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/objectinspector/PhoenixObjectInspectorFactory.java
---
@@ -0,0 +1,150
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59271033
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/constants/PhoenixStorageHandlerConstants.java
---
@@ -0,0 +1,101
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59270355
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixRowKey.java ---
@@ -0,0 +1,69 @@
+/**
+ * Licensed to the Apache Software
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269847
--- Diff:
phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixMetaHook.java ---
@@ -0,0 +1,245 @@
+/**
+ * Licensed to the Apache Software
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269604
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269559
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269345
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269404
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269299
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/155#discussion_r59269276
--- Diff: phoenix-hive/pom.xml ---
@@ -0,0 +1,224 @@
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLS
Github user joshelser commented on the pull request:
https://github.com/apache/phoenix/pull/144#issuecomment-164001422
Gabriel's patch is the right way to fix this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user joshelser closed the pull request at:
https://github.com/apache/phoenix/pull/144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user joshelser opened a pull request:
https://github.com/apache/phoenix/pull/144
PHOENIX-2484 Disable logback for all but tephra code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joshelser/phoenix PHOENIX-2484
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/141#discussion_r46732160
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/FormatToKeyValueMapper.java
---
@@ -0,0 +1,254 @@
+/*
+ * Licensed
201 - 256 of 256 matches
Mail list logo
