Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/239
Patch looks very good, @akshita-malhotra. What's the advantage, @lhofhansl,
of forcing users to create the snapshot themselves before starting the job?
Wouldn't it be simpler for the snapshot
Github user akshita-malhotra commented on the issue:
https://github.com/apache/phoenix/pull/239
@JamesRTaylor Thanks a lot for the review. I have made the suggested
changes and uploaded the updated patch on the jira.
Regarding creating snapshot to generalize the use of snapshots
Github user JamesRTaylor commented on the issue:
https://github.com/apache/phoenix/pull/239
Thanks for the revision, @akshita-malhotra. It's looking very good. I made
some comments inline.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user akshita-malhotra commented on the issue:
https://github.com/apache/phoenix/pull/239
@JamesRTaylor
- Changed ParallelScanGrouper classes as per the review
- Changes to BaseTest were to avoid the following error:
"Restore directory cannot be a sub directory of
