[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2016-02-03 Thread jmahonin
Github user jmahonin closed the pull request at: https://github.com/apache/phoenix/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is en

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-04-05 Thread mravi
Github user mravi commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-89733786 @jmahonin Thanks for the nice work !! I have pushed these changes to 4.X and master branch. --- If your project is set up for it, you can reply to this email and have you

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-04-02 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-89020951 @mravi Sounds good. FYI, I was able to run the PhoenixRDDTests in IntelliJ on Linux with no modifications using the 'ScalaTest' configuration. In summary, I thin

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-04-02 Thread mravi
Github user mravi commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88928590 @jmahonin Let's have the changes for registering as a data source in a separate JIRA. The changes to this commit LGTM. --- If your project is set up for it, you can reply

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-04-01 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88569122 I was able to spend a bit more time on the RelationProvider work. The DDL for custom providers doesn't work through the 'sql()' method on SparkSQLContext, perhaps by des

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread dacort
Github user dacort commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88298339 @jmahonin Thanks for this PR! You're good to go with respect to copyrights. Thanks for putting those in the appropriate place. --- If your project is set up for

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88285575 Can confirm the memory settings needed adjustment on 7u76 on Linux. Special thanks to @robdaemon who had an excellent library to work with, and a pre-emptive tha

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread dacort
Github user dacort commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88267935 Consider me poked! Will take a look at this and follow up tomorrow by the latest. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread robdaemon
Github user robdaemon commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88267669 So happy to see this go in. I'll push on my former colleagues at Simply Measured about the copyrights!! --- If your project is set up for it, you can reply to this ema

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread apurtell
Github user apurtell commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88248990 I'm not a Spark expert @JamesRTaylor . I skimmed the latest. Allowing builds with JDK 1.7 would have been the big change I'd have recommended, and it's already been don

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88226194 JDK 1.7 and the ProductRDDFunctions package location have been fixed up. I tried to make some headway on getting the unit tests to run in the IDE. If you're seei

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88179901 @mravi Great. I can get 1 and 2 taken care of today. Are new commits on this PR fine, or would you prefer a new PR with a rebased commit? --- If your project i

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread mravi
Github user mravi commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88178852 @jmahonin I can join forces with you on the Good to haves --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread jmahonin
Github user jmahonin commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88176830 Thanks for the feedback @mravi , point comments below: 1: Right, I'll try get that sorted out. The original phoenix-spark library would not work with 1.7 for som

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-31 Thread mravi
Github user mravi commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-88157968 Nice work @jmahonin . Couple of minor changes 1. JDK version in the pom.xml is 1.8. You would need to downgrade to 1.7 2. For the ProductRDDFunctions.scala fi

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-27 Thread JamesRTaylor
Github user JamesRTaylor commented on the pull request: https://github.com/apache/phoenix/pull/59#issuecomment-87145157 Good stuff, @jmahonin. Thanks so much for the contribution. Any Spark experts out there that can review this? @apurtell ? --- If your project is set up for it, you

[GitHub] phoenix pull request: PHOENIX-1071 Add phoenix-spark for Spark int...

2015-03-27 Thread jmahonin
GitHub user jmahonin opened a pull request: https://github.com/apache/phoenix/pull/59 PHOENIX-1071 Add phoenix-spark for Spark integration This adds a new module which can be used to load and save Phoenix tables through the Spark 1.3.0+ DataFrame and RDD APIs. It's based or