[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

2016-10-06 Thread lomoree
Github user lomoree closed the pull request at: https://github.com/apache/phoenix/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

2016-10-06 Thread lomoree
Github user lomoree commented on a diff in the pull request: https://github.com/apache/phoenix/pull/214#discussion_r82305850 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl()

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

2016-10-06 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/phoenix/pull/214#discussion_r82285685 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/compile/QueryCompilerTest.java --- @@ -1453,7 +1453,7 @@ public void testInvalidPrimaryKeyDecl()

[GitHub] phoenix pull request #214: PHOENIX-3298 Single column primary key may not be...

2016-10-03 Thread lomoree
GitHub user lomoree opened a pull request: https://github.com/apache/phoenix/pull/214 PHOENIX-3298 Single column primary key may not be null Note: This patch will not immediately resolve the testInvalidPrimaryKeyDecl() test case due to another issue, PHOENIX-3345. However, they