Github user lomoree closed the pull request at:
https://github.com/apache/phoenix/pull/215
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r83024234
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1120,8 +1120,11 @@ public static SQLException
unwrapSqlException(S
Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82912355
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1115,4 +1115,15 @@ public static Object convertSqlLiteral(SqlL
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82879380
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/calcite/CalciteUtils.java ---
@@ -1115,4 +1115,15 @@ public static Object convertSqlLiteral(SqlLit
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82853555
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java
---
@@ -161,6 +162,29 @@ public Object apply(
}));
Github user lomoree commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82688259
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java
---
@@ -161,6 +162,29 @@ public Object apply(
}));
Github user maryannxue commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/215#discussion_r82686793
--- Diff:
phoenix-core/src/main/java/org/apache/calcite/jdbc/PhoenixCalciteFactory.java
---
@@ -161,6 +162,29 @@ public Object apply(
})
GitHub user lomoree opened a pull request:
https://github.com/apache/phoenix/pull/215
PHOENIX-3345 SQLException code's not propagating as expected
-- Primarily impacts unit tests in QueryCompilerTest.java
You can merge this pull request into a Git repository by running:
$ git p
