[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118314856 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionContext.java --- @@ -0,0 +1,15 @@ +package org.apache.phoenix.iterate; +

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118314328 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java --- @@ -192,6 +196,18 @@ public static void

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118313746 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java --- @@ -185,7 +184,7 @@ private QueryPlan

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118313368 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableMRParallelScanGrouper.java --- @@ -0,0 +1,99 @@ +package

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118312938 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/DefaultParallelScanGrouper.java --- @@ -17,46 +17,79 @@ */ package

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118311801 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java --- @@ -63,6 +67,66 @@ public static void

[GitHub] phoenix pull request #239: PHOENIX-3744: Support snapshot scanners for MR-ba...

2017-05-24 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r118310359 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ScanningResultIterator.java --- @@ -38,10 +38,12 @@ public class

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116564003 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java --- @@ -592,7 +592,7 @@ private static String

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116562713 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/NonAggregateROUtil.java --- @@ -0,0 +1,355 @@ +package org.apache.phoenix.util; +

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116562096 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/MetricType.java --- @@ -25,6 +25,7 @@ QUERY_TIME("Query times"),

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116561507 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/PhoenixInputFormat.java --- @@ -185,7 +188,10 @@ private QueryPlan

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-05-15 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/239#discussion_r116560730 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java --- @@ -496,6 +496,17 @@ public

[GitHub] phoenix pull request #239: Phoenix-3744: Support snapshot scanners for MR-ba...

2017-04-24 Thread akshita-malhotra
GitHub user akshita-malhotra opened a pull request: https://github.com/apache/phoenix/pull/239 Phoenix-3744: Support snapshot scanners for MR-based queries - Parallel Scan grouper is extended to differentiate the functionality for getting region boundaries - Added