[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700072#comment-14700072 ] James Taylor commented on PHOENIX-2177: --- We need to call Admin.modifyTable() if

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700108#comment-14700108 ] Eli Levine commented on PHOENIX-2177: - Makes sense, thanks. Adding a column to the

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14700071#comment-14700071 ] Eli Levine commented on PHOENIX-2177: - Curious, what's the reason to call

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694704#comment-14694704 ] James Taylor commented on PHOENIX-2177: --- Good catch, [~samarthjain]. I think we

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695832#comment-14695832 ] Samarth Jain commented on PHOENIX-2177: --- Thanks for the review, [~jamestaylor]. I

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695801#comment-14695801 ] James Taylor commented on PHOENIX-2177: --- +1 with one minor nit to fix on commit.

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14695726#comment-14695726 ] James Taylor commented on PHOENIX-2177: --- As far as a test, take a look at the

[jira] [Commented] (PHOENIX-2177) Adding a column to the view shouldn't call admin.modifyTable() for the base table.

[ https://issues.apache.org/jira/browse/PHOENIX-2177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14694540#comment-14694540 ] Eli Levine commented on PHOENIX-2177: - Looks good, [~samarthjain]. Thanks for the