[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194547#comment-15194547 ] Hudson commented on PHOENIX-2756: - FAILURE: Integrated in Phoenix-master #1173 (See

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-11 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191648#comment-15191648 ] churro morales commented on PHOENIX-2756: - Sure thing was thinking about that but didn't want to

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-11 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191645#comment-15191645 ] churro morales commented on PHOENIX-2756: - Sure thing was thinking about that but didn't want to

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-11 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191636#comment-15191636 ] churro morales commented on PHOENIX-2756: - Sure thing was thinking about that but didn't want to

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-11 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191619#comment-15191619 ] James Taylor commented on PHOENIX-2756: --- Thanks for the contribution, [~churromorales]. There's

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-11 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191522#comment-15191522 ] churro morales commented on PHOENIX-2756: - ~jamestaylor ran tests, all passed locally >

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-10 Thread churro morales (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190476#comment-15190476 ] churro morales commented on PHOENIX-2756: - [~jamestaylor] I ran tests for the phoenix-core

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190181#comment-15190181 ] James Taylor commented on PHOENIX-2756: --- Me too. [~churromorales] - did you run all of our

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-10 Thread Jesse Yates (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190177#comment-15190177 ] Jesse Yates commented on PHOENIX-2756: -- Seems ok to me. Nice change - love all the code going away.

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190174#comment-15190174 ] James Taylor commented on PHOENIX-2756: --- [~jesse_yates] - do you see any issues with this change?

[jira] [Commented] (PHOENIX-2756) FilteredKeyValueScanner should not implement KeyValueScanner

2016-03-10 Thread Thomas D'Silva (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190165#comment-15190165 ] Thomas D'Silva commented on PHOENIX-2756: - Seems like it should be fine. [~jamestaylor] can you