[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354711#comment-15354711 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~elserj] Thanks! > Phoenix client asks users to

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354600#comment-15354600 ] Josh Elser commented on PHOENIX-2931: - Two more nits: {code} -print "Zookeeper not specified.

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353885#comment-15353885 ] James Taylor commented on PHOENIX-2931: --- Would you mind committing this, [~elserj] if you're good

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348934#comment-15348934 ] Hadoop QA commented on PHOENIX-2931: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348822#comment-15348822 ] Alicia Ying Shu commented on PHOENIX-2931: -- Thanks. Uploaded revised patch > Phoenix client

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348671#comment-15348671 ] Josh Elser commented on PHOENIX-2931: - bq. It is for psql command line that users need to have at

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348660#comment-15348660 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~elserj] Thanks for the review. No need to use $.

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348393#comment-15348393 ] Josh Elser commented on PHOENIX-2931: - {noformat} -if len(sys.argv) < 2: -print "Zookeeper not

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348360#comment-15348360 ] Josh Elser commented on PHOENIX-2931: - Yeah, i'll take a look this morning, [~enis]. Thanks for the

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347529#comment-15347529 ] Enis Soztutar commented on PHOENIX-2931: +1. [~elserj] you also want to take a look? > Phoenix

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347404#comment-15347404 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~enis] Thanks for the review! Uploaded a patch >

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346748#comment-15346748 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~enis] Go through the parsing again is a sanity

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345161#comment-15345161 ] Enis Soztutar commented on PHOENIX-2931: Thanks Alicia, this is looking better. bq. This part

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345137#comment-15345137 ] Hadoop QA commented on PHOENIX-2931: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344986#comment-15344986 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~enis] Thanks for the review. I have made the

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343134#comment-15343134 ] Alicia Ying Shu commented on PHOENIX-2931: -- No change in

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343095#comment-15343095 ] Alicia Ying Shu commented on PHOENIX-2931: -- >We already check whether it is a file or not

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343086#comment-15343086 ] Alicia Ying Shu commented on PHOENIX-2931: -- We need system tests for this. I do not think we

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342839#comment-15342839 ] Ankit Singhal commented on PHOENIX-2931: By Today EOD most probably. > Phoenix client asks

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342834#comment-15342834 ] Enis Soztutar commented on PHOENIX-2931: bq. The intention of this print statement was when

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342838#comment-15342838 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~ankit.singhal] Yes. If we could get it in. When

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342833#comment-15342833 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~enis] Thanks for the comments. See above. >

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342819#comment-15342819 ] Ankit Singhal commented on PHOENIX-2931: Hi [~ayingshu], do you need this in 4.8? > Phoenix

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342810#comment-15342810 ] Alicia Ying Shu commented on PHOENIX-2931: -- >Please remove System.out.println() statements. The

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342729#comment-15342729 ] Enis Soztutar commented on PHOENIX-2931: Please remove System.out.println() statements. Why

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342698#comment-15342698 ] Hadoop QA commented on PHOENIX-2931: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338874#comment-15338874 ] Hadoop QA commented on PHOENIX-2931: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15334811#comment-15334811 ] Alicia Ying Shu commented on PHOENIX-2931: -- There are 2 options for the solution. One is

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311232#comment-15311232 ] Alicia Ying Shu commented on PHOENIX-2931: -- I have revised the patch to get defaults from

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309004#comment-15309004 ] Enis Soztutar commented on PHOENIX-2931: Thinking about this, there is no surefire way to check

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308344#comment-15308344 ] Josh Elser commented on PHOENIX-2931: - You're completely right. SGTM! > Phoenix client asks users

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305664#comment-15305664 ] Alicia Ying Shu commented on PHOENIX-2931: -- >If the user doesn't provide -connection, we could

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305114#comment-15305114 ] Sergey Soldatov commented on PHOENIX-2931: -- +1 > Phoenix client asks users to provide configs

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15305113#comment-15305113 ] Josh Elser commented on PHOENIX-2931: - bq. But be aware that currently there is no requirement to

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15302804#comment-15302804 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~jamestaylor] [~elserj] [~sergey.soldatov] Thanks

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297493#comment-15297493 ] James Taylor commented on PHOENIX-2931: --- That seems more clear if we don't rely on position. Maybe

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297460#comment-15297460 ] Josh Elser commented on PHOENIX-2931: - As an initial observation, the scripts struggle with finding

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297433#comment-15297433 ] Alicia Ying Shu commented on PHOENIX-2931: -- What if users use ".txt", ".doc", etc. ? > Phoenix

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297428#comment-15297428 ] Sergey Soldatov commented on PHOENIX-2931: -- [~jamestaylor] Actually it's only sounds

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297419#comment-15297419 ] Alicia Ying Shu commented on PHOENIX-2931: -- What about if users use other extensions such as

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297386#comment-15297386 ] James Taylor commented on PHOENIX-2931: --- Sounds complicated and hard to maintain. Weird things may

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297338#comment-15297338 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~jamestaylor] Discussed this offline with

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294691#comment-15294691 ] Sergey Soldatov commented on PHOENIX-2931: -- Actually it's not. {{/hbase-unsecure}} is set by

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294687#comment-15294687 ] Alicia Ying Shu commented on PHOENIX-2931: -- We can use zookeeper.znode.parent property. If it

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294684#comment-15294684 ] Alicia Ying Shu commented on PHOENIX-2931: -- We can use ".sql" extension to determine for

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294597#comment-15294597 ] James Taylor commented on PHOENIX-2931: --- Agree with [~sergey.soldatov]. I think the code should

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294586#comment-15294586 ] Sergey Soldatov commented on PHOENIX-2931: -- [~aliciashu] instead of hardcoding

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294544#comment-15294544 ] Alicia Ying Shu commented on PHOENIX-2931: -- Uploaded a patch. > Phoenix client asks users to

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294540#comment-15294540 ] Alicia Ying Shu commented on PHOENIX-2931: -- [~jamestaylor] Please provide your opinion on this.

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294413#comment-15294413 ] Alicia Ying Shu commented on PHOENIX-2931: -- Users should set env HBASE_CONF_DIR, where

[jira] [Commented] (PHOENIX-2931) Phoenix client asks users to provide configs in cli that are present on the machine in hbase conf

[ https://issues.apache.org/jira/browse/PHOENIX-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294410#comment-15294410 ] Alicia Ying Shu commented on PHOENIX-2931: -- Users can specify: >sqlline.py default Then