[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-13 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662792#comment-15662792 ] chenglei commented on PHOENIX-3452: --- [~jamestaylor], yes, I will upload my first patch for

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-13 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662789#comment-15662789 ] James Taylor commented on PHOENIX-3452: --- Ok, thanks! Do you have a patch almost ready for

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-13 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662633#comment-15662633 ] chenglei commented on PHOENIX-3452: --- [~jamestaylor],I uploaded a new patch: PHOENIX-3452_v3.patch,

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-12 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660769#comment-15660769 ] chenglei commented on PHOENIX-3452: --- yes,my assert in QueryCompilerTest had already conside this

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-12 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15660036#comment-15660036 ] James Taylor commented on PHOENIX-3452: --- Looking at this a bit more, I think your patch is good,

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-10 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655790#comment-15655790 ] chenglei commented on PHOENIX-3452: --- ok, [~jamestaylor],I will add tests soon. > Secondary index and

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-10 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15655754#comment-15655754 ] James Taylor commented on PHOENIX-3452: --- With the patch for PHOENIX-3469 applied, can you add the

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-09 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15653112#comment-15653112 ] chenglei commented on PHOENIX-3452: --- [~jamestaylor], when I wrote my IT tests,I found another new

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-09 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15651169#comment-15651169 ] James Taylor commented on PHOENIX-3452: --- Yes, that's correct. > Secondary index and query using

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-09 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650438#comment-15650438 ] chenglei commented on PHOENIX-3452: --- Ok,I will try some IT tests > Secondary index and query using

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-09 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650176#comment-15650176 ] James Taylor commented on PHOENIX-3452: --- Thanks, [~comnetwork]. Try these tests as end-to-end

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-08 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650093#comment-15650093 ] chenglei commented on PHOENIX-3452: --- [~jamestaylor], I updated my patch,enhanced my test cases

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-08 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649922#comment-15649922 ] chenglei commented on PHOENIX-3452: --- [~jamestaylor],ok ,I will add more tests. > Secondary index and

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-08 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649908#comment-15649908 ] James Taylor commented on PHOENIX-3452: --- NULLS FIRST/LAST can matter if there's an ORDER BY. Try

[jira] [Commented] (PHOENIX-3452) Secondary index and query using distinct: ORDER BY doesn't work correctly

2016-11-08 Thread chenglei (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15649794#comment-15649794 ] chenglei commented on PHOENIX-3452: --- I think the problem is cause by the GroupByCompiler, when