[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-02 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235240#comment-16235240 ] James Taylor commented on PHOENIX-4343: --- +1 > In CREATE TABLE only allow setting guide post width

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235220#comment-16235220 ] James Taylor commented on PHOENIX-4343: --- +1 with one nit. How about {{tableType !=

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235158#comment-16235158 ] Samarth Jain commented on PHOENIX-4343: --- With PHOENIX-4332 indexes now inherit the guide post

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234941#comment-16234941 ] James Taylor commented on PHOENIX-4343: --- Patch looks fine, but if we go the route of propagating

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234774#comment-16234774 ] Samarth Jain commented on PHOENIX-4343: --- [~jamestaylor], please review. > In CREATE TABLE only