[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488799#comment-16488799
]
Rajeshbabu Chintaguntla commented on PHOENIX-4671:
--
Pushed this to 5.x branch.
> Fix
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16423667#comment-16423667
]
Hudson commented on PHOENIX-4671:
-
FAILURE: Integrated in Jenkins build PreCommit-PHOENIX-Build #1822
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421088#comment-16421088
]
Lars Hofhansl commented on PHOENIX-4671:
Thanks [~pboado]. I close this issue then.
Oh wait.
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421041#comment-16421041
]
Pedro Boado commented on PHOENIX-4671:
--
4.x-cdh5.11 is the "main" cdh branch , the other three
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419815#comment-16419815
]
Lars Hofhansl commented on PHOENIX-4671:
Which cdh* branches are relevant?!
> Fix minor size
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419814#comment-16419814
]
Lars Hofhansl commented on PHOENIX-4671:
Committed to master, 4.x-HBase-\{1.3|1.2|1.1|0.98}
>
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419806#comment-16419806
]
Lars Hofhansl commented on PHOENIX-4671:
Are there really 10 4.x branches now (including
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418159#comment-16418159
]
James Taylor commented on PHOENIX-4671:
---
+1. Thanks for the test!
> Fix minor size accounting bug
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418153#comment-16418153
]
Lars Hofhansl commented on PHOENIX-4671:
OK... Here's a test. :)
> Fix minor size accounting
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417921#comment-16417921
]
Lars Hofhansl commented on PHOENIX-4671:
Lemme file a separate issue for the test then. A test
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414052#comment-16414052
]
James Taylor commented on PHOENIX-4671:
---
We’ve gotten flack in the past for lack of testing so
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413401#comment-16413401
]
Lars Hofhansl commented on PHOENIX-4671:
In this case, yeah, it adds runtime and does not guard
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413354#comment-16413354
]
James Taylor commented on PHOENIX-4671:
---
We typically add a unit test that would fail without the
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413201#comment-16413201
]
Lars Hofhansl commented on PHOENIX-4671:
Hmm... That's a pretty clear cut omission of resetting
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413061#comment-16413061
]
James Taylor commented on PHOENIX-4671:
---
Thanks for the patch. How about a unit test?
> Fix minor
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412889#comment-16412889
]
James Taylor commented on PHOENIX-4671:
---
Yes, any time sequences are used, it executes client
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412815#comment-16412815
]
Lars Hofhansl commented on PHOENIX-4671:
By the, I also noticed that the UPSERT is executed
[
https://issues.apache.org/jira/browse/PHOENIX-4671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412813#comment-16412813
]
Lars Hofhansl commented on PHOENIX-4671:
That's it.
> Fix minor size accounting bug for
18 matches
Mail list logo
