Re: Question on aggregate function

2016-05-10 Thread Swapna Swapna
That helps. Thank You James. I'm in the right direction not trying further to achieve non-standard multi arg version of an aggregate function :):) And as a next step, I will push my existing (single col) aggregate function and will keep you posted. Regards Swapna On Tue, May 10, 2016 at 10:57 A

Re: Question on aggregate function

2016-05-10 Thread James Taylor
Yes, the way to optimize it is to not represent data in column qualifiers, but as the value of a column instead (perhaps in the primary key constraint) and to do the group by query I mentioned before. Otherwise, you can do separate aggregations as you've shown as it'd perform the same as trying to

Re: Question on aggregate function

2016-05-10 Thread Swapna Swapna
Hi James, thanks for your response. In the below example, us & uk are column qualifiers. * rowkeyc:usc:uk* 20161001 3 4 20161002 1 2 This is how my query looks like: select sum1(us) as US, sum1(uk) as UK from table; whic

Re: Question on aggregate function

2016-05-10 Thread James Taylor
We don't have aggregate functions with multiple arguments, so I can't provide any pointers. It's unclear what semantics you're trying to achieve with the multiple arguments. Can you give a concrete example? Based on your other example, you'd want to do a GROUP BY, like this: select sum(col) from t

Re: Question on aggregate function

2016-05-09 Thread Swapna Swapna
Hi James/Team, myaggFunc(col1,col2) I tried implementing this new aggregate function with multiple (2, to start with) columns , expressions as arguments. And its giving me this error: index (1) must be less than size (1) My function definition: @FunctionParseNode.BuiltInFunction(name = mya

Re: Question on aggregate function

2016-05-04 Thread Swapna Swapna
Hi James, the new ones are in similar lines to existing aggregate functions: I misinterpreted this definition, thanks for clarifying : *A reference to a column is also an expression* Regards Swapna On Tue, May 3, 2016 at 11:39 PM, James Taylor wrote: > Hi Swapna, > All our aggregate functions

Re: Question on aggregate function

2016-05-04 Thread Swapna Swapna
Sure James. Will take a look on the process. Regards Swapna On Tue, May 3, 2016 at 11:39 PM, James Taylor wrote: > Hi Swapna, > All our aggregate functions allow expressions as arguments and it wouldn't > make sense to have these new ones be different. A reference to a column is > also an expre

Re: Question on aggregate function

2016-05-03 Thread James Taylor
Hi Swapna, All our aggregate functions allow expressions as arguments and it wouldn't make sense to have these new ones be different. A reference to a column is also an expression. It doesn't change the HBase data model being sparse. I think the next step should be for you to submit a patch that t

Re: Question on aggregate function

2016-05-03 Thread Swapna Swapna
Hi James, Thanks for your swift response. I wouldn't be able to use the expression in the below query rather I would have to provide the columns (as arguments) which I'm interested in to perform the aggregation on respective provided columns. myaggFunc(col1,col2) the reason being, the hbase dat

Re: Question on aggregate function

2016-05-03 Thread James Taylor
Hi Swapna, The return type is typically derived from looking at the return types of each of the input arguments and choosing what'll work without losing precision. For example, take a look at this loop in ExpressionCompiler that determines this for expressions that are added together: new

Re: Question on aggregate function

2016-05-03 Thread Swapna Swapna
Sure, Hbase data that I have is: rowkeyus uk 20161001 34 20161002 12 select myaggFunc(us) from table :// this is returning output as : 4 select myaggFunc(uk) from table :// this is returning output as : 6 In similar to

Re: Question on aggregate function

2016-05-03 Thread James Taylor
Removing user list (please don't cross post) Can you give us a full example of the query you have in mind? Thanks, James On Tue, May 3, 2016 at 11:14 AM, Swapna Swapna wrote: > Hi, > > I'm trying to implement aggregate function on multiple columns (as an > arguments) like: > > myaggFunc(col1,c

Question on aggregate function

2016-05-03 Thread Swapna Swapna
Hi, I'm trying to implement aggregate function on multiple columns (as an arguments) like: myaggFunc(col1,col2) And I would want to return the results by each column after applying aggregate operation. The output would be something like: col1, count ( aggregate of all records for col1) col2, c