[jira] [Commented] (PHOENIX-4366) Rebuilding a local index fails sometimes

2018-04-04 Thread JeongMin Ju (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426492#comment-16426492
 ] 

JeongMin Ju commented on PHOENIX-4366:
--

I have experienced similar errors.

I have an error when copying data using the Upsert ... Select statement to a 
table with the same schema.

The cause of the error was the encodingScheme variable in the 
BaseScannerRegionObserver class.

This variable is [initialized in the preScannerOpen of the 
BaseScannerRegionObserver|https://github.com/apache/phoenix/blob/v4.10.0-HBase-1.2/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java#L207-L208]
 and it is [used in the postScannerOpen method of the 
UngroupedAggregateRegionObserver|https://github.com/apache/phoenix/blob/v4.10.0-HBase-1.2/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java#L493]
 class. In this process, when another query comes in, the value can be changed.

[The encodingScheme and useNewValueColumnQualifier variables in the 
BaseScannerRegionObserver 
class|https://github.com/apache/phoenix/blob/v4.10.0-HBase-1.2/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java#L133-L134]
 should not be created as instance variables, but should be used to get the 
values at the point of need.

I used version 4.11 but it seems to be in error after 4.10.

The following is an error in version 4.11.
{code:java}
Error: org.apache.phoenix.exception.PhoenixIOException: 
org.apache.hadoop.hbase.DoNotRetryIOException: 
TEST:LOGINLOG_COMPOSITE_ROWKEY,,1522711856236.d9400f93512706cf8243762bb7ff9db1.:
 null
  at org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:92)
  at org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:58)
  at 
org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.overrideDelegate(BaseScannerRegionObserver.java:240)
  at 
org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.nextRaw(BaseScannerRegionObserver.java:266)
  at 
org.apache.hadoop.hbase.regionserver.RSRpcServices.scan(RSRpcServices.java:2561)
  at 
org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:33648)
  at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2183)
  at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:112)
  at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:185)
  at org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:165)
Caused by: java.lang.UnsupportedOperationException
  at 
org.apache.phoenix.schema.PTable$QualifierEncodingScheme$1.decode(PTable.java:247)
  at 
org.apache.phoenix.schema.tuple.EncodedColumnQualiferCellsList.add(EncodedColumnQualiferCellsList.java:141)
  at 
org.apache.phoenix.schema.tuple.EncodedColumnQualiferCellsList.add(EncodedColumnQualiferCellsList.java:56)
  at 
org.apache.hadoop.hbase.regionserver.StoreScanner.next(StoreScanner.java:560)
  at 
org.apache.hadoop.hbase.regionserver.KeyValueHeap.next(KeyValueHeap.java:147)
  at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.populateResult(HRegion.java:5736)
  at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextInternal(HRegion.java:5895)
  at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:5673)
  at 
org.apache.hadoop.hbase.regionserver.HRegion$RegionScannerImpl.nextRaw(HRegion.java:5659)
  at 
org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver.doPostScannerOpen(UngroupedAggregateRegionObserver.java:492)
  at 
org.apache.phoenix.coprocessor.BaseScannerRegionObserver$RegionScannerHolder.overrideDelegate(BaseScannerRegionObserver.java:221)
  ... 7 more (state=08000,code=101)
{code}

 

 

> Rebuilding a local index fails sometimes
> 
>
> Key: PHOENIX-4366
> URL: https://issues.apache.org/jira/browse/PHOENIX-4366
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.12.0
>Reporter: Marcin Januszkiewicz
>Priority: Major
>
> We have a table created in 4.12 with the new column encoding scheme and with 
> several local indexes. Sometimes when we issue an ALTER INDEX ... REBUILD 
> command, it fails with the following exception:
> {noformat}
> Error: org.apache.phoenix.exception.PhoenixIOException: 
> org.apache.hadoop.hbase.DoNotRetryIOException: 
> TRACES,\x01BY01O90A6-$599a349e,1509979836322.3f
> 30c9d449ed6c60a1cda6898f766bd0.: null 
>   
>   
> at 
> org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:96)  
> 

[jira] [Commented] (PHOENIX-4668) Remove unnecessary table descriptor modification for SPLIT_POLICY column

2018-04-04 Thread Ethan Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426272#comment-16426272
 ] 

Ethan Wang commented on PHOENIX-4668:
-

As HBASE-12570 has been resolved. +1 for this patch removing work around.

> Remove unnecessary table descriptor modification for SPLIT_POLICY column
> 
>
> Key: PHOENIX-4668
> URL: https://issues.apache.org/jira/browse/PHOENIX-4668
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Chinmay Kulkarni
>Assignee: Chinmay Kulkarni
>Priority: Major
> Attachments: PHOENIX-4668.patch
>
>
> Inside _ConnectionQueryServicesImpl.ensureTableCreated()_, we modify the 
> table descriptor with
> newDesc.setValue(HTableDescriptor.SPLIT_POLICY, 
> MetaDataSplitPolicy.class.getName()), however we already have this mentioned 
> in the create statement DDL for system tables, so we can remove this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PHOENIX-4616) Move join query optimization out from QueryCompiler into QueryOptimizer

2018-04-04 Thread Maryann Xue (JIRA)

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maryann Xue updated PHOENIX-4616:
-
Fix Version/s: 5.0.0
   4.14.0

> Move join query optimization out from QueryCompiler into QueryOptimizer
> ---
>
> Key: PHOENIX-4616
> URL: https://issues.apache.org/jira/browse/PHOENIX-4616
> Project: Phoenix
>  Issue Type: Improvement
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>Priority: Major
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4616.patch
>
>
> Currently we do optimization for join queries inside QueryCompiler, which 
> makes the APIs and code logic confusing, so we need to move join optimization 
> logic into QueryOptimizer.
>  Similarly, but probably with a different approach, we need to optimize UNION 
> ALL queries and derived table sub-queries in QueryOptimizer.optimize().
> Please also refer to this comment:
> https://issues.apache.org/jira/browse/PHOENIX-4585?focusedCommentId=16367616=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16367616



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (PHOENIX-4617) Make sure QueryPlan.getSourceRefs() get all data table refs for join queries and sub-queries

2018-04-04 Thread Maryann Xue (JIRA)

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maryann Xue resolved PHOENIX-4617.
--
   Resolution: Fixed
Fix Version/s: 5.0.0
   4.14.0

Fixed by PHOENIX-4616.

> Make sure QueryPlan.getSourceRefs() get all data table refs for join queries 
> and sub-queries
> 
>
> Key: PHOENIX-4617
> URL: https://issues.apache.org/jira/browse/PHOENIX-4617
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Maryann Xue
>Assignee: Maryann Xue
>Priority: Major
> Fix For: 4.14.0, 5.0.0
>
>
> Please see PHOENIX-4616, and refer to 
> https://issues.apache.org/jira/browse/PHOENIX-4585?focusedCommentId=16367616=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16367616.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

2018-04-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426101#comment-16426101
 ] 

Hudson commented on PHOENIX-4682:
-

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-0.98 #1847 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-0.98/1847/])
PHOENIX-4682 UngroupedAggregateRegionObserver preCompactScannerOpen hook 
(vincentpoon: rev 268e744d69b3ab35456779636f9e1a446e1bd662)
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java


> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw 
> exceptions
> ---
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.13.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch, 
> PHOENIX-4682.v2.0.98.patch, PHOENIX-4682.v2.master.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual 
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG).  We should ignore these 
> Exceptions instead of throwing them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (PHOENIX-4677) Commons-cli needs to be listed as dependency.

2018-04-04 Thread Vincent Poon (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425986#comment-16425986
 ] 

Vincent Poon commented on PHOENIX-4677:
---

[~elserj] I see the commit for this in 5.x-HBase-2.0 branch changed the pom.xml 
hbase.version from 2.0.0-beta-2 to 2.0.0 , was that intended?

> Commons-cli needs to be listed as dependency.
> -
>
> Key: PHOENIX-4677
> URL: https://issues.apache.org/jira/browse/PHOENIX-4677
> Project: Phoenix
>  Issue Type: Bug
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Blocker
> Fix For: 4.14.0, 5.0.0
>
> Attachments: PHOENIX-4677.001.patch
>
>
> After HBase upgraded to hbase-thirdparty 2.1.0 via HBASE-20223, it shaded its 
> dependency on commons-cli. Phoenix has apparently be transitively using this 
> dependency without explicitly declaring it.
> We need to own the dependencies that we require.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

2018-04-04 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425971#comment-16425971
 ] 

Hudson commented on PHOENIX-4682:
-

FAILURE: Integrated in Jenkins build Phoenix-4.x-HBase-1.3 #80 (See 
[https://builds.apache.org/job/Phoenix-4.x-HBase-1.3/80/])
PHOENIX-4682 UngroupedAggregateRegionObserver preCompactScannerOpen hook 
(vincentpoon: rev d9a38fb958e60631793af5a3031140c13c671533)
* (edit) 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
* (edit) 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexIT.java


> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw 
> exceptions
> ---
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.13.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch, 
> PHOENIX-4682.v2.0.98.patch, PHOENIX-4682.v2.master.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual 
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG).  We should ignore these 
> Exceptions instead of throwing them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

2018-04-04 Thread Geoffrey Jacoby (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425954#comment-16425954
 ] 

Geoffrey Jacoby commented on PHOENIX-4682:
--

+1, thanks [~vincentpoon]

> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw 
> exceptions
> ---
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.13.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch, 
> PHOENIX-4682.v2.0.98.patch, PHOENIX-4682.v2.master.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual 
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG).  We should ignore these 
> Exceptions instead of throwing them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (PHOENIX-4682) UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw exceptions

2018-04-04 Thread Vincent Poon (JIRA)

 [ 
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vincent Poon updated PHOENIX-4682:
--
Attachment: PHOENIX-4682.v2.master.patch

> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw 
> exceptions
> ---
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 4.13.0
>Reporter: Vincent Poon
>Assignee: Vincent Poon
>Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch, 
> PHOENIX-4682.v2.0.98.patch, PHOENIX-4682.v2.master.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual 
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG).  We should ignore these 
> Exceptions instead of throwing them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)