[jira] [Commented] (OMID-239) OMID TLS support

2023-02-28 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/OMID-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694900#comment-17694900
 ] 

ASF GitHub Bot commented on OMID-239:
-

stoty commented on code in PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#discussion_r1121269704


##
common/src/main/java/org/apache/omid/tls/X509Util.java:
##
@@ -0,0 +1,286 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.omid.tls;
+
+import io.netty.handler.ssl.SslContext;
+import io.netty.handler.ssl.SslContextBuilder;
+import org.apache.phoenix.thirdparty.com.google.common.collect.ObjectArrays;
+import org.apache.zookeeper.common.X509Exception;
+import org.apache.zookeeper.common.X509Exception.KeyManagerException;
+import org.apache.zookeeper.common.X509Exception.SSLContextException;
+import org.apache.zookeeper.common.X509Exception.TrustManagerException;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.net.ssl.*;
+import java.io.File;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.file.Files;
+import java.security.GeneralSecurityException;
+import java.security.KeyStore;
+import java.security.Security;
+import java.security.cert.PKIXBuilderParameters;
+import java.security.cert.X509CertSelector;
+import java.util.Arrays;
+import java.util.Objects;
+
+
+/**
+ * Utility code for X509 handling Default cipher suites: Performance testing 
done by Facebook
+ * engineers shows that on Intel x86_64 machines, Java9 performs better with 
GCM and Java8 performs
+ * better with CBC, so these seem like reasonable defaults.
+ * 
+ * This file has been copied from the Apache ZooKeeper project.
+ * @see https://github.com/apache/zookeeper/blob/c74658d398cdc1d207aa296cb6e20de00faec03e/zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java;>Base
+ *  revision
+ */

Review Comment:
   Is this the file the same as the ZK file ?
   I it includes HBase modifications, then add a note about that here.





> OMID TLS support
> 
>
> Key: OMID-239
> URL: https://issues.apache.org/jira/browse/OMID-239
> Project: Phoenix Omid
>  Issue Type: Task
>Reporter: Richárd Antal
>Assignee: Richárd Antal
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Assigned] (PHOENIX-6888) Fixing TTL and Max Lookback Issues for Phoenix Tables

2023-02-28 Thread Kadir Ozdemir (Jira) 


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kadir Ozdemir reassigned PHOENIX-6888:
--

Assignee: Kadir Ozdemir

> Fixing TTL and Max Lookback Issues for Phoenix Tables
> -
>
> Key: PHOENIX-6888
> URL: https://issues.apache.org/jira/browse/PHOENIX-6888
> Project: Phoenix
>  Issue Type: Bug
>Affects Versions: 5.1.3
>Reporter: Kadir Ozdemir
>Assignee: Kadir Ozdemir
>Priority: Major
>
> In HBase, the unit of data is a cell and data retention rules are executed at 
> the cell level. These rules are defined at the column family level. Phoenix 
> leverages the data retention features of HBase and exposes them to its users 
> to provide its TTL feature at the table level. However, these rules (since 
> they are defined at the cell level instead of the row level) results in 
> partial row retention that in turn creates data integrity issues at the 
> Phoenix level. 
> Similarly, Phoenix’s max lookback feature leverages HBase deleted data 
> retention capabilities to preserve deleted cells within a configurable max 
> lookback. This requires two data retention windows, max lookback and TTL. One 
> end of these windows is the current time and the end is a moment in the past 
> (i.e., current time minus the window size). Typically, the max lookback 
> window is shorter than the TTL window. In the max lookback window, we would 
> like to preserve the complete history of mutations regardless of how many 
> cell versions these mutations generated. In the remaining TTL window outside 
> the max lookback, we would like to apply the data retention rules defined 
> above. However, HBase provides only one data retention window. Thus, the max 
> lookback window had to be extended to become TTL window and the max lookback 
> feature results in unwantedly retaining deleted data for the maximum of max 
> lookback and TTL periods. 
> This Jira is to fix both of these issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (PHOENIX-6890) Remove binds parameters from QueryCompiler

2023-02-28 Thread Istvan Toth (Jira) 
Istvan Toth created PHOENIX-6890:


 Summary: Remove binds parameters from QueryCompiler
 Key: PHOENIX-6890
 URL: https://issues.apache.org/jira/browse/PHOENIX-6890
 Project: Phoenix
  Issue Type: Bug
Reporter: Istvan Toth


We carry around some List binds variables and method parameteres.
AFAICT these are never used, binds are accessed via PhoenixStatement and 
BindManager.
Confirm and remove them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OMID-239) OMID TLS support

2023-02-28 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/OMID-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694478#comment-17694478
 ] 

ASF GitHub Bot commented on OMID-239:
-

stoty commented on PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#issuecomment-1447932164

   Can you please fix the above conflicts reported by github ?




> OMID TLS support
> 
>
> Key: OMID-239
> URL: https://issues.apache.org/jira/browse/OMID-239
> Project: Phoenix Omid
>  Issue Type: Task
>Reporter: Richárd Antal
>Assignee: Richárd Antal
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Updated] (PHOENIX-6881) Implement the applicable Date/Time features from JDBC 4.2

2023-02-28 Thread Istvan Toth (Jira) 


 [ 
https://issues.apache.org/jira/browse/PHOENIX-6881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Istvan Toth updated PHOENIX-6881:
-
Description: 
[https://jcp.org/aboutJava/communityprocess/maintenance/jsr221/JDBC4.2MR-January2014.pdf]

This mosty means handling the java.time.Local* types in get/setObject.
The java.time.Offset types are probably not relevant to to Phoenix.

Java 8 includes JDBC 4.2, and the version of the spec is available at

[https://download.oracle.com/otndocs/jcp/jdbc-4_2-mrel2-spec/]

JDBC 4.3 is added in Java 9, but the changes there don't seem to be relevant to 
time handling.

  was:
[https://jcp.org/aboutJava/communityprocess/maintenance/jsr221/JDBC4.2MR-January2014.pdf]

This mosty means handling the java.time.Local* types in get/setObject.
The java.time.Offset types are probably not relevant to to Phoenix.

Java 8 includes JDBC 4.2, and the version of the spec is available at

https://download.oracle.com/otndocs/jcp/jdbc-4_2-mrel2-spec/

JDBC 4.3 is added in Java, but the changes there don't seem to be relevant to 
time handling.


> Implement the applicable Date/Time features from JDBC 4.2
> -
>
> Key: PHOENIX-6881
> URL: https://issues.apache.org/jira/browse/PHOENIX-6881
> Project: Phoenix
>  Issue Type: Improvement
>  Components: core
>Reporter: Istvan Toth
>Priority: Major
>
> [https://jcp.org/aboutJava/communityprocess/maintenance/jsr221/JDBC4.2MR-January2014.pdf]
> This mosty means handling the java.time.Local* types in get/setObject.
> The java.time.Offset types are probably not relevant to to Phoenix.
> Java 8 includes JDBC 4.2, and the version of the spec is available at
> [https://download.oracle.com/otndocs/jcp/jdbc-4_2-mrel2-spec/]
> JDBC 4.3 is added in Java 9, but the changes there don't seem to be relevant 
> to time handling.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Created] (PHOENIX-6889) Improve extraction of ENCODED_QUALIFIERs

2023-02-28 Thread Aron Attila Meszaros (Jira) 
Aron Attila Meszaros created PHOENIX-6889:
-

 Summary: Improve extraction of ENCODED_QUALIFIERs
 Key: PHOENIX-6889
 URL: https://issues.apache.org/jira/browse/PHOENIX-6889
 Project: Phoenix
  Issue Type: Improvement
  Components: core
Affects Versions: 5.2.0, 5.1.4
Reporter: Aron Attila Meszaros
Assignee: Aron Attila Meszaros


As the result of PHOENIX-6720,  SchemaExtractionProcessor generates outputs 
which always contain the ENCODED_QUALIFIERs of the table. 

Improve this mechanism to only export ENCODED_QUALIFIERS if they are not a 
consecutive sequence.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OMID-239) OMID TLS support

2023-02-28 Thread ASF GitHub Bot (Jira) 


[ 
https://issues.apache.org/jira/browse/OMID-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694442#comment-17694442
 ] 

ASF GitHub Bot commented on OMID-239:
-

richardantal commented on code in PR #129:
URL: https://github.com/apache/phoenix-omid/pull/129#discussion_r1118802873


##
hbase-common/src/main/java/org/apache/omid/tools/hbase/X509Util.java:
##
@@ -0,0 +1,288 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.omid.tools.hbase;
+
+import io.netty.handler.ssl.SslContext;
+import io.netty.handler.ssl.SslContextBuilder;
+import org.apache.hbase.thirdparty.com.google.common.collect.ObjectArrays;
+import org.apache.yetus.audience.InterfaceAudience;

Review Comment:
   No, I'll delete these lines.



##
transaction-client/pom.xml:
##
@@ -135,6 +151,16 @@
 testng
 test
 
+
+org.apache.omid
+omid-hbase-common
+${project.version}
+compile
+
+

Review Comment:
   Turns out it is not needed afterall





> OMID TLS support
> 
>
> Key: OMID-239
> URL: https://issues.apache.org/jira/browse/OMID-239
> Project: Phoenix Omid
>  Issue Type: Task
>Reporter: Richárd Antal
>Assignee: Richárd Antal
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)