[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-23 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/277 PHOENIX-3757 System mutex table not being created in SYSTEM namespace… … when namespace mapping is enabled On fresh cluster with system table namespace mapping enabled, SYSMUTEX will

[GitHub] phoenix issue #277: PHOENIX-3757 System mutex table not being created in SYS...

2017-10-23 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/277 @twdsilva Please review. @aertoria ---

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146695278 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java --- @@ -95,6 +97,7 @@ // Key is the SYSTEM.CATALOG

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146695798 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2905,14 +2918,18 @@ public void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146697994 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-24 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146698425 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146921855 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/MigrateSystemTablesToSystemNamespaceIT.java --- @@ -0,0 +1,399

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146921986 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146924391 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928295 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146928345 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146967462 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146967826 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146968511 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146972829 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3195,6 +3255,18 @@ public boolean

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146972984 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,72 @@ void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973010 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3086,12 +3103,18 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146973086 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2514,7 +2529,7 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146974246 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146985453 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3101,49 +3124,68 @@ void

[GitHub] phoenix issue #277: PHOENIX-3757 System mutex table not being created in SYS...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/277 > Looks alright to me, but I don't have a lot of context to the intricacy of the change. It would be great if you can apply this patch locally and try out a sqlline based en

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/277#discussion_r146986800 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2526,8 +2541,14 @@ private void

[GitHub] phoenix issue #277: PHOENIX-3757 System mutex table not being created in SYS...

2017-10-25 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/277 These commits also resolve PHOENIX-4227. ---

[GitHub] phoenix pull request #279: PHOENIX-3757 System mutex table not being created...

2017-10-26 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/279 PHOENIX-3757 System mutex table not being created in SYSTEM namespace… … when namespace mapping is enabled Backport of https://github.com/apache/phoenix/pull/277 PR @twdsilva

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-16 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/283 PHOENIX-672 Add GRANT and REVOKE commands using HBase AccessController Initial patch Added support for Grant Revoke SQL statements for HBase ACL Permissions Refactored the tests

[GitHub] phoenix issue #283: PHOENIX-672 Add GRANT and REVOKE commands using HBase Ac...

2017-11-16 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/283 @twdsilva @aertoria @ankitsinghal @joshelser Please review. @JamesRTaylor @apurtell FYI. ---

[GitHub] phoenix pull request #277: PHOENIX-3757 System mutex table not being created...

2017-11-16 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/277 ---

[GitHub] phoenix issue #283: PHOENIX-672 Add GRANT and REVOKE commands using HBase Ac...

2017-11-21 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/283 @samarthjain Please have a look. ---

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-21 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152445087 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152642518 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152642780 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/TableDDLPermissionsIT.java --- @@ -210,25 +98,20 @@ public Void run() throws Exception

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152643463 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644103 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644332 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152644779 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645002 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645385 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152645916 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646351 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646448 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/TablesNotInSyncException.java --- @@ -0,0 +1,16 @@ +package

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152646903 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152649147 --- Diff: phoenix-core/src/test/java/org/apache/phoenix/parse/QueryParserTest.java --- @@ -66,6 +68,46 @@ private void parseQueryThatShouldFail(String

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152662904 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152663200 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-22 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r152685262 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java --- @@ -229,17 +227,12 @@ public void

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153283989 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153582196 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -0,0 +1,635 @@ +/* + * Licensed to the Apache

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153582948 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/283#discussion_r153605197 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4168,4 +4176,197 @@ public MutationState useSchema

[GitHub] phoenix issue #283: PHOENIX-672 Add GRANT and REVOKE commands using HBase Ac...

2017-11-28 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/283 @twdsilva @ankitsinghal @JamesRTaylor Updates: Added ChangePermsStatement that combines the Grant and Revoke Statement Added test for Multitenant tables with view indexes

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/284 PHOENIX-4424 Allow users to create DEFAULT and HBASE Schema (Uppercas… …e Schema Names) @twdsilva Please review. You can merge this pull request into a Git repository by running

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154275774 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/parse/CreateSchemaStatement.java --- @@ -24,7 +24,7 @@ private final boolean

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154276127 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState createSchema

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-11-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154276336 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState createSchema

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-12-01 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154406035 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState createSchema

[GitHub] phoenix pull request #279: PHOENIX-3757 System mutex table not being created...

2017-12-03 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/279 ---

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2017-12-04 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/284#discussion_r154737748 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -4125,7 +4125,7 @@ public MutationState createSchema

[GitHub] phoenix pull request #283: PHOENIX-672 Add GRANT and REVOKE commands using H...

2017-12-05 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/283 ---

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-10 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/288 PHOENIX-4523 phoenix.schema.isNamespaceMappingEnabled problem (TableExistsException should be ignored when trying to create SYSTEM:MUTEX table) @JamesRTaylor FYI. You can merge

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-11 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/288#discussion_r161023714 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2543,16 +2543,15 @@ public Void call() throws

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-13 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/288#discussion_r161383259 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2543,16 +2543,15 @@ public Void call() throws

[GitHub] phoenix pull request #288: PHOENIX-4523 phoenix.schema.isNamespaceMappingEna...

2018-01-13 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/288 ---

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-13 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/289 PHOENIX-4528 PhoenixAccessController checks permissions only at table… … level when creating views @ankitsinghal @twdsilva Please review. @ankitsinghal Please suggest new

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-15 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/289#discussion_r161662712 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/ChangePermissionsIT.java --- @@ -267,4 +267,26 @@ public void testMultiTenantTables

[GitHub] phoenix pull request #289: PHOENIX-4528 PhoenixAccessController checks permi...

2018-01-26 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/289 ---

[GitHub] phoenix pull request #284: PHOENIX-4424 Allow users to create DEFAULT and HB...

2018-01-26 Thread karanmehta93
Github user karanmehta93 closed the pull request at: https://github.com/apache/phoenix/pull/284 ---

[GitHub] phoenix pull request #306: PHOENIX-4797 file not found or file exist excepti...

2018-07-04 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/306#discussion_r200219775 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableSnapshotResultIterator.java --- @@ -35,10 +35,7 @@ import

[GitHub] phoenix pull request #306: PHOENIX-4797 file not found or file exist excepti...

2018-07-05 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/306#discussion_r200400417 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/TableSnapshotResultIterator.java --- @@ -65,7 +66,8 @@ public

[GitHub] phoenix pull request #310: PHOENIX-4805 Move Avatica version to 1.12 for PQS

2018-07-12 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/310 PHOENIX-4805 Move Avatica version to 1.12 for PQS You can merge this pull request into a Git repository by running: $ git pull https://github.com/karanmehta93/phoenix master

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203927054 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixMapReduceUtil.java --- @@ -157,6 +192,192 @@ public static void

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203927581 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203927762 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203932680 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/mapreduce/VerifyReplicationToolIT.java --- @@ -0,0 +1,323 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203933404 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/mapreduce/VerifyReplicationToolIT.java --- @@ -0,0 +1,323 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203933573 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/mapreduce/VerifyReplicationToolIT.java --- @@ -0,0 +1,323 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203937013 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203937052 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-19 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r203937295 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-23 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r204516885 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix issue #309: [Do Not Merge] PHOENIX-3817 Verify Replication using SQL...

2018-07-23 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/309 It would be good to add some comments @akshita-malhotra once you are done with the dev part. ---

[GitHub] phoenix pull request #309: [Do Not Merge] PHOENIX-3817 Verify Replication us...

2018-07-23 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/309#discussion_r204517997 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/VerifyReplicationTool.java --- @@ -0,0 +1,477 @@ +/* + * Licensed to the

[GitHub] phoenix issue #313: PHOENIX-4799 Write cells using checkAndMutate to prevent...

2018-07-24 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/313 Just curious, why not use `SYSTEM.MUTEX` table for this? Its a table specially added for use-cases that need time based expiration and distributed locks. ---

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
GitHub user karanmehta93 opened a pull request: https://github.com/apache/phoenix/pull/315 PHOENIX-3655 Global Phoenix Client Metrics for PQS @joshelser Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/karanmehta93

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 The patch might be tricky to port to other branches. Will also look into that once the initial one gets in. ---

[GitHub] phoenix issue #242: PQS metrics - https://issues.apache.org/jira/browse/PHOE...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/242 We decided not to follow this approach, Hence will be removing the reference to this PR from JIRA. ---

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205899353 --- Diff: phoenix-core/src/test/resources/hadoop-metrics2.properties --- @@ -32,10 +32,9 @@ #[prefix].[source|sink].[instance].[options

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205900530 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalClientMetrics.java --- @@ -108,40 +114,88

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-27 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r205901029 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java --- @@ -204,6 +219,39 @@ private static void resetGlobalMetrics

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-07-30 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 Addressed your comments @joshelser, Please review! ---

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-30 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206412733 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -82,6 +82,10 @@ static final String

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206414419 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -2723,6 +2712,9 @@ private void

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206414686 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3410,17 +3405,10 @@ void

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206415547 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -1913,6 +1940,21 @@ private PTable createTableInternal

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206415970 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -2957,6 +3010,11 @@ MutationState dropTable(String

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r206416912 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/BasePermissionsIT.java --- @@ -16,8 +16,29 @@ */ package

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r206616222 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java --- @@ -0,0 +1,167 @@ +/* + * Licensed

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 @joshelser I was trying out this patch with an internal PQS version. All these metrics are pushed to JMX and we monitor those via OpenTSDB tcollectors. I haven't done any perf-test here,

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-07-31 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 @joshelser I think the only question pending in this PR is if we want JVMMetrics or not, which are crucial from PQS POV, otherwise not really for a regular client. We can discuss what approach

[GitHub] phoenix issue #315: PHOENIX-3655 Global Phoenix Client Metrics for PQS

2018-08-01 Thread karanmehta93
Github user karanmehta93 commented on the issue: https://github.com/apache/phoenix/pull/315 Thanks @joshelser will update the PR soon. We have immediate requirements for HBase-1.x versions here. That is why I mentioned that at the start of PR [itself](https://issues.apache.org/jira

[GitHub] phoenix pull request #315: PHOENIX-3655 Global Phoenix Client Metrics for PQ...

2018-08-01 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/315#discussion_r206968534 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/monitoring/GlobalMetricRegistriesAdapter.java --- @@ -0,0 +1,167 @@ +/* + * Licensed

  1   2   >