[jira] [Commented] (OMID-283) Support for build on mac M1
[
https://issues.apache.org/jira/browse/OMID-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841910#comment-17841910
]
ASF GitHub Bot commented on OMID-283:
-
chrajeshbabu merged PR #159:
URL: https://github.com/apache/phoenix-omid/pull/159
> Support for build on mac M1
> ---
>
> Key: OMID-283
> URL: https://issues.apache.org/jira/browse/OMID-283
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nikita Pande
>Assignee: Nikita Pande
>Priority: Major
>
> * Current code throws following error in `mvn install` command on mac M1
> *
> {noformat}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project omid-common: Configuration error: Invalid
> artifact specification format, expected:
> groupId:artifactId:version[:type[:classifier]], actual:
> com.google.protobuf:protoc:osx-aarch_64:2.5.0:exe:osx-aarch_64 -> [Help
> 1]{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-290) fix CVE-2024-29025 in netty package
[ https://issues.apache.org/jira/browse/OMID-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841908#comment-17841908 ] ASF GitHub Bot commented on OMID-290: - chrajeshbabu merged PR #161: URL: https://github.com/apache/phoenix-omid/pull/161 > fix CVE-2024-29025 in netty package > --- > > Key: OMID-290 > URL: https://issues.apache.org/jira/browse/OMID-290 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nikita Pande >Priority: Major > > [CVE-2024-29025|https://github.com/advisories/GHSA-5jpm-x58v-624v] is the CVE > for all netty-codec-http < 4.1.108.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-289) Add additional asserts in TestOmidClientConfiguration.java
[ https://issues.apache.org/jira/browse/OMID-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841907#comment-17841907 ] ASF GitHub Bot commented on OMID-289: - chrajeshbabu merged PR #160: URL: https://github.com/apache/phoenix-omid/pull/160 > Add additional asserts in TestOmidClientConfiguration.java > -- > > Key: OMID-289 > URL: https://issues.apache.org/jira/browse/OMID-289 > Project: Phoenix Omid > Issue Type: Test >Reporter: Nikita Pande >Assignee: Nikita Pande >Priority: Minor > > Add additional asserts in TestOmidClientConfiguration.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-290) fix CVE-2024-29025 in netty package
[ https://issues.apache.org/jira/browse/OMID-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836148#comment-17836148 ] ASF GitHub Bot commented on OMID-290: - nikita15p commented on PR #161: URL: https://github.com/apache/phoenix-omid/pull/161#issuecomment-2049578652 @stoty Below is the 'mvn install' output. Build along with tests are passed https://github.com/apache/phoenix-omid/assets/37657012/8d01e771-f5ff-4cec-89ed-3b20fb66ec44;> > fix CVE-2024-29025 in netty package > --- > > Key: OMID-290 > URL: https://issues.apache.org/jira/browse/OMID-290 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nikita Pande >Priority: Major > > [CVE-2024-29025|https://github.com/advisories/GHSA-5jpm-x58v-624v] is the CVE > for all netty-codec-http < 4.1.108.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-290) fix CVE-2024-29025 in netty package
[ https://issues.apache.org/jira/browse/OMID-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835997#comment-17835997 ] ASF GitHub Bot commented on OMID-290: - stoty commented on PR #161: URL: https://github.com/apache/phoenix-omid/pull/161#issuecomment-2048912796 We do not currently have working CI for OMID. Has the test suite passed locally @nikita15p ? > fix CVE-2024-29025 in netty package > --- > > Key: OMID-290 > URL: https://issues.apache.org/jira/browse/OMID-290 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nikita Pande >Priority: Major > > [CVE-2024-29025|https://github.com/advisories/GHSA-5jpm-x58v-624v] is the CVE > for all netty-codec-http < 4.1.108.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-289) Add additional asserts in TestOmidClientConfiguration.java
[ https://issues.apache.org/jira/browse/OMID-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833141#comment-17833141 ] ASF GitHub Bot commented on OMID-289: - nikita15p commented on PR #160: URL: https://github.com/apache/phoenix-omid/pull/160#issuecomment-2031731827 @stoty thanks for the review. I have made changes as per the review comments, please review. > Add additional asserts in TestOmidClientConfiguration.java > -- > > Key: OMID-289 > URL: https://issues.apache.org/jira/browse/OMID-289 > Project: Phoenix Omid > Issue Type: Test >Reporter: Nikita Pande >Assignee: Nikita Pande >Priority: Minor > > Add additional asserts in TestOmidClientConfiguration.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-289) Fix missing assertions for TestOmidClientConfiguration.java
[ https://issues.apache.org/jira/browse/OMID-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833017#comment-17833017 ] ASF GitHub Bot commented on OMID-289: - stoty commented on PR #160: URL: https://github.com/apache/phoenix-omid/pull/160#issuecomment-2031124386 The change looks good. I'd prefer to rename the ticket and commit to something like "Add additional asserts in TestOmid..." You can always add more checks in a test, so this is more of an improvement than a fix. > Fix missing assertions for TestOmidClientConfiguration.java > --- > > Key: OMID-289 > URL: https://issues.apache.org/jira/browse/OMID-289 > Project: Phoenix Omid > Issue Type: Test >Reporter: Nikita Pande >Assignee: Nikita Pande >Priority: Minor > > Adding missing assert statement missing for TestOmidClientConfiguration.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-289) Fix missing assertions for TestOmidClientConfiguration.java
[ https://issues.apache.org/jira/browse/OMID-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832706#comment-17832706 ] ASF GitHub Bot commented on OMID-289: - nikita15p opened a new pull request, #160: URL: https://github.com/apache/phoenix-omid/pull/160 Added missing assertions and replaced assertNotNull with accurate assert equals statement for TestOmidClientConfiguration validated the new additions in the file by executing these test cases. All are passing > Fix missing assertions for TestOmidClientConfiguration.java > --- > > Key: OMID-289 > URL: https://issues.apache.org/jira/browse/OMID-289 > Project: Phoenix Omid > Issue Type: Test >Reporter: Nikita Pande >Priority: Minor > > Adding missing assert statement missing for TestOmidClientConfiguration.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831261#comment-17831261
]
ASF GitHub Bot commented on OMID-277:
-
soenkeliebau commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-2022350366
> I have successfully tested this on a pseudistributed cluster with Phoenix
HEAD.
Totally unrelated, just an fyi. We have hdfs, zookeeper and hbase (with
phoenix) operators that are open source at Stackable that could potentially
help you with testing environments here. Happy to spend a bit of time with you
and investigate if we can come up with something to make your life easier if
you are interested.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.1, 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
> Fix For: 1.1.2
>
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
>
[jira] [Commented] (OMID-283) Support for build on mac M1
[
https://issues.apache.org/jira/browse/OMID-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823465#comment-17823465
]
ASF GitHub Bot commented on OMID-283:
-
stoty commented on PR #159:
URL: https://github.com/apache/phoenix-omid/pull/159#issuecomment-1978119830
I will not commit this now, as @chrajeshbabu is in the middle of creating a
release, and I don't want to interfere.
> Support for build on mac M1
> ---
>
> Key: OMID-283
> URL: https://issues.apache.org/jira/browse/OMID-283
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nikita Pande
>Priority: Major
>
> * Current code throws following error in `mvn install` command on mac M1
> *
> {noformat}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project omid-common: Configuration error: Invalid
> artifact specification format, expected:
> groupId:artifactId:version[:type[:classifier]], actual:
> com.google.protobuf:protoc:osx-aarch_64:2.5.0:exe:osx-aarch_64 -> [Help
> 1]{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-283) Support for build on mac M1
[
https://issues.apache.org/jira/browse/OMID-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823313#comment-17823313
]
ASF GitHub Bot commented on OMID-283:
-
nikita15p opened a new pull request, #159:
URL: https://github.com/apache/phoenix-omid/pull/159
mvn -Pmac-m1 install will build the code successfully in the MAC M1 OS
> Support for build on mac M1
> ---
>
> Key: OMID-283
> URL: https://issues.apache.org/jira/browse/OMID-283
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nikita Pande
>Priority: Major
>
> * Current code throws following error in `mvn install` command on mac M1
> *
> {noformat}
> [ERROR] Failed to execute goal
> org.xolstice.maven.plugins:protobuf-maven-plugin:0.6.1:compile
> (compile-protoc) on project omid-common: Configuration error: Invalid
> artifact specification format, expected:
> groupId:artifactId:version[:type[:classifier]], actual:
> com.google.protobuf:protoc:osx-aarch_64:2.5.0:exe:osx-aarch_64 -> [Help
> 1]{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-280) Use Hbase 2.5 for building OMID
[ https://issues.apache.org/jira/browse/OMID-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822191#comment-17822191 ] ASF GitHub Bot commented on OMID-280: - stoty commented on PR #158: URL: https://github.com/apache/phoenix-omid/pull/158#issuecomment-1971440440 > +1, it also works with Phoenix 5.2.0 + HBase 2.4 profile? Yes, it doesn't matter. We dependecy manage every Omid transitive dependency in Phoenix. The only thing that this really affects is the libraries in the TSO server assembly and the test environment. Just as when we build Phoenix for HBase 2.5 but Omid is built for 2.4. (Or when we build Phoenix with HBase 2.1 in 5.1, but Omid is built with 2.4.) > Use Hbase 2.5 for building OMID > --- > > Key: OMID-280 > URL: https://issues.apache.org/jira/browse/OMID-280 > Project: Phoenix Omid > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Critical > Fix For: 1.1.2 > > > We currently build with HBase 2.4.17, and Hadoop 3.1.4. > Using 2.5.7-hadoop3 and Hadoop 3.2.4 would get rid of a lot of CVEs in the > binary assembly. (tso-server) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-278) Change default waitStrategy to LOW_CPU
[ https://issues.apache.org/jira/browse/OMID-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822076#comment-17822076 ] ASF GitHub Bot commented on OMID-278: - stoty commented on PR #157: URL: https://github.com/apache/phoenix-omid/pull/157#issuecomment-1970827129 merged manually. > Change default waitStrategy to LOW_CPU > -- > > Key: OMID-278 > URL: https://issues.apache.org/jira/browse/OMID-278 > Project: Phoenix Omid > Issue Type: Bug >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 1.1.2 > > > The default config for TSO server causes it to burn 400% cpu. > This is a shock for casual users, and not very environmentally friendly > either. > I think that anyone who needs the kind performance benefit that > HIGH_THROUGHPUT brings is able to configure that explicitly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-280) Use Hbase 2.5 for building OMID
[ https://issues.apache.org/jira/browse/OMID-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822069#comment-17822069 ] ASF GitHub Bot commented on OMID-280: - stoty commented on code in PR #158: URL: https://github.com/apache/phoenix-omid/pull/158#discussion_r1507351779 ## pom.xml: ## @@ -174,8 +174,7 @@ 1.3 32.1.3-jre Use Hbase 2.5 for building OMID > --- > > Key: OMID-280 > URL: https://issues.apache.org/jira/browse/OMID-280 > Project: Phoenix Omid > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Critical > Fix For: 1.1.2 > > > We currently build with HBase 2.4.17, and Hadoop 3.1.4. > Using 2.5.7-hadoop3 and Hadoop 3.2.4 would get rid of a lot of CVEs in the > binary assembly. (tso-server) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-280) Use Hbase 2.5 for building OMID
[ https://issues.apache.org/jira/browse/OMID-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822068#comment-17822068 ] ASF GitHub Bot commented on OMID-280: - stoty opened a new pull request, #158: URL: https://github.com/apache/phoenix-omid/pull/158 (no comment) > Use Hbase 2.5 for building OMID > --- > > Key: OMID-280 > URL: https://issues.apache.org/jira/browse/OMID-280 > Project: Phoenix Omid > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Critical > Fix For: 1.1.2 > > > We currently build with HBase 2.4.17, and Hadoop 3.1.4. > Using 2.5.7-hadoop3 and Hadoop 3.2.4 would get rid of a lot of CVEs in the > binary assembly. (tso-server) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-278) Change default waitStrategy to LOW_CPU
[ https://issues.apache.org/jira/browse/OMID-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822067#comment-17822067 ] ASF GitHub Bot commented on OMID-278: - stoty closed pull request #157: OMID-278 Change default waitStrategy to LOW_CPU URL: https://github.com/apache/phoenix-omid/pull/157 > Change default waitStrategy to LOW_CPU > -- > > Key: OMID-278 > URL: https://issues.apache.org/jira/browse/OMID-278 > Project: Phoenix Omid > Issue Type: Bug >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 1.1.2 > > > The default config for TSO server causes it to burn 400% cpu. > This is a shock for casual users, and not very environmentally friendly > either. > I think that anyone who needs the kind performance benefit that > HIGH_THROUGHPUT brings is able to configure that explicitly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-278) Change default waitStrategy to LOW_CPU
[ https://issues.apache.org/jira/browse/OMID-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822022#comment-17822022 ] ASF GitHub Bot commented on OMID-278: - stoty opened a new pull request, #157: URL: https://github.com/apache/phoenix-omid/pull/157 (no comment) > Change default waitStrategy to LOW_CPU > -- > > Key: OMID-278 > URL: https://issues.apache.org/jira/browse/OMID-278 > Project: Phoenix Omid > Issue Type: Bug >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > The default config for TSO server causes it to burn 400% cpu. > This is a shock for casual users, and not very environmentally friendly > either. > I think that anyone who needs the kind performance benefit that > HIGH_THROUGHPUT brings is able to configure that explicitly. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821997#comment-17821997
]
ASF GitHub Bot commented on OMID-277:
-
stoty commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970638636
I have successfully tested this on a pseudistributed cluster with Phoenix
HEAD.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821994#comment-17821994
]
ASF GitHub Bot commented on OMID-277:
-
stoty commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970623853
> I see there is an explicit guava dependency in omid at
https://github.com/apache/phoenix-omid/blob/master/pom.xml#L1215. If it was
replaced with shaded one, do we really need it?
That's not a dependency, just a dependency management entry.
It's not strictly necessary, but it prevents including old Guava versions in
case some dependency decides to depend on unrelocated guava.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
>
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821979#comment-17821979
]
ASF GitHub Bot commented on OMID-277:
-
NihalJain commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970564565
I think this PR also handles
thttps://issues.apache.org/jira/browse/OMID-266, just FYI @stoty
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-272) Support JDK17
[ https://issues.apache.org/jira/browse/OMID-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821977#comment-17821977 ] ASF GitHub Bot commented on OMID-272: - stoty commented on PR #153: URL: https://github.com/apache/phoenix-omid/pull/153#issuecomment-1970560127 merged manually > Support JDK17 > - > > Key: OMID-272 > URL: https://issues.apache.org/jira/browse/OMID-272 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 1.1.1 > > > Tests fail hard with JDK 17. > Hopefully we get this running simply by copying the modules options from > HBase to the surefire command line and the startup scripts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821975#comment-17821975
]
ASF GitHub Bot commented on OMID-277:
-
NihalJain commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970557100
I see there is an explicit guava dependency in omid at
https://github.com/apache/phoenix-omid/blob/master/pom.xml#L1215. If it was
replaced with shaded one, do we really need it?
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
[jira] [Commented] (OMID-272) Support JDK17
[ https://issues.apache.org/jira/browse/OMID-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821965#comment-17821965 ] ASF GitHub Bot commented on OMID-272: - stoty closed pull request #153: OMID-272 Support JDK17 URL: https://github.com/apache/phoenix-omid/pull/153 > Support JDK17 > - > > Key: OMID-272 > URL: https://issues.apache.org/jira/browse/OMID-272 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > Fix For: 1.1.1 > > > Tests fail hard with JDK 17. > Hopefully we get this running simply by copying the modules options from > HBase to the surefire command line and the startup scripts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821955#comment-17821955
]
ASF GitHub Bot commented on OMID-277:
-
stoty commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970502628
The most frustrating part is that every single one of these Guava usages is
completely unneccessary, this could have been done without Guava with the same
effort.
But I digress.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821953#comment-17821953
]
ASF GitHub Bot commented on OMID-277:
-
stoty commented on PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#issuecomment-1970500550
> Here we need manual verification only with locally deployed cluster?
Yes, that's the only way to make sure.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821951#comment-17821951
]
ASF GitHub Bot commented on OMID-277:
-
stoty commented on code in PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#discussion_r1507077825
##
pom.xml:
##
@@ -293,6 +294,67 @@
+
+ org.apache.maven.plugins
+ maven-enforcer-plugin
+
+
+ de.skuzzle.enforcer
+ restrict-imports-enforcer-rule
+ ${restrict-imports.enforcer.version}
+
+
Review Comment:
Straight copy-paste from Phoenix :)
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
>
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821948#comment-17821948
]
ASF GitHub Bot commented on OMID-277:
-
virajjasani commented on code in PR #156:
URL: https://github.com/apache/phoenix-omid/pull/156#discussion_r1507075329
##
pom.xml:
##
@@ -293,6 +294,67 @@
+
+ org.apache.maven.plugins
+ maven-enforcer-plugin
+
+
+ de.skuzzle.enforcer
+ restrict-imports-enforcer-rule
+ ${restrict-imports.enforcer.version}
+
+
Review Comment:
Nice! When i started looking at the changes, i immediately came here to see
if we are going to restrict the import.
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
[jira] [Commented] (OMID-277) Omid 1.1.2 fails with Phoenix 5.2
[
https://issues.apache.org/jira/browse/OMID-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821943#comment-17821943
]
ASF GitHub Bot commented on OMID-277:
-
stoty opened a new pull request, #156:
URL: https://github.com/apache/phoenix-omid/pull/156
(no comment)
> Omid 1.1.2 fails with Phoenix 5.2
> -
>
> Key: OMID-277
> URL: https://issues.apache.org/jira/browse/OMID-277
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.2
>Reporter: Lars Hofhansl
>Assignee: Istvan Toth
>Priority: Major
>
> Try to create a transactional table with Phoenix 5.2 and Omid 1.1.2, and
> you'll find this in the RS log:
> {code:java}
> 2024-02-28T20:26:13,055 ERROR [RS_OPEN_REGION-regionserver/think:16020-2]
> coprocessor.CoprocessorHost: The coprocessor
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor threw
> java.lang.NoClassDefFoundE
> rror: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> java.lang.NoClassDefFoundError: Could not initialize class
> org.apache.omid.committable.hbase.HBaseCommitTableConfig
> at
> org.apache.omid.transaction.OmidSnapshotFilter.start(OmidSnapshotFilter.java:85)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidTransactionalProcessor.start(OmidTransactionalProcessor.java:44)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.hadoop.hbase.coprocessor.BaseEnvironment.startup(BaseEnvironment.java:69)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.checkAndLoadInstance(CoprocessorHost.java:285)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:249)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:200)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:388)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.(RegionCoprocessorHost.java:278)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:859)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.regionserver.HRegion.(HRegion.java:734)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
> ~[?:?]
> at java.lang.reflect.Constructor.newInstance(Constructor.java:486) ~[?:?]
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6971)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7184)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7161)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7120)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7076)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:149)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:104)
> ~[hbase-server-2.5.7.jar:2.5.7]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
> ~[?:?]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
> ~[?:?]
> at java.lang.Thread.run(Thread.java:1583) ~[?:?]
> Caused by: java.lang.ExceptionInInitializerError: Exception
> java.lang.NoClassDefFoundError:
> org/apache/phoenix/shaded/com/google/common/base/Charsets [in thread
> "RS_OPEN_REGION-regionserver/think:16020-2"]
> at
> org.apache.omid.committable.hbase.HBaseCommitTableConfig.(HBaseCommitTableConfig.java:36)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at org.apache.omid.transaction.OmidCompactor.start(OmidCompactor.java:92)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> at
> org.apache.phoenix.coprocessor.OmidGCProcessor.start(OmidGCProcessor.java:43)
> ~[phoenix-server-hbase-2.5-5.2.0.jar:5.2.0]
> ... 21 more{code}
>
> As before I have no time to track this down as I do not work on Phoenix/HBase
> anymore, but at least I can file an issue. :)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-271) Support HBase 3
[ https://issues.apache.org/jira/browse/OMID-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813522#comment-17813522 ] ASF GitHub Bot commented on OMID-271: - stoty commented on PR #152: URL: https://github.com/apache/phoenix-omid/pull/152#issuecomment-1923192641 This is basically what I intend commit, but it's WIP until there is no final HBase release. > Support HBase 3 > --- > > Key: OMID-271 > URL: https://issues.apache.org/jira/browse/OMID-271 > Project: Phoenix Omid > Issue Type: New Feature >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-275) Expose backing HBase Table from TTable
[ https://issues.apache.org/jira/browse/OMID-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810228#comment-17810228 ] ASF GitHub Bot commented on OMID-275: - stoty commented on PR #155: URL: https://github.com/apache/phoenix-omid/pull/155#issuecomment-1907483237 merged manually. > Expose backing HBase Table from TTable > -- > > Key: OMID-275 > URL: https://issues.apache.org/jira/browse/OMID-275 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > HBase 3.0 removes the HTableDescriptor class. > However, OmidTransactionTable in Phoenix needs to implement > getTableDescriptor() when build for HBase 2. > The way to break this to expose the backing HBase Table object from TTable. > That way, we can still get getTableDescriptor from that for HBase 2. > If we implement this for 1.1.1, then we can use this new API for 5.1.4 (and > possibly 5.2.0), which would hoepfully let them be built with future Omid > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-275) Expose backing HBase Table from TTable
[ https://issues.apache.org/jira/browse/OMID-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17810227#comment-17810227 ] ASF GitHub Bot commented on OMID-275: - stoty closed pull request #155: OMID-275 Expose backing HBase Table from TTable URL: https://github.com/apache/phoenix-omid/pull/155 > Expose backing HBase Table from TTable > -- > > Key: OMID-275 > URL: https://issues.apache.org/jira/browse/OMID-275 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > HBase 3.0 removes the HTableDescriptor class. > However, OmidTransactionTable in Phoenix needs to implement > getTableDescriptor() when build for HBase 2. > The way to break this to expose the backing HBase Table object from TTable. > That way, we can still get getTableDescriptor from that for HBase 2. > If we implement this for 1.1.1, then we can use this new API for 5.1.4 (and > possibly 5.2.0), which would hoepfully let them be built with future Omid > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-249) Improve default network address logic
[ https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809811#comment-17809811 ] ASF GitHub Bot commented on OMID-249: - stoty closed pull request #154: OMID-249 Improve default network address logic URL: https://github.com/apache/phoenix-omid/pull/154 > Improve default network address logic > - > > Key: OMID-249 > URL: https://issues.apache.org/jira/browse/OMID-249 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > NetworkUtils.getNetworkInterface() seems to be only used for determining the > host and port when registering TSO to ZK for HA. > We should get the TSO public IP from the ZK TCP connection on demand, and not > worry about the default network interface at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-249) Improve default network address logic
[ https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809812#comment-17809812 ] ASF GitHub Bot commented on OMID-249: - stoty commented on PR #154: URL: https://github.com/apache/phoenix-omid/pull/154#issuecomment-1905593916 merged manually > Improve default network address logic > - > > Key: OMID-249 > URL: https://issues.apache.org/jira/browse/OMID-249 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > NetworkUtils.getNetworkInterface() seems to be only used for determining the > host and port when registering TSO to ZK for HA. > We should get the TSO public IP from the ZK TCP connection on demand, and not > worry about the default network interface at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-275) Expose backing HBase Table from TTable
[ https://issues.apache.org/jira/browse/OMID-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809773#comment-17809773 ] ASF GitHub Bot commented on OMID-275: - stoty opened a new pull request, #155: URL: https://github.com/apache/phoenix-omid/pull/155 (no comment) > Expose backing HBase Table from TTable > -- > > Key: OMID-275 > URL: https://issues.apache.org/jira/browse/OMID-275 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > > HBase 3.0 removes the HTableDescriptor class. > However, OmidTransactionTable in Phoenix needs to implement > getTableDescriptor() when build for HBase 2. > The way to break this to expose the backing HBase Table object from TTable. > That way, we can still get getTableDescriptor from that for HBase 2. > If we implement this for 1.1.1, then we can use this new API for 5.1.4 (and > possibly 5.2.0), which would hoepfully let them be built with future Omid > releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-249) Improve default network address logic
[ https://issues.apache.org/jira/browse/OMID-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808656#comment-17808656 ] ASF GitHub Bot commented on OMID-249: - stoty opened a new pull request, #154: URL: https://github.com/apache/phoenix-omid/pull/154 (no comment) > Improve default network address logic > - > > Key: OMID-249 > URL: https://issues.apache.org/jira/browse/OMID-249 > Project: Phoenix Omid > Issue Type: Improvement >Affects Versions: 1.1.0 >Reporter: Istvan Toth >Priority: Major > > NetworkUtils.getNetworkInterface() seems to be only used for determining the > host and port when registering TSO to ZK for HA. > We should get the TSO public IP from the ZK TCP connection on demand, and not > worry about the default network interface at all. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-272) Support JDK17
[ https://issues.apache.org/jira/browse/OMID-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808495#comment-17808495 ] ASF GitHub Bot commented on OMID-272: - stoty opened a new pull request, #153: URL: https://github.com/apache/phoenix-omid/pull/153 (no comment) > Support JDK17 > - > > Key: OMID-272 > URL: https://issues.apache.org/jira/browse/OMID-272 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Istvan Toth >Priority: Major > > Tests fail hard with JDK. > Hopefully we get this running simply by copying the modules options from > HBase to the surefire command line and the startup scripts. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-271) Support HBase 3
[ https://issues.apache.org/jira/browse/OMID-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17808458#comment-17808458 ] ASF GitHub Bot commented on OMID-271: - stoty opened a new pull request, #152: URL: https://github.com/apache/phoenix-omid/pull/152 WIP > Support HBase 3 > --- > > Key: OMID-271 > URL: https://issues.apache.org/jira/browse/OMID-271 > Project: Phoenix Omid > Issue Type: New Feature >Affects Versions: 1.1.1 >Reporter: Istvan Toth >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802053#comment-17802053
]
ASF GitHub Bot commented on OMID-254:
-
chrajeshbabu merged PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801686#comment-17801686
]
ASF GitHub Bot commented on OMID-254:
-
stoty commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873692027
No need, if you have tested with thirdparty-2.1 in both Omid and Phoenix at
the same time, that's fine.
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801681#comment-17801681
]
ASF GitHub Bot commented on OMID-254:
-
NihalJain commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873681962
> Have you run the full Phoenix test suite with both Phoenix and Omid built
with the new thirdparty,@NihalJain ?
Hi @stoty I have ran following for omid.
> Built code locally and ran tests.:
>
> ```
> mvn clean install -Dhbase.version=2.5.6-hadoop3 -DskipTests
> mvn verify -Dsurefire.rerunFailingTestsCount=5
-Dhbase.version=2.5.6-hadoop3
> ```
Also had run tests for phoenix with
https://github.com/apache/phoenix-thirdparty/pull/8#issuecomment-1832165125
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801677#comment-17801677
]
ASF GitHub Bot commented on OMID-254:
-
stoty commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873673603
Have you run the full Phoenix test suite with both Phoenix and Omid built
with the new thirdparty, @NihalJain ?
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799729#comment-17799729
]
ASF GitHub Bot commented on OMID-254:
-
chrajeshbabu commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867419622
+lgtm
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799726#comment-17799726
]
ASF GitHub Bot commented on OMID-254:
-
NihalJain commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867416988
Built code locally and ran tests.:
```
mvn clean install -Dhbase.version=2.5.6-hadoop3 -DskipTests
mvn verify -Dsurefire.rerunFailingTestsCount=5 -Dhbase.version=2.5.6-hadoop3
```
FYI @chrajeshbabu , @stoty , @gjacoby126
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-254) Upgrade to phoenix-thirdparty 2.1.0
[
https://issues.apache.org/jira/browse/OMID-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799723#comment-17799723
]
ASF GitHub Bot commented on OMID-254:
-
NihalJain opened a new pull request, #151:
URL: https://github.com/apache/phoenix-omid/pull/151
(no comment)
> Upgrade to phoenix-thirdparty 2.1.0
> ---
>
> Key: OMID-254
> URL: https://issues.apache.org/jira/browse/OMID-254
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Phoenix-thirdparty has been released, see
> [https://www.mail-archive.com/user@phoenix.apache.org/msg08204.html]
> {quote}The recent release has upgraded Guava to version 32.1.3-jre from the
> previous 31.0.1-android version. Initially, the 4.x branch maintained
> compatibility with Java 7, necessitating the use of the Android variant of
> Guava. However, with the end-of-life (EOL) status of the 4.x branch, the move
> to the standard JRE version of Guava signifies a shift in compatibility
> standards
> {quote}
> It's time we bump up.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-250) Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
[
https://issues.apache.org/jira/browse/OMID-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796821#comment-17796821
]
ASF GitHub Bot commented on OMID-250:
-
chrajeshbabu merged PR #150:
URL: https://github.com/apache/phoenix-omid/pull/150
> Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
> -
>
> Key: OMID-250
> URL: https://issues.apache.org/jira/browse/OMID-250
> Project: Phoenix Omid
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Trivial
> Fix For: 1.1.1
>
>
> hadoop-hdfs-client dependency is declared two times in main pom.
> {noformat}
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-250) Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
[
https://issues.apache.org/jira/browse/OMID-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796813#comment-17796813
]
ASF GitHub Bot commented on OMID-250:
-
chrajeshbabu commented on PR #150:
URL: https://github.com/apache/phoenix-omid/pull/150#issuecomment-1856136145
@anchal246 thanks for the patch.
Nit. Could you please update the commit message as for the convention
mentioned here
https://phoenix.apache.org/contributing.html
The commit message should reference the jira ticket issue (which has the
format PHOENIX-{NUMBER}:{JIRA-TITLE}).
> Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
> -
>
> Key: OMID-250
> URL: https://issues.apache.org/jira/browse/OMID-250
> Project: Phoenix Omid
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Trivial
> Fix For: 1.1.1
>
>
> hadoop-hdfs-client dependency is declared two times in main pom.
> {noformat}
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-250) Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
[
https://issues.apache.org/jira/browse/OMID-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796788#comment-17796788
]
ASF GitHub Bot commented on OMID-250:
-
anchal246 opened a new pull request, #150:
URL: https://github.com/apache/phoenix-omid/pull/150
…client dependency in pom.xml
> Remove duplicate declarations of hadoop-hdfs-client dependency in pom.xml
> -
>
> Key: OMID-250
> URL: https://issues.apache.org/jira/browse/OMID-250
> Project: Phoenix Omid
> Issue Type: Bug
>Reporter: Rajeshbabu Chintaguntla
>Assignee: Rajeshbabu Chintaguntla
>Priority: Trivial
> Fix For: 1.1.1
>
>
> hadoop-hdfs-client dependency is declared two times in main pom.
> {noformat}
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
>
> org.apache.hadoop
> hadoop-hdfs-client
> ${hadoop.version}
>
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792959#comment-17792959
]
ASF GitHub Bot commented on OMID-240:
-
chrajeshbabu merged PR #149:
URL: https://github.com/apache/phoenix-omid/pull/149
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Fix For: 1.1.1
>
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791713#comment-17791713
]
ASF GitHub Bot commented on OMID-240:
-
chrajeshbabu commented on code in PR #149:
URL: https://github.com/apache/phoenix-omid/pull/149#discussion_r1410970001
##
tso-server/bin/omid-env.sh:
##
@@ -22,6 +22,14 @@
# Check if HADOOP_CONF_DIR and HBASE_CONF_DIR are set
#
-
-if [ -z ${HADOOP_CONF_DIR+x} ]; then echo "WARNING: HADOOP_CONF_DIR is unset";
else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
-if [ -z ${HBASE_CONF_DIR+x} ]; then echo "WARNING: HBASE_CONF_DIR is unset";
else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
+if [ -z ${HADOOP_CONF_DIR+x} ];
+ then echo "WARNING: HADOOP_CONF_DIR is unset";
+ HADOOP_CONF_DIR=/etc/hadoop/conf
Review Comment:
@stoty handled the review comments in the new commit. Thanks
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791484#comment-17791484
]
ASF GitHub Bot commented on OMID-240:
-
stoty commented on code in PR #149:
URL: https://github.com/apache/phoenix-omid/pull/149#discussion_r1410227235
##
tso-server/bin/omid-env.sh:
##
@@ -22,6 +22,14 @@
# Check if HADOOP_CONF_DIR and HBASE_CONF_DIR are set
#
-
-if [ -z ${HADOOP_CONF_DIR+x} ]; then echo "WARNING: HADOOP_CONF_DIR is unset";
else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
-if [ -z ${HBASE_CONF_DIR+x} ]; then echo "WARNING: HBASE_CONF_DIR is unset";
else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
+if [ -z ${HADOOP_CONF_DIR+x} ];
+ then echo "WARNING: HADOOP_CONF_DIR is unset";
+ HADOOP_CONF_DIR=/etc/hadoop/conf
Review Comment:
or at least that the direcory itself exists.
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791483#comment-17791483
]
ASF GitHub Bot commented on OMID-240:
-
stoty commented on code in PR #149:
URL: https://github.com/apache/phoenix-omid/pull/149#discussion_r1410226164
##
tso-server/bin/omid-env.sh:
##
@@ -22,6 +22,14 @@
# Check if HADOOP_CONF_DIR and HBASE_CONF_DIR are set
#
-
-if [ -z ${HADOOP_CONF_DIR+x} ]; then echo "WARNING: HADOOP_CONF_DIR is unset";
else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
-if [ -z ${HBASE_CONF_DIR+x} ]; then echo "WARNING: HBASE_CONF_DIR is unset";
else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
+if [ -z ${HADOOP_CONF_DIR+x} ];
+ then echo "WARNING: HADOOP_CONF_DIR is unset";
+ HADOOP_CONF_DIR=/etc/hadoop/conf
Review Comment:
At least check if there is an exepected config file in that directory before
setting it.
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791481#comment-17791481
]
ASF GitHub Bot commented on OMID-240:
-
stoty commented on code in PR #149:
URL: https://github.com/apache/phoenix-omid/pull/149#discussion_r1410225641
##
tso-server/bin/omid-env.sh:
##
@@ -22,6 +22,14 @@
# Check if HADOOP_CONF_DIR and HBASE_CONF_DIR are set
#
-
-if [ -z ${HADOOP_CONF_DIR+x} ]; then echo "WARNING: HADOOP_CONF_DIR is unset";
else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
-if [ -z ${HBASE_CONF_DIR+x} ]; then echo "WARNING: HBASE_CONF_DIR is unset";
else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
+if [ -z ${HADOOP_CONF_DIR+x} ];
+ then echo "WARNING: HADOOP_CONF_DIR is unset";
+ HADOOP_CONF_DIR=/etc/hadoop/conf
Review Comment:
I am not sure about this.
These are the bigtop standard directories, but they are not used by HBase by
default.
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-240) Transactional visibility is broken
[
https://issues.apache.org/jira/browse/OMID-240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17791460#comment-17791460
]
ASF GitHub Bot commented on OMID-240:
-
chrajeshbabu opened a new pull request, #149:
URL: https://github.com/apache/phoenix-omid/pull/149
with InMemoryCommitTableStorageModule by default server side filtering not
working properly. So changing it to HBase Commit Table Storage Module
> Transactional visibility is broken
> --
>
> Key: OMID-240
> URL: https://issues.apache.org/jira/browse/OMID-240
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Lars Hofhansl
>Assignee: Rajeshbabu Chintaguntla
>Priority: Critical
> Attachments: hbase-omid-client-config.yml,
> omid-server-configuration.yml
>
>
> Client I:
> {code:java}
> > create table test(x float primary key, y float) DISABLE_WAL=true,
> TRANSACTIONAL=true;
> No rows affected (1.872 seconds)
> > !autocommit off
> Autocommit status: false
> > upsert into test values(rand(), rand());
> 1 row affected (0.018 seconds)
> > upsert into test select rand(), rand() from test;
> -- 18-20x
> > !commit{code}
>
> Client II:
> {code:java}
> -- repeat quickly after the commit on client I
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 0 |
> +--+
> 1 row selected (1.408 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 259884 |
> +--+
> 1 row selected (2.959 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260145 |
> +--+
> 1 row selected (4.274 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.563 seconds)
> > select count(*) from test;
> +--+
> | COUNT(1) |
> +--+
> | 260148 |
> +--+
> 1 row selected (5.573 seconds){code}
> The second client should either show 0 or 260148. But no other value!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788489#comment-17788489 ] ASF GitHub Bot commented on OMID-256: - chrajeshbabu merged PR #145: URL: https://github.com/apache/phoenix-omid/pull/145 > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 1.1.1 > > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17782276#comment-17782276 ] ASF GitHub Bot commented on OMID-256: - NihalJain commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1791292920 > @NihalJain could you please handle the conflicts caused due to other merges. Rebased code. > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > Fix For: 1.1.1 > > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781461#comment-17781461 ] ASF GitHub Bot commented on OMID-256: - chrajeshbabu commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1787573657 @NihalJain could you please handle the conflicts caused due to other merges. > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781460#comment-17781460
]
ASF GitHub Bot commented on OMID-264:
-
chrajeshbabu merged PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-258) Bump maven plugins/dependencies to latest
[ https://issues.apache.org/jira/browse/OMID-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17781459#comment-17781459 ] ASF GitHub Bot commented on OMID-258: - chrajeshbabu merged PR #148: URL: https://github.com/apache/phoenix-omid/pull/148 > Bump maven plugins/dependencies to latest > - > > Key: OMID-258 > URL: https://issues.apache.org/jira/browse/OMID-258 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Plan is to bump following: > ||Property||From||To|| > |apache parent pom version|23|30| > |os.plugin.version|1.6.2|1.7.1| > |google.findbugs.version|3.0.1|3.0.2| > |maven-pmd-plugin.version|3.4|3.21.0| > |maven-checkstyle-plugin.version|2.17|3.3.0| > |maven-jxr-plugin.version|2.3|3.3.0| > |maven-findbugs-maven-plugin.version|3.0.1|3.0.5| > |maven-owasp-plugin.version|6.5.3|8.4.0| > |maven-clover-plugin.version|4.4.1|4.5.0| > |maven-sonar-plugin.version|3.9.1.2184|3.10.0.2594| > Also need to remove and clean up all the version definitions that specify > versions older than the ones defined in the parent pom. > CC: [~stoty] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-258) Bump maven plugins/dependencies to latest
[ https://issues.apache.org/jira/browse/OMID-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780294#comment-17780294 ] ASF GitHub Bot commented on OMID-258: - NihalJain commented on PR #148: URL: https://github.com/apache/phoenix-omid/pull/148#issuecomment-1782645463 Tested following: - Ran checkstyle and ensured checkstyle errors are seen and report is saved - Ran mvn pmd:pmd and verified no build fail - Ran run-coverage.sh and verified clover coverage report is saved - Ran owasp check and verfied scan report is saved - Verified assembly tarball is created Please let me know if anything more to ne tested. CC: @stoty > Bump maven plugins/dependencies to latest > - > > Key: OMID-258 > URL: https://issues.apache.org/jira/browse/OMID-258 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Plan is to bump following: > ||Property||From||To|| > |maven-assembly-plugin-version|3.1.1|3.6.0| > |maven-pmd-plugin.version|3.4|3.21.0| > |maven-checkstyle-plugin.version|2.17|3.3.0| > |maven-jxr-plugin.version|2.3|3.3.0| > |google.findbugs.version|3.0.1|3.0.2| > |maven-findbugs-maven-plugin.version|3.0.1|3.0.5| > |maven-owasp-plugin.version|6.5.3|8.4.0| > |maven-clover-plugin.version|4.4.1|4.5.0| > |maven-sonar-plugin.version|3.9.1.2184|3.10.0.2594| > |os.plugin.version|1.6.2|1.7.1| > Also need to remove and clean up all the version definitions that specify > versions older than the ones defined in the parent pom. > CC: [~stoty] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-258) Bump maven plugins/dependencies to latest
[ https://issues.apache.org/jira/browse/OMID-258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780291#comment-17780291 ] ASF GitHub Bot commented on OMID-258: - NihalJain opened a new pull request, #148: URL: https://github.com/apache/phoenix-omid/pull/148 - Bump apache parent pom version to 30 - Remove maven-assembly-plugin-version and surefire.version as it is coming from parent pom - Bump following plugins/dependencies - os.plugin.version to 1.7.1 - google.findbugs.version to 3.0.2 - maven-pmd-plugin.version to 3.21.0 - maven-checkstyle-plugin.version to 3.3.0 - maven-jxr-plugin.version to 3.3.0 - maven-findbugs-maven-plugin.version to 3.0.5 - maven-owasp-plugin.version to 8.4.0 - maven-clover-plugin.version to 4.5.0 - maven-sonar-plugin.version to 3.10.0.2594 - Also updated omid_checks.xml based on updated checkstyle. Issues based on which changes were made: - https://github.com/checkstyle/checkstyle/issues/2116 - https://github.com/checkstyle/checkstyle/issues/3671 - https://github.com/checkstyle/checkstyle/issues/7417 - https://github.com/checkstyle/checkstyle/issues/7329 > Bump maven plugins/dependencies to latest > - > > Key: OMID-258 > URL: https://issues.apache.org/jira/browse/OMID-258 > Project: Phoenix Omid > Issue Type: Improvement >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Plan is to bump following: > ||Property||From||To|| > |maven-assembly-plugin-version|3.1.1|3.6.0| > |maven-pmd-plugin.version|3.4|3.21.0| > |maven-checkstyle-plugin.version|2.17|3.3.0| > |maven-jxr-plugin.version|2.3|3.3.0| > |google.findbugs.version|3.0.1|3.0.2| > |maven-findbugs-maven-plugin.version|3.0.1|3.0.5| > |maven-owasp-plugin.version|6.5.3|8.4.0| > |maven-clover-plugin.version|4.4.1|4.5.0| > |maven-sonar-plugin.version|3.9.1.2184|3.10.0.2594| > |os.plugin.version|1.6.2|1.7.1| > Also need to remove and clean up all the version definitions that specify > versions older than the ones defined in the parent pom. > CC: [~stoty] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779513#comment-17779513 ] ASF GitHub Bot commented on OMID-256: - stoty commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779290106 Please check the commit message before commit. Are the new versions in separate lines ? It doesn't look like that me. > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779491#comment-17779491 ] ASF GitHub Bot commented on OMID-256: - NihalJain commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779173881 Updated commit message, rebased PR. > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779480#comment-17779480 ] ASF GitHub Bot commented on OMID-256: - NihalJain commented on code in PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#discussion_r1371606112 ## pom.xml: ## @@ -152,21 +152,21 @@ UTF-8 Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > |os.plugin.version|1.6.2|1.7.1| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779481#comment-17779481 ] ASF GitHub Bot commented on OMID-256: - NihalJain commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1779094865 > Please list the changes in the comit message. Sure let me add details to commit message > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > |os.plugin.version|1.6.2|1.7.1| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779477#comment-17779477
]
ASF GitHub Bot commented on OMID-264:
-
NihalJain commented on PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#issuecomment-1779091312
Created OMID-265
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-253) Upgrade Netty to 4.1.100.Final
[ https://issues.apache.org/jira/browse/OMID-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779429#comment-17779429 ] ASF GitHub Bot commented on OMID-253: - chrajeshbabu merged PR #143: URL: https://github.com/apache/phoenix-omid/pull/143 > Upgrade Netty to 4.1.100.Final > -- > > Key: OMID-253 > URL: https://issues.apache.org/jira/browse/OMID-253 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Netty 4.1.86.Final has > [CVE-2023-34462|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34462] > which has been fixed in version > 4.1.94.Final. > This Jira is to bump to 4.1.100.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-255) Upgrade guava to 32.1.3-jre
[ https://issues.apache.org/jira/browse/OMID-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779424#comment-17779424 ] ASF GitHub Bot commented on OMID-255: - chrajeshbabu merged PR #144: URL: https://github.com/apache/phoenix-omid/pull/144 > Upgrade guava to 32.1.3-jre > --- > > Key: OMID-255 > URL: https://issues.apache.org/jira/browse/OMID-255 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-257) Upgrade bouncycastle and move from jdk15on to latest jdk18on
[
https://issues.apache.org/jira/browse/OMID-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779420#comment-17779420
]
ASF GitHub Bot commented on OMID-257:
-
chrajeshbabu merged PR #146:
URL: https://github.com/apache/phoenix-omid/pull/146
> Upgrade bouncycastle and move from jdk15on to latest jdk18on
>
>
> Key: OMID-257
> URL: https://issues.apache.org/jira/browse/OMID-257
> Project: Phoenix Omid
> Issue Type: Sub-task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
>
> Omid has a test dependency on BouncyCastle 1.60 which is vulnerable with
> following CVEs
> *
> [CVE-2023-33201|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-33201]
> *
> [CVE-2020-26939|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-26939]
> *
> [CVE-2020-15522|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15522]
> Latest being,
> [CVE-2023-33201|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-33201]
> with advisory: [https://github.com/bcgit/bc-java/wiki/CVE-2023-33201]
> This JIRA's goal is to fix the following:
> * Upgrade to v1.76, the latest version.
> ** This requires bcprov-jdk15on to be replaced with bcprov-jdk18on
> ** See [https://www.bouncycastle.org/latest_releases.html]
> ***
> {quote}*Java Version Details* With the arrival of Java 15. jdk15 is not quite
> as unambiguous as it was. The *jdk18on* jars are compiled to work with
> *anything* from Java 1.8 up. They are also multi-release jars so do support
> some features that were introduced in Java 9, Java 11, and Java 15. If you
> have issues with multi-release jars see the jdk15to18 release jars below.
> *Packaging Change (users of 1.70 or earlier):* BC 1.71 changed the jdk15on
> jars to jdk18on so the base has now moved to Java 8. For earlier JVMs, or
> containers/applications that cannot cope with multi-release jars, you should
> now use the jdk15to18 jars.
> {quote}
> * Exclude bcprov-jdk15on from everywhere else to avoid conflicts with
> bcprov-jdk18on
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779417#comment-17779417
]
ASF GitHub Bot commented on OMID-264:
-
NihalJain commented on PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#issuecomment-1778817848
> I don't know spotless well.
> Lets do whatever HBase is doing.
HBase uses spotless. Let me create a jira to move to spotless and clean up.
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779415#comment-17779415
]
ASF GitHub Bot commented on OMID-264:
-
stoty commented on PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#issuecomment-1778802745
I don't know spotless well.
Lets do whatever HBase is doing.
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779412#comment-17779412
]
ASF GitHub Bot commented on OMID-264:
-
NihalJain commented on PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#issuecomment-1778795509
> Can you make a follow-up ticket to really clean up the configuration ?
Sure let me clean up with a follow up JIRA.
Also do you think we should replace this with spotless? I am well versed
with it and based on what I am seeing this plugin is only for headers, which
spotless does seemlessly.
I am okay just cleaning up as well. Let me know what do you think.
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779413#comment-17779413 ] ASF GitHub Bot commented on OMID-256: - stoty commented on code in PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#discussion_r1371379906 ## pom.xml: ## @@ -152,21 +152,21 @@ UTF-8 Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > |os.plugin.version|1.6.2|1.7.1| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779404#comment-17779404
]
ASF GitHub Bot commented on OMID-264:
-
stoty commented on code in PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#discussion_r1371360421
##
pom.xml:
##
@@ -367,54 +367,58 @@
${maven-license-plugin.version}
true Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-257) Upgrade bouncycastle and move from jdk15on to latest jdk18on
[ https://issues.apache.org/jira/browse/OMID-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1958#comment-1958 ] ASF GitHub Bot commented on OMID-257: - NihalJain commented on PR #146: URL: https://github.com/apache/phoenix-omid/pull/146#issuecomment-1773339869 Ran following command with a consolidated change of 4 PRs locally: mvn clean verify site -Dspotbugs.site -Dhbase.version=2.5.5-hadoop3 -Dsurefire.rerunFailingTestsCount=3 PR list: - https://github.com/apache/phoenix-omid/pull/143 - https://github.com/apache/phoenix-omid/pull/144 - https://github.com/apache/phoenix-omid/pull/145 - https://github.com/apache/phoenix-omid/pull/146 BUILD was SUCCESS! > Upgrade bouncycastle and move from jdk15on to latest jdk18on > > > Key: OMID-257 > URL: https://issues.apache.org/jira/browse/OMID-257 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1957#comment-1957 ] ASF GitHub Bot commented on OMID-256: - NihalJain commented on PR #145: URL: https://github.com/apache/phoenix-omid/pull/145#issuecomment-1773339031 Ran following command with a consolidated change of 4 PRs locally: mvn clean verify site -Dspotbugs.site -Dhbase.version=2.5.5-hadoop3 -Dsurefire.rerunFailingTestsCount=3 PR list: - https://github.com/apache/phoenix-omid/pull/143 - https://github.com/apache/phoenix-omid/pull/144 - https://github.com/apache/phoenix-omid/pull/145 - https://github.com/apache/phoenix-omid/pull/146 BUILD was SUCCESS! > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > |os.plugin.version|1.6.2|1.7.1| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-255) Upgrade guava to 32.1.3-jre
[ https://issues.apache.org/jira/browse/OMID-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1956#comment-1956 ] ASF GitHub Bot commented on OMID-255: - NihalJain commented on PR #144: URL: https://github.com/apache/phoenix-omid/pull/144#issuecomment-1773338468 Ran following command with a consolidated change of 4 PRs locally: mvn clean verify site -Dspotbugs.site -Dhbase.version=2.5.5-hadoop3 -Dsurefire.rerunFailingTestsCount=3 PR list: - https://github.com/apache/phoenix-omid/pull/143 - https://github.com/apache/phoenix-omid/pull/144 - https://github.com/apache/phoenix-omid/pull/145 - https://github.com/apache/phoenix-omid/pull/146 BUILD was SUCCESS! > Upgrade guava to 32.1.3-jre > --- > > Key: OMID-255 > URL: https://issues.apache.org/jira/browse/OMID-255 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-253) Upgrade Netty to 4.1.100.Final
[ https://issues.apache.org/jira/browse/OMID-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1955#comment-1955 ] ASF GitHub Bot commented on OMID-253: - NihalJain commented on PR #143: URL: https://github.com/apache/phoenix-omid/pull/143#issuecomment-1773336828 Ran following command with a consolidated change of 4 PRs locally: mvn clean verify site -Dspotbugs.site -Dhbase.version=2.5.5-hadoop3 -Dsurefire.rerunFailingTestsCount=3 PR list: - https://github.com/apache/phoenix-omid/pull/143 - https://github.com/apache/phoenix-omid/pull/144 - https://github.com/apache/phoenix-omid/pull/145 - https://github.com/apache/phoenix-omid/pull/146 Build result was SUCCESS! > Upgrade Netty to 4.1.100.Final > -- > > Key: OMID-253 > URL: https://issues.apache.org/jira/browse/OMID-253 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > Netty 4.1.86.Final has > [CVE-2023-34462|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34462] > which has been fixed in version > 4.1.94.Final. > This Jira is to bump to 4.1.100.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1947#comment-1947
]
ASF GitHub Bot commented on OMID-264:
-
NihalJain commented on PR #147:
URL: https://github.com/apache/phoenix-omid/pull/147#issuecomment-1773321202
Ensured warning is no longer shown during build.
Tested by first introducing as license error by deleting header from one of
existing java file and then running mvn license:check both with/without change,
failing as expected.
Next ran mvn license:format to fix header issue.
CC: @stoty
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-264) Fix deprecated WARNING in check-license stage
[
https://issues.apache.org/jira/browse/OMID-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1944#comment-1944
]
ASF GitHub Bot commented on OMID-264:
-
NihalJain opened a new pull request, #147:
URL: https://github.com/apache/phoenix-omid/pull/147
(no comment)
> Fix deprecated WARNING in check-license stage
> --
>
> Key: OMID-264
> URL: https://issues.apache.org/jira/browse/OMID-264
> Project: Phoenix Omid
> Issue Type: Improvement
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Minor
>
> Post OMID-251 bump, we are getting deprecated WARNING in build.
> {code:java}
> [INFO] --- license:4.3:check (check-license) @ omid-hbase-tools ---
> [WARNING] Parameter 'legacyConfigExcludes' (user property
> 'license.excludes') is deprecated: use LicenseSet.excludes
> [WARNING] Parameter 'legacyConfigHeader' (user property 'license.header') is
> deprecated: use LicenseSet.header
> [WARNING] Parameter 'legacyConfigIncludes' (user property
> 'license.includes') is deprecated: use LicenseSet.includes
> [INFO] Checking licenses...
> {code}
> This JIRA is to fix/remove usage of deprecated property.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-257) Upgrade bouncycastle and move from jdk15on to latest jdk18on
[ https://issues.apache.org/jira/browse/OMID-257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1926#comment-1926 ] ASF GitHub Bot commented on OMID-257: - NihalJain opened a new pull request, #146: URL: https://github.com/apache/phoenix-omid/pull/146 (no comment) > Upgrade bouncycastle and move from jdk15on to latest jdk18on > > > Key: OMID-257 > URL: https://issues.apache.org/jira/browse/OMID-257 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-256) Bump hbase and other dependencies to latest version
[ https://issues.apache.org/jira/browse/OMID-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1908#comment-1908 ] ASF GitHub Bot commented on OMID-256: - NihalJain opened a new pull request, #145: URL: https://github.com/apache/phoenix-omid/pull/145 (no comment) > Bump hbase and other dependencies to latest version > --- > > Key: OMID-256 > URL: https://issues.apache.org/jira/browse/OMID-256 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Assignee: Nihal Jain >Priority: Major > > This Jira will bump following: > |*Property*|*From*|*To*| > |hbase.version|2.4.13|2.4.17| > |log4j2.version|2.18.0|2.21.0| > |junit.version|4.13.1|4.13.2| > |commons-lang3.version|3.12.0|3.13.0| > |os.plugin.version|1.6.2|1.7.1| > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-255) Upgrade guava to 32.1.3-jre
[ https://issues.apache.org/jira/browse/OMID-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1897#comment-1897 ] ASF GitHub Bot commented on OMID-255: - NihalJain opened a new pull request, #144: URL: https://github.com/apache/phoenix-omid/pull/144 (no comment) > Upgrade guava to 32.1.3-jre > --- > > Key: OMID-255 > URL: https://issues.apache.org/jira/browse/OMID-255 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-253) Upgrade Netty to 4.1.100.Final
[ https://issues.apache.org/jira/browse/OMID-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1894#comment-1894 ] ASF GitHub Bot commented on OMID-253: - NihalJain opened a new pull request, #143: URL: https://github.com/apache/phoenix-omid/pull/143 (no comment) > Upgrade Netty to 4.1.100.Final > -- > > Key: OMID-253 > URL: https://issues.apache.org/jira/browse/OMID-253 > Project: Phoenix Omid > Issue Type: Sub-task >Reporter: Nihal Jain >Priority: Major > > Netty 4.1.86.Final has > [CVE-2023-34462|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-34462] > which has been fixed in version > 4.1.94.Final. > This Jira is to bump to 4.1.100.Final -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-251) Bump license-maven-plugin to latest version
[
https://issues.apache.org/jira/browse/OMID-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1012#comment-1012
]
ASF GitHub Bot commented on OMID-251:
-
chrajeshbabu merged PR #142:
URL: https://github.com/apache/phoenix-omid/pull/142
> Bump license-maven-plugin to latest version
> ---
>
> Key: OMID-251
> URL: https://issues.apache.org/jira/browse/OMID-251
> Project: Phoenix Omid
> Issue Type: Task
>Reporter: Nihal Jain
>Assignee: Nihal Jain
>Priority: Major
> Fix For: 1.1.1
>
> Attachments: out_v2.11.txt, out_v4.3.txt
>
>
> In phoenix-omid pom.xml, {{maven-license-plugin.version}} is set to
> {{{}2.11{}}}, which was last updated 5 years ago. The plugin
> {{com.mycila:license-maven-plugin}} pulls log4j-1.2.x jar.
> See sample from run of {{mvn license:check}} with {{2.11}} is as follows:
> {code:java}
> Downloading from central:
> [https://repo.maven.apache.org/maven2/log4j/log4j/1.2.12/log4j-1.2.12.jar]
> {code}
> In my org, when trying to build phoenix-omid, build fails as
> {{log4j:logj:1.2.x}} is strictly banned in interanl artifactory.
> The goal of this JIRA is to bump the afore-mentioned plugin to latest
> version, i.e.
> [4.3|https://mvnrepository.com/artifact/com.mycila/license-maven-plugin],
> which does not pull the log4j:log4j jar.
> Full run log, for reference, of {{mvn license:check}} command after clearning
> \{{~/.m2/reposiitory} with version:
> * {{{}2.11{}}}: [^out_v2.11.txt], which pulls {{log4j-1.2.x}} jar.
> * {{{}4.3{}}}: [^out_v4.3.txt], which does not pull {{log4j-1.2.x}} jar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-251) Bump license-maven-plugin to latest version
[
https://issues.apache.org/jira/browse/OMID-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776870#comment-17776870
]
ASF GitHub Bot commented on OMID-251:
-
NihalJain commented on PR #142:
URL: https://github.com/apache/phoenix-omid/pull/142#issuecomment-1769194056
Tested by first introducing as license error by deleting header from one of
existing java file and then running `mvn license:check` both with/without
change. Build failed in both cases as expected.
> Bump license-maven-plugin to latest version
> ---
>
> Key: OMID-251
> URL: https://issues.apache.org/jira/browse/OMID-251
> Project: Phoenix Omid
> Issue Type: Task
>Reporter: Nihal Jain
>Priority: Major
> Attachments: out_v2.11.txt, out_v4.3.txt
>
>
> In phoenix-omid pom.xml, {{maven-license-plugin.version}} is set to {{2.11}},
> which was last updated 5 years ago. The plugin
> {{com.mycila:license-maven-plugin}} pulls log4j-1.2.x jar.
> See sample from run of {{mvn license:check}} with {{2.11}} is as follows:
> {code:java}
> Downloading from central:
> [https://repo.maven.apache.org/maven2/log4j/log4j/1.2.12/log4j-1.2.12.jar]
> {code}
> In my org, when trying to build phoenix-omid, build fails as
> {{log4j:logj:1.2.x}} is strictly banned in interanl artifactory.
> The goal of this JIRA is to bump the afore-mentioned mentioned plugin to
> latest version, i.e.
> [4.3|https://mvnrepository.com/artifact/com.mycila/license-maven-plugin],
> which does not pull the log4j:log4j jar.
> Full run log of {{mvn license:check}} command after clearning
> \{{~/.m2/reposiitory} with
> * {{2.11}}: [^out_v2.11.txt], which pulls {{log4j-1.2.x}} jar.
> * {{4.3}}: [^out_v4.3.txt], which does not pull {{log4j-1.2.x}} jar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-251) Bump license-maven-plugin to latest version
[
https://issues.apache.org/jira/browse/OMID-251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776867#comment-17776867
]
ASF GitHub Bot commented on OMID-251:
-
NihalJain opened a new pull request, #142:
URL: https://github.com/apache/phoenix-omid/pull/142
(no comment)
> Bump license-maven-plugin to latest version
> ---
>
> Key: OMID-251
> URL: https://issues.apache.org/jira/browse/OMID-251
> Project: Phoenix Omid
> Issue Type: Task
>Reporter: Nihal Jain
>Priority: Major
> Attachments: out_v2.11.txt, out_v4.3.txt
>
>
> In phoenix-omid pom.xml, {{maven-license-plugin.version}} is set to {{2.11}},
> which was last updated 5 years ago. The plugin
> {{com.mycila:license-maven-plugin}} pulls log4j-1.2.x jar.
> See sample from run of {{mvn license:check}} with {{2.11}} is as follows:
> {code:java}
> Downloading from central:
> [https://repo.maven.apache.org/maven2/log4j/log4j/1.2.12/log4j-1.2.12.jar]
> {code}
> In my org, when trying to build phoenix-omid, build fails as
> {{log4j:logj:1.2.x}} is strictly banned in interanl artifactory.
> The goal of this JIRA is to bump the afore-mentioned mentioned plugin to
> latest version, i.e.
> [4.3|https://mvnrepository.com/artifact/com.mycila/license-maven-plugin],
> which does not pull the log4j:log4j jar.
> Full run log of {{mvn license:check}} command after clearning
> \{{~/.m2/reposiitory} with
> * {{2.11}}: [^out_v2.11.txt], which pulls {{log4j-1.2.x}} jar.
> * {{4.3}}: [^out_v4.3.txt], which does not pull {{log4j-1.2.x}} jar.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-248) Transactional Phoenix tests fail on Java 17 in getDefaultNetworkInterface
[
https://issues.apache.org/jira/browse/OMID-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767912#comment-17767912
]
ASF GitHub Bot commented on OMID-248:
-
stoty closed pull request #141: OMID-248 Transactional Phoenix tests fail on
Java 17 in getDefaultNet…
URL: https://github.com/apache/phoenix-omid/pull/141
> Transactional Phoenix tests fail on Java 17 in getDefaultNetworkInterface
> --
>
> Key: OMID-248
> URL: https://issues.apache.org/jira/browse/OMID-248
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> When running the Phoenix test suite with JDK 17, we get errors like
> {noformat}
> [ERROR]
> org.apache.phoenix.end2end.TransactionalViewIT.testInvalidRowsWithStats[TransactionalViewIT_transactionProvider=OMID]
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.IllegalArgumentException: No network 'en*'/'eth*' interfaces found
> at
> org.apache.omid.NetworkUtils.getDefaultNetworkInterface(NetworkUtils.java:68)
> at org.apache.omid.tso.TSOServerConfig.(TSOServerConfig.java:88)
> at org.apache.omid.tso.TSOServerConfig.(TSOServerConfig.java:56)
> at
> org.apache.phoenix.transaction.OmidTransactionService.startAndInjectOmidTransactionService(OmidTransactionService.java:62)
> at
> org.apache.phoenix.transaction.TransactionServiceManager.startTransactionService(TransactionServiceManager.java:33)
> at
> org.apache.phoenix.end2end.ConnectionQueryServicesTestImpl.initTransactionClient(ConnectionQueryServicesTestImpl.java:120)
> at
> org.apache.phoenix.transaction.OmidTransactionContext.(OmidTransactionContext.java:60)
> at
> org.apache.phoenix.transaction.OmidTransactionProvider.getTransactionContext(OmidTransactionProvider.java:65)
> at
> org.apache.phoenix.execute.MutationState.startTransaction(MutationState.java:408)
> at
> org.apache.phoenix.util.TransactionUtil.getTableTimestamp(TransactionUtil.java:124)
> at
> org.apache.phoenix.schema.MetaDataClient.createTableInternal(MetaDataClient.java:2307)
> at
> org.apache.phoenix.schema.MetaDataClient.createTable(MetaDataClient.java:1023)
> at
> org.apache.phoenix.compile.CreateTableCompiler$CreateTableMutationPlan.execute(CreateTableCompiler.java:421)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:559)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:525)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:524)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:512)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:2206)
> at
> org.apache.phoenix.end2end.TransactionalViewIT.testInvalidRowsWithStats(TransactionalViewIT.java:108)
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-237) TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable fails
[
https://issues.apache.org/jira/browse/OMID-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767911#comment-17767911
]
ASF GitHub Bot commented on OMID-237:
-
stoty closed pull request #140: OMID-237
TestHBaseTransactionClient.testReadCommitTimestampFromCommit…
URL: https://github.com/apache/phoenix-omid/pull/140
> TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable fails
> ---
>
> Key: OMID-237
> URL: https://issues.apache.org/jira/browse/OMID-237
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> On my machine,
> TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable failed in 3
> out of 3 runs.
> {noformat}
> [ERROR] Tests run: 95, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 341.56 s <<< FAILURE! - in TestSuite
> [ERROR]
> testReadCommitTimestampFromCommitTable(org.apache.omid.transaction.TestHBaseTransactionClient)
> Time elapsed: 0.025 s <<< FAILURE!
> java.lang.AssertionError: expected [false] but found [true]
> at org.testng.Assert.fail(Assert.java:94)
> at org.testng.Assert.failNotEquals(Assert.java:513)
> at org.testng.Assert.assertFalse(Assert.java:63)
> at org.testng.Assert.assertFalse(Assert.java:73)
> at
> org.apache.omid.transaction.TestHBaseTransactionClient.testReadCommitTimestampFromCommitTable(TestHBaseTransactionClient.java:144)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
> at
> org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:54)
> at
> org.testng.internal.InvokeMethodRunnable.run(InvokeMethodRunnable.java:44)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> at java.base/java.lang.Thread.run(Thread.java:829){noformat}
> I don't see this failure on the CI, so this is possibly a timing issue
> related to the host performance (or maybe the CI tests are just failing
> earlier)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-248) Transactional Phoenix tests fail on Java 17 in getDefaultNetworkInterface
[
https://issues.apache.org/jira/browse/OMID-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17767384#comment-17767384
]
ASF GitHub Bot commented on OMID-248:
-
stoty opened a new pull request, #141:
URL: https://github.com/apache/phoenix-omid/pull/141
…workInterface
> Transactional Phoenix tests fail on Java 17 in getDefaultNetworkInterface
> --
>
> Key: OMID-248
> URL: https://issues.apache.org/jira/browse/OMID-248
> Project: Phoenix Omid
> Issue Type: Bug
>Affects Versions: 1.1.0
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Major
>
> When running the Phoenix test suite with JDK 17, we get errors like
> {noformat}
> [ERROR]
> org.apache.phoenix.end2end.TransactionalViewIT.testInvalidRowsWithStats[TransactionalViewIT_transactionProvider=OMID]
> Time elapsed: 0.001 s <<< ERROR!
> java.lang.IllegalArgumentException: No network 'en*'/'eth*' interfaces found
> at
> org.apache.omid.NetworkUtils.getDefaultNetworkInterface(NetworkUtils.java:68)
> at org.apache.omid.tso.TSOServerConfig.(TSOServerConfig.java:88)
> at org.apache.omid.tso.TSOServerConfig.(TSOServerConfig.java:56)
> at
> org.apache.phoenix.transaction.OmidTransactionService.startAndInjectOmidTransactionService(OmidTransactionService.java:62)
> at
> org.apache.phoenix.transaction.TransactionServiceManager.startTransactionService(TransactionServiceManager.java:33)
> at
> org.apache.phoenix.end2end.ConnectionQueryServicesTestImpl.initTransactionClient(ConnectionQueryServicesTestImpl.java:120)
> at
> org.apache.phoenix.transaction.OmidTransactionContext.(OmidTransactionContext.java:60)
> at
> org.apache.phoenix.transaction.OmidTransactionProvider.getTransactionContext(OmidTransactionProvider.java:65)
> at
> org.apache.phoenix.execute.MutationState.startTransaction(MutationState.java:408)
> at
> org.apache.phoenix.util.TransactionUtil.getTableTimestamp(TransactionUtil.java:124)
> at
> org.apache.phoenix.schema.MetaDataClient.createTableInternal(MetaDataClient.java:2307)
> at
> org.apache.phoenix.schema.MetaDataClient.createTable(MetaDataClient.java:1023)
> at
> org.apache.phoenix.compile.CreateTableCompiler$CreateTableMutationPlan.execute(CreateTableCompiler.java:421)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:559)
> at
> org.apache.phoenix.jdbc.PhoenixStatement$2.call(PhoenixStatement.java:525)
> at org.apache.phoenix.call.CallRunner.run(CallRunner.java:53)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:524)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.executeMutation(PhoenixStatement.java:512)
> at
> org.apache.phoenix.jdbc.PhoenixStatement.execute(PhoenixStatement.java:2206)
> at
> org.apache.phoenix.end2end.TransactionalViewIT.testInvalidRowsWithStats(TransactionalViewIT.java:108)
> ...
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-247) Change TSO default port to be outside the ephemeral range
[
https://issues.apache.org/jira/browse/OMID-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759440#comment-17759440
]
ASF GitHub Bot commented on OMID-247:
-
stoty closed pull request #139: OMID-247 Change TSO default port to be outside
the ephemeral range
URL: https://github.com/apache/phoenix-omid/pull/139
> Change TSO default port to be outside the ephemeral range
> -
>
> Key: OMID-247
> URL: https://issues.apache.org/jira/browse/OMID-247
> Project: Phoenix Omid
> Issue Type: Bug
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Critical
> Fix For: 1.1.1
>
>
> The default TSO port, 54758 is in the epehemeral port range of every OS.
> This can cause TSO server to randomly error out on startup with an error
> similar to the following:
> {noformat}
> Exception in thread "Thread-5" java.lang.IllegalStateException: Expected the
> service TSOServer [FAILED] to be TERMINATED, but the service has FAILED
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:366)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractService.awaitTerminated(AbstractService.java:329)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractIdleService.awaitTerminated(AbstractIdleService.java:175)
> at org.apache.omid.tso.TSOServer$2.run(TSOServer.java:137)
> Caused by: org.apache.omid.tso.LeaseManagement$LeaseManagementException:
> Error initializing Lease Manager
> at
> org.apache.omid.tso.VoidLeaseManager.startService(VoidLeaseManager.java:38)
> at org.apache.omid.tso.TSOServer.startUp(TSOServer.java:102)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractIdleService$DelegateService$1.run(AbstractIdleService.java:60)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.Callables$4.run(Callables.java:119)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> at sun.nio.ch.Net.bind(Net.java:433)
> at sun.nio.ch.Net.bind(Net.java:425)
> at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
> at
> io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
> at
> io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
> at
> io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)
> at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248)
> at
> io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356)
> at
> io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
> at
> io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> ... 1 more{noformat}
> The only way to fix this is to change the default port number to be outside
> the ephemeral range.
> Anything under 32K seems to be safe.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-247) Change TSO default port to be outside the ephemeral range
[
https://issues.apache.org/jira/browse/OMID-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17756661#comment-17756661
]
ASF GitHub Bot commented on OMID-247:
-
stoty opened a new pull request, #139:
URL: https://github.com/apache/phoenix-omid/pull/139
(no comment)
> Change TSO default port to be outside the ephemeral range
> -
>
> Key: OMID-247
> URL: https://issues.apache.org/jira/browse/OMID-247
> Project: Phoenix Omid
> Issue Type: Bug
>Reporter: Istvan Toth
>Assignee: Istvan Toth
>Priority: Critical
>
> The default TSO port, 54758 is in the epehemeral port range of every OS.
> This can cause TSO server to randomly error out on startup with an error
> similar to the following:
> {noformat}
> Exception in thread "Thread-5" java.lang.IllegalStateException: Expected the
> service TSOServer [FAILED] to be TERMINATED, but the service has FAILED
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractService.checkCurrentState(AbstractService.java:366)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractService.awaitTerminated(AbstractService.java:329)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractIdleService.awaitTerminated(AbstractIdleService.java:175)
> at org.apache.omid.tso.TSOServer$2.run(TSOServer.java:137)
> Caused by: org.apache.omid.tso.LeaseManagement$LeaseManagementException:
> Error initializing Lease Manager
> at
> org.apache.omid.tso.VoidLeaseManager.startService(VoidLeaseManager.java:38)
> at org.apache.omid.tso.TSOServer.startUp(TSOServer.java:102)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.AbstractIdleService$DelegateService$1.run(AbstractIdleService.java:60)
> at
> org.apache.phoenix.thirdparty.com.google.common.util.concurrent.Callables$4.run(Callables.java:119)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.net.BindException: Address already in use
> at sun.nio.ch.Net.bind0(Native Method)
> at sun.nio.ch.Net.bind(Net.java:433)
> at sun.nio.ch.Net.bind(Net.java:425)
> at
> sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:223)
> at
> io.netty.channel.socket.nio.NioServerSocketChannel.doBind(NioServerSocketChannel.java:134)
> at
> io.netty.channel.AbstractChannel$AbstractUnsafe.bind(AbstractChannel.java:550)
> at
> io.netty.channel.DefaultChannelPipeline$HeadContext.bind(DefaultChannelPipeline.java:1334)
> at
> io.netty.channel.AbstractChannelHandlerContext.invokeBind(AbstractChannelHandlerContext.java:506)
> at
> io.netty.channel.AbstractChannelHandlerContext.bind(AbstractChannelHandlerContext.java:491)
> at
> io.netty.channel.DefaultChannelPipeline.bind(DefaultChannelPipeline.java:973)
> at io.netty.channel.AbstractChannel.bind(AbstractChannel.java:248)
> at
> io.netty.bootstrap.AbstractBootstrap$2.run(AbstractBootstrap.java:356)
> at
> io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
> at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500)
> at
> io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
> at
> io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
> ... 1 more{noformat}
> The only way to fix this is to change the default port number to be outside
> the ephemeral range.
> Anything under 32K seems to be safe.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OMID-246) Update Surefire plugin to 3.0.0 and switch to TCP forkNode implementation
[ https://issues.apache.org/jira/browse/OMID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17752465#comment-17752465 ] ASF GitHub Bot commented on OMID-246: - stoty closed pull request #138: OMID-246 Update Surefire plugin to 3.0.0 and switch to TCP forkNo… URL: https://github.com/apache/phoenix-omid/pull/138 > Update Surefire plugin to 3.0.0 and switch to TCP forkNode implementation > - > > Key: OMID-246 > URL: https://issues.apache.org/jira/browse/OMID-246 > Project: Phoenix Omid > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-246) Update Surefire plugin to 3.0.0 and switch to TCP forkNode implementation
[ https://issues.apache.org/jira/browse/OMID-246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17751516#comment-17751516 ] ASF GitHub Bot commented on OMID-246: - stoty commented on PR #138: URL: https://github.com/apache/phoenix-omid/pull/138#issuecomment-1667379871 Fixed JIRA ID > Update Surefire plugin to 3.0.0 and switch to TCP forkNode implementation > - > > Key: OMID-246 > URL: https://issues.apache.org/jira/browse/OMID-246 > Project: Phoenix Omid > Issue Type: Bug >Reporter: Istvan Toth >Assignee: Istvan Toth >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-245) Add dependency management for Guava to use 32.1.1
[ https://issues.apache.org/jira/browse/OMID-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742695#comment-17742695 ] ASF GitHub Bot commented on OMID-245: - richardantal merged PR #137: URL: https://github.com/apache/phoenix-omid/pull/137 > Add dependency management for Guava to use 32.1.1 > - > > Key: OMID-245 > URL: https://issues.apache.org/jira/browse/OMID-245 > Project: Phoenix Omid > Issue Type: Task >Affects Versions: 1.1.0 >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-245) Add dependency management for Guava to use 32.1.1
[ https://issues.apache.org/jira/browse/OMID-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742693#comment-17742693 ] ASF GitHub Bot commented on OMID-245: - richardantal commented on PR #137: URL: https://github.com/apache/phoenix-omid/pull/137#issuecomment-1633762127 Thank you Istvan for the review tests are OK apart from a known flaky one. > Add dependency management for Guava to use 32.1.1 > - > > Key: OMID-245 > URL: https://issues.apache.org/jira/browse/OMID-245 > Project: Phoenix Omid > Issue Type: Task >Affects Versions: 1.1.0 >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-245) Add dependency management for Guava to use 32.1.1
[ https://issues.apache.org/jira/browse/OMID-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741654#comment-17741654 ] ASF GitHub Bot commented on OMID-245: - richardantal opened a new pull request, #137: URL: https://github.com/apache/phoenix-omid/pull/137 (no comment) > Add dependency management for Guava to use 32.1.1 > - > > Key: OMID-245 > URL: https://issues.apache.org/jira/browse/OMID-245 > Project: Phoenix Omid > Issue Type: Task >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-244) Upgrade SnakeYaml version to 2.0
[ https://issues.apache.org/jira/browse/OMID-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17738001#comment-17738001 ] ASF GitHub Bot commented on OMID-244: - richardantal commented on PR #136: URL: https://github.com/apache/phoenix-omid/pull/136#issuecomment-1610931343 Thank you Ankit for the review. > Upgrade SnakeYaml version to 2.0 > > > Key: OMID-244 > URL: https://issues.apache.org/jira/browse/OMID-244 > Project: Phoenix Omid > Issue Type: Task >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > Fix For: 1.1.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-244) Upgrade SnakeYaml version to 2.0
[ https://issues.apache.org/jira/browse/OMID-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737997#comment-17737997 ] ASF GitHub Bot commented on OMID-244: - richardantal merged PR #136: URL: https://github.com/apache/phoenix-omid/pull/136 > Upgrade SnakeYaml version to 2.0 > > > Key: OMID-244 > URL: https://issues.apache.org/jira/browse/OMID-244 > Project: Phoenix Omid > Issue Type: Task >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-244) Upgrade SnakeYaml version to 2.0
[ https://issues.apache.org/jira/browse/OMID-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737093#comment-17737093 ] ASF GitHub Bot commented on OMID-244: - richardantal closed pull request #135: OMID-244 Upgrade SnakeYaml version to 2.0 URL: https://github.com/apache/phoenix-omid/pull/135 > Upgrade SnakeYaml version to 2.0 > > > Key: OMID-244 > URL: https://issues.apache.org/jira/browse/OMID-244 > Project: Phoenix Omid > Issue Type: Task >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OMID-244) Upgrade SnakeYaml version to 2.0
[ https://issues.apache.org/jira/browse/OMID-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17737092#comment-17737092 ] ASF GitHub Bot commented on OMID-244: - richardantal commented on PR #135: URL: https://github.com/apache/phoenix-omid/pull/135#issuecomment-1607199794 CLosing this and will go with https://github.com/apache/phoenix-omid/pull/136 instead > Upgrade SnakeYaml version to 2.0 > > > Key: OMID-244 > URL: https://issues.apache.org/jira/browse/OMID-244 > Project: Phoenix Omid > Issue Type: Task >Reporter: Richárd Antal >Assignee: Richárd Antal >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
