[jira] [Commented] (PHOENIX-2896) Support encoded column qualifiers per column family

2018-05-24 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488565#comment-16488565 ] Samarth Jain commented on PHOENIX-2896: --- [~tdsilva] - I am not sure I understood your question. We

[jira] [Commented] (PHOENIX-4701) Improve schema of SYSTEM.LOG table

2018-04-24 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451462#comment-16451462 ] Samarth Jain commented on PHOENIX-4701: --- I haven't closely looked at the original commit

[jira] [Commented] (PHOENIX-4366) Rebuilding a local index fails sometimes

2018-04-10 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432792#comment-16432792 ] Samarth Jain commented on PHOENIX-4366: --- Ah, I see! Thanks for the explanation, [~sergey.soldatov

[jira] [Commented] (PHOENIX-4366) Rebuilding a local index fails sometimes

2018-04-09 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431669#comment-16431669 ] Samarth Jain commented on PHOENIX-4366: --- I was motivated by just getting hold of the column

Re: [DISCUSS] Design for a "query log"

2018-03-02 Thread Samarth Jain
A couple more points which I think you alluded to, Josh, but I would still like to call out: 1) Writing of these query logs to a phoenix table should be best effort i.e. a query definitely shouldn't fail because we encountered an issue while writing its log 2) Writing of query logs should happen

[jira] [Commented] (PHOENIX-4625) memory leak in PhoenixConnection if scanner renew lease thread is not enabled

2018-02-21 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372463#comment-16372463 ] Samarth Jain commented on PHOENIX-4625: --- +1 > memory leak in PhoenixConnection if scanner re

Re: [VOTE] Release of Apache Phoenix 4.13.2 for CDH 5.11.2 RC0

2018-01-16 Thread Samarth Jain
+1. Ran unit tests successfully. Executed some manual tests around secondary indexes and stats collection - looks fine. On Sat, Jan 13, 2018 at 3:30 AM, Pedro Boado wrote: > Hello Everyone, > > This is a call for a vote on Apache Phoenix 4.13.2 for CDH 5.11.2 RC0. This >

[jira] [Updated] (PHOENIX-4397) Incorrect query results when with stats are disabled on a salted table

2017-12-08 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4397: -- Attachment: PHOENIX-4397_v2.patch Patch that fixes the issue along with tests. [~jamestaylor

[jira] [Commented] (PHOENIX-4371) Document explain plan and how we expose estimate information in it

2017-11-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16273863#comment-16273863 ] Samarth Jain commented on PHOENIX-4371: --- Committed the patch after addressing the review comments

[jira] [Resolved] (PHOENIX-4371) Document explain plan and how we expose estimate information in it

2017-11-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain resolved PHOENIX-4371. --- Resolution: Fixed > Document explain plan and how we expose estimate informat

[jira] [Commented] (PHOENIX-4395) Illegal data. Expected length of at least 49 bytes, but had 4 (state=22000,code=201)

2017-11-20 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16259575#comment-16259575 ] Samarth Jain commented on PHOENIX-4395: --- [~gjacoby] - this error doesn't have to do with column

[jira] [Commented] (PHOENIX-4319) Zookeeper connection should be closed immediately

2017-11-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258245#comment-16258245 ] Samarth Jain commented on PHOENIX-4319: --- Can you try with 4.13? > Zookeeper connection sho

[jira] [Commented] (PHOENIX-4360) Prevent System.Catalog from splitting

2017-11-17 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16257684#comment-16257684 ] Samarth Jain commented on PHOENIX-4360: --- [~lhofhansl] - would be good to also have a test

[jira] [Commented] (PHOENIX-4369) ArrayIndexOutOfBounds when upserting to table using ROW_TIMESTAMP

2017-11-17 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16256713#comment-16256713 ] Samarth Jain commented on PHOENIX-4369: --- Looked at it briefly. Looks like an issue when

[jira] [Updated] (PHOENIX-4371) Document explain plan and how we expose estimate information in it

2017-11-10 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4371: -- Attachment: explainplan.md [~jamestaylor], please review. I also removed the explain plan

[jira] [Created] (PHOENIX-4371) Document explain plan and how we expose estimate information in it

2017-11-10 Thread Samarth Jain (JIRA)
Samarth Jain created PHOENIX-4371: - Summary: Document explain plan and how we expose estimate information in it Key: PHOENIX-4371 URL: https://issues.apache.org/jira/browse/PHOENIX-4371 Project

Re: [VOTE] Release of Apache Phoenix 4.13.0 RC1

2017-11-09 Thread Samarth Jain
+1 Successfully ran all unit tests. Verified recent changes and bug fixes around stats collection and reporting. On Thu, Nov 9, 2017 at 5:02 PM, James Taylor wrote: > +1. Verified bug fixes around delete. > > On Thu, Nov 9, 2017 at 10:21 AM, Mujtaba Chohan

[jira] [Commented] (PHOENIX-4358) Case Sensitive String match on SqlType in PDataType

2017-11-09 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246418#comment-16246418 ] Samarth Jain commented on PHOENIX-4358: --- Patch looks fine to me, [~dangulo]. Please add a test

Re: [VOTE] Release of Apache Phoenix 4.13.0 RC1

2017-11-07 Thread Samarth Jain
+1 On Tue, Nov 7, 2017 at 12:06 PM, Andrew Purtell wrote: > My bad. Ignore my -1. Somehow the bin downloads failed. Let me try again. > > > On Tue, Nov 7, 2017 at 12:05 PM, Andrew Purtell > wrote: > > > -1 > > > > Signature verification fails > > > > $

[jira] [Commented] (PHOENIX-4348) Point deletes do not work when there are immutable indexes with only row key columns

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16237067#comment-16237067 ] Samarth Jain commented on PHOENIX-4348: --- +1 > Point deletes do not work when there are immuta

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236904#comment-16236904 ] Samarth Jain commented on PHOENIX-4287: --- Thanks. I added the comment in my commit. > Incorr

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum7.patch Looks like an NPE happens when dropping local

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum6.patch Updated patch with additional test on view and view

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum5.patch Thanks for the code snippet, [~jamestaylor

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236580#comment-16236580 ] Samarth Jain commented on PHOENIX-4287: --- Yes, that's correct. Will change the patch to fetch

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236544#comment-16236544 ] Samarth Jain commented on PHOENIX-4287: --- USE_STATS_FOR_PARALLELIZATION can be set at an index/view

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236538#comment-16236538 ] Samarth Jain commented on PHOENIX-4287: --- Just got back. Taking a look. > Incorrect aggreg

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235303#comment-16235303 ] Samarth Jain commented on PHOENIX-4333: --- Is it a safe assumption to make that if intersectScan

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235294#comment-16235294 ] Samarth Jain commented on PHOENIX-4333: --- Good point, [~jamestaylor]. I don't think my check would

[jira] [Updated] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4333: -- Attachment: PHOENIX-4333_v2.patch > Stats - Incorrect estimate when stats are upda

[jira] [Updated] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4333: -- Attachment: PHOENIX-4333_v2.patch Updated patch that sets estimate timestamp to null when we

[jira] [Updated] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4333: -- Attachment: (was: PHOENIX-4333_v2.patch) > Stats - Incorrect estimate when st

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235262#comment-16235262 ] Samarth Jain commented on PHOENIX-4333: --- Actually, the check needs to be done inside this catch

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235253#comment-16235253 ] Samarth Jain commented on PHOENIX-4333: --- Ah, I see. Yes, that's true. Let me update the patch

[jira] [Updated] (PHOENIX-4332) Indexes should inherit guide post width of the base data table

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4332: -- Summary: Indexes should inherit guide post width of the base data table (was: Stats - Allow

[jira] [Updated] (PHOENIX-4343) In CREATE TABLE allow setting guide post width only on base data tables

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4343: -- Summary: In CREATE TABLE allow setting guide post width only on base data tables

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235245#comment-16235245 ] Samarth Jain commented on PHOENIX-4333: --- It might be a late night and lack of coffee but I am

[jira] [Updated] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-02 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4343: -- Attachment: PHOENIX-4343_v3.patch Thanks for the review, [~jamestaylor]. Attached

[jira] [Updated] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4333: -- Attachment: PHOENIX-4333_v1.patch With this patch, we now detect that if we don't have stats

[jira] [Updated] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4343: -- Attachment: PHOENIX-4343_v2.patch Updated patch. [~jamestaylor], please review. > In CRE

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235158#comment-16235158 ] Samarth Jain commented on PHOENIX-4343: --- With PHOENIX-4332 indexes now inherit the guide post

[jira] [Commented] (PHOENIX-4332) Stats - Allow setting guide post width on global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235145#comment-16235145 ] Samarth Jain commented on PHOENIX-4332: --- Instead of supporting ALTER TABLE or ALTER INDEX to set

[jira] [Updated] (PHOENIX-4332) Stats - Allow setting guide post width on global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4332: -- Attachment: PHOENIX-4332.patch [~jamestaylor], please review. > Stats - Allow setting gu

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum4.patch > Incorrect aggregate query results when st

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: (was: PHOENIX-4287_addendum4.patch) > Incorrect aggregate query results w

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum4.patch Updated patch with more tests including fix

[jira] [Reopened] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain reopened PHOENIX-4287: --- > Incorrect aggregate query results when stats are disable for parallelizat

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum3.patch Good catch, [~jamestaylor]. I have added a test

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum2.patch Thanks for the reviews, [~jamestaylor]. Updated

[jira] [Commented] (PHOENIX-4332) Stats - Altering guidepost width on base table does not propagate to global index

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234835#comment-16234835 ] Samarth Jain commented on PHOENIX-4332: --- View indexes and local indexes use the guide post width

[jira] [Updated] (PHOENIX-4332) Stats - Allow setting guide post width on global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4332: -- Summary: Stats - Allow setting guide post width on global indexes (was: Stats - Altering

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_addendum.patch Patch that fixes the issue. We need to set the config

[jira] [Updated] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4343: -- Attachment: PHOENIX-4343.patch > In CREATE TABLE only allow setting guide post wi

[jira] [Commented] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234774#comment-16234774 ] Samarth Jain commented on PHOENIX-4343: --- [~jamestaylor], please review. > In CREATE TABLE o

[jira] [Created] (PHOENIX-4343) In CREATE TABLE only allow setting guide post width on tables and global indexes

2017-11-01 Thread Samarth Jain (JIRA)
Samarth Jain created PHOENIX-4343: - Summary: In CREATE TABLE only allow setting guide post width on tables and global indexes Key: PHOENIX-4343 URL: https://issues.apache.org/jira/browse/PHOENIX-4343

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234620#comment-16234620 ] Samarth Jain commented on PHOENIX-4287: --- OK, thanks. Looks like we are hitting a similar issue

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234587#comment-16234587 ] Samarth Jain commented on PHOENIX-4287: --- [~mujtabachohan] - What kind of query are you running

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16234412#comment-16234412 ] Samarth Jain commented on PHOENIX-4335: --- +1 > System catalog snapshot created each time a

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-11-01 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16233715#comment-16233715 ] Samarth Jain commented on PHOENIX-4335: --- Patch looks good, [~jamestaylor]. One minor nit: I don't

[jira] [Commented] (PHOENIX-4332) Stats - Altering guidepost width on base table does not propagate to global index

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227669#comment-16227669 ] Samarth Jain commented on PHOENIX-4332: --- [~jamestaylor], if possible, I would like to get

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227665#comment-16227665 ] Samarth Jain commented on PHOENIX-4335: --- My comment was more around user expectation

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227658#comment-16227658 ] Samarth Jain commented on PHOENIX-4335: --- Thinking about this a little bit more, there is a slight

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227639#comment-16227639 ] Samarth Jain commented on PHOENIX-4333: --- I have committed the test to the master, 4.x-HBase-0.98

[jira] [Updated] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4333: -- Attachment: PHOENIX-4333_test.patch Test which demonstrates the issue that [~mujtabachohan

[jira] [Comment Edited] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16227597#comment-16227597 ] Samarth Jain edited comment on PHOENIX-4333 at 10/31/17 9:12 PM: - Test

[jira] [Commented] (PHOENIX-4333) Stats - Incorrect estimate when stats are updated on a tenant specific view

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226388#comment-16226388 ] Samarth Jain commented on PHOENIX-4333: --- I am not sure what is the best option here. We possibly

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_v4.patch Thanks for the review, [~jamestaylor]. Attached

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226372#comment-16226372 ] Samarth Jain commented on PHOENIX-4335: --- You could possibly spy/mock

[jira] [Commented] (PHOENIX-4334) Unable to update stats on views that reside on separate regions before phoenix.stats.updateFrequency has elapsed

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226350#comment-16226350 ] Samarth Jain commented on PHOENIX-4334: --- [~jamestaylor] - any other ideas on how we can prevent

[jira] [Commented] (PHOENIX-4334) Unable to update stats on views that reside on separate regions before phoenix.stats.updateFrequency has elapsed

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226349#comment-16226349 ] Samarth Jain commented on PHOENIX-4334: --- We store last_update_time at the physical table level. So

[jira] [Commented] (PHOENIX-4335) System catalog snapshot created each time a new connection is created

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226347#comment-16226347 ] Samarth Jain commented on PHOENIX-4335: --- Would a straightforward change be to revert

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-31 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_v3.patch I think I figured out what was going on. When we

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_v3_wip.patch wip patch for an attempt to use the existing code

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225583#comment-16225583 ] Samarth Jain commented on PHOENIX-4287: --- There is some level of duplication but the generation

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16225434#comment-16225434 ] Samarth Jain commented on PHOENIX-4287: --- Yes, v2 just has changes relevant to this JIRA

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-30 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287_v2.patch > Incorrect aggregate query results when stats are disa

[jira] [Commented] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-29 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224407#comment-16224407 ] Samarth Jain commented on PHOENIX-4289: --- Tests passed. I will go ahead and commit this patch

[jira] [Updated] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-29 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4287: -- Attachment: PHOENIX-4287.patch Patch on top on PHOENIX-4289. [~jamestaylor], please review

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-29 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: PHOENIX-4289_v4.patch Fixing test failure. > UPDATE STATISTICS command d

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-29 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: PHOENIX-4289_v3.patch v3 patch to address the test failure. > UPDATE STATIST

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-28 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: PHOENIX-4289_v2.patch Previous patch had an issue which was preventing stats

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-27 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: (was: PHOENIX-4289.patch) > UPDATE STATISTICS command does not collect st

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-27 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: PHOENIX-4289.patch > UPDATE STATISTICS command does not collect stats for lo

[jira] [Updated] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-27 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4289: -- Attachment: PHOENIX-4289.patch [~jamestaylor], please review. > UPDATE STATISTICS comm

[jira] [Commented] (PHOENIX-4320) Update website pages with information on phoenix.use.stats.parallelization confi

2017-10-25 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219492#comment-16219492 ] Samarth Jain commented on PHOENIX-4320: --- Something wrong with my setup. [~mujtabachohan] just

[jira] [Commented] (PHOENIX-4320) Update website pages with information on phoenix.use.stats.parallelization confi

2017-10-25 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219433#comment-16219433 ] Samarth Jain commented on PHOENIX-4320: --- Oops. Will fix it right away. > Update website pa

[jira] [Resolved] (PHOENIX-4320) Update website pages with information on phoenix.use.stats.parallelization confi

2017-10-25 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain resolved PHOENIX-4320. --- Resolution: Fixed > Update website pages with informat

[jira] [Updated] (PHOENIX-4320) Update website pages with information on phoenix.use.stats.parallelization confi

2017-10-25 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4320: -- Attachment: PHOENIX-4320.patch > Update website pages with informat

[jira] [Created] (PHOENIX-4320) Update website pages with information on phoenix.use.stats.parallelization confi

2017-10-25 Thread Samarth Jain (JIRA)
Samarth Jain created PHOENIX-4320: - Summary: Update website pages with information on phoenix.use.stats.parallelization confi Key: PHOENIX-4320 URL: https://issues.apache.org/jira/browse/PHOENIX-4320

[jira] [Comment Edited] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-20 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213608#comment-16213608 ] Samarth Jain edited comment on PHOENIX-4289 at 10/21/17 12:58 AM: -- I

[jira] [Commented] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-20 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213608#comment-16213608 ] Samarth Jain commented on PHOENIX-4289: --- I think I see what is going on. When a table has an index

[jira] [Commented] (PHOENIX-4289) UPDATE STATISTICS command does not collect stats for local indexes

2017-10-20 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213580#comment-16213580 ] Samarth Jain commented on PHOENIX-4289: --- [~mujtabachohan], I am unable to repro this issue

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-18 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209858#comment-16209858 ] Samarth Jain commented on PHOENIX-4287: --- Looks like it is limited to local indexes. Will keep

[jira] [Commented] (PHOENIX-4287) Incorrect aggregate query results when stats are disable for parallelization

2017-10-17 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208163#comment-16208163 ] Samarth Jain commented on PHOENIX-4287: --- Yes, I am working on it. > Incorrect aggregate qu

Re: [ANNOUNCE] New Phoenix committer: Ethan Wang

2017-10-12 Thread Samarth Jain
Congrats, Ethan! On Thu, Oct 12, 2017 at 9:25 AM Thomas D'Silva wrote: > Congrats Ethan! > > On Thu, Oct 12, 2017 at 8:28 AM, Geoffrey Jacoby > wrote: > > > Congrats, Ethan! Looking forward to using those new functions soon. > > > > Geoffrey > > > >

Re: [ANNOUNCE] New Phoenix committer: Vincent Poon

2017-10-12 Thread Samarth Jain
Congrats, Vincent! On Thu, Oct 12, 2017 at 9:25 AM Thomas D'Silva wrote: > Congrats Vincent! > > On Thu, Oct 12, 2017 at 8:27 AM, Geoffrey Jacoby > wrote: > > > Congrats, Vincent! Thanks for all your help on the index stabilization. > > > > On Thu,

Re: [VOTE] Release of Apache Phoenix 4.12.0 RC0

2017-10-09 Thread Samarth Jain
+1 - built from source - successfully ran all unit and integration tests - collected stats using major compaction and update stats - estimates look correct - ran some basic manual tests involving global mutable and immutable secondary indexes, looks good. On Fri, Oct 6, 2017 at 1:03 PM, lars

[jira] [Commented] (PHOENIX-4276) Surface metrics on statistics collection

2017-10-04 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191580#comment-16191580 ] Samarth Jain commented on PHOENIX-4276: --- FYI, [~Misraji] > Surface metrics on statist

[jira] [Updated] (PHOENIX-4276) Surface metrics on statistics collection

2017-10-04 Thread Samarth Jain (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samarth Jain updated PHOENIX-4276: -- Issue Type: Improvement (was: Bug) > Surface metrics on statistics collect

[jira] [Created] (PHOENIX-4276) Surface metrics on statistics collection

2017-10-04 Thread Samarth Jain (JIRA)
Samarth Jain created PHOENIX-4276: - Summary: Surface metrics on statistics collection Key: PHOENIX-4276 URL: https://issues.apache.org/jira/browse/PHOENIX-4276 Project: Phoenix Issue Type

  1   2   3   4   5   6   7   8   9   10   >