[jira] [Comment Edited] (PHOENIX-3265) Double-quote column names that use reserved keywords

2016-10-12 Thread Eric Lomore (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569735#comment-15569735
 ] 

Eric Lomore edited comment on PHOENIX-3265 at 10/12/16 8:20 PM:


Weird, my PR missed my recent commit which updated HashJoinIT.java. I've pushed 
the appropriate commit to the existing pull request.

My apologies for not catching this!


was (Author: lomoree):
Weird, my PR missed my recent commit which rolled back the changes causing this 
error. Need to simply revert changes to HashJoinIT.

Note: The fix is on the existing pull request.

> Double-quote column names that use reserved keywords
> 
>
> Key: PHOENIX-3265
> URL: https://issues.apache.org/jira/browse/PHOENIX-3265
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Eric Lomore
> Fix For: 4.9.0
>
>
> In Phoenix {{date}} is not a reserved word, but perhaps in Calcite it is? If 
> that's the case, we should surround occurrences of columns named {{date}} in 
> double quotes to prevent the parser error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (PHOENIX-3265) Double-quote column names that use reserved keywords

2016-10-12 Thread Eric Lomore (JIRA)

[ 
https://issues.apache.org/jira/browse/PHOENIX-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569735#comment-15569735
 ] 

Eric Lomore edited comment on PHOENIX-3265 at 10/12/16 8:09 PM:


Weird, my PR missed my recent commit which rolled back the changes causing this 
error. Need to simply revert changes to HashJoinIT.

Note: The fix is on the existing pull request.


was (Author: lomoree):
Weird, my PR missed my recent commit which rolled back the changes causing this 
error. Need to simply revert changes to HashJoinIT.

> Double-quote column names that use reserved keywords
> 
>
> Key: PHOENIX-3265
> URL: https://issues.apache.org/jira/browse/PHOENIX-3265
> Project: Phoenix
>  Issue Type: Sub-task
>Reporter: James Taylor
>Assignee: Eric Lomore
> Fix For: 4.9.0
>
>
> In Phoenix {{date}} is not a reserved word, but perhaps in Calcite it is? If 
> that's the case, we should surround occurrences of columns named {{date}} in 
> double quotes to prevent the parser error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)