[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[
https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238606#comment-16238606
]
Hadoop QA commented on PHOENIX-2370:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12883280/PHOENIX-2370_v2.patch
against master branch at commit a09cea6bfb94edd95ce06aa2cb7f229227db5666.
ATTACHMENT ID: 12883280
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1617//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1617//console
This message is automatically generated.
> ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and
> varbinary columns
>
>
> Key: PHOENIX-2370
> URL: https://issues.apache.org/jira/browse/PHOENIX-2370
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.5.0
> Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May
> 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Sergio Lob
>Assignee: Csaba Skrabak
>Priority: Major
> Labels: newbie, verify
> Fix For: 4.14.0
>
> Attachments: PHOENIX-2370.patch, PHOENIX-2370_v2.patch
>
>
> ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and
> varbinary columns. Specifically, for the following table:
> CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10),
> VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE
> VARBINARY(2147483647), VB VARBINARY) ;
> 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the
> defined size. This should return the max possible size of the column, so:
> getColumnDisplaySize() should return 10 for column VB10,
> getColumnDisplaySize() should return 2147483647 for column VBHUGE,
> getColumnDisplaySize() should return 2147483647 for column VB, assuming that
> a column defined with no size should default to the maximum size.
> 2. getColumnDisplaySize() returns 40 for all varchar columns that are not
> defined with a size, like in column V in the above CREATE TABLE. I would
> think that a VARCHAR column defined with no size parameter should default to
> the maximum size possible, not to a random number like 40.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[
https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130912#comment-16130912
]
Hadoop QA commented on PHOENIX-2370:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12877299/PHOENIX-2370.patch
against master branch at commit b13413614fef3cdb87233fd1543081e7198d685f.
ATTACHMENT ID: 12877299
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+assertEquals(PhoenixResultSetMetaData.DEFAULT_DISPLAY_WIDTH,
rs.getMetaData().getColumnDisplaySize(5));
+"CREATE TABLE T (pk1 CHAR(15) not null PRIMARY KEY, VB10
VARBINARY(10), VBHUGE VARBINARY(2147483647), VB VARBINARY) ");
+assertEquals(PhoenixResultSetMetaData.DEFAULT_DISPLAY_WIDTH,
rs.getMetaData().getColumnDisplaySize(4));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NotQueryIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1268//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1268//console
This message is automatically generated.
> ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and
> varbinary columns
>
>
> Key: PHOENIX-2370
> URL: https://issues.apache.org/jira/browse/PHOENIX-2370
> Project: Phoenix
> Issue Type: Bug
>Affects Versions: 4.5.0
> Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May
> 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux
>Reporter: Sergio Lob
>Assignee: Csaba Skrabak
> Labels: newbie, verify
> Fix For: 4.12.0
>
> Attachments: PHOENIX-2370.patch
>
>
> ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and
> varbinary columns. Specifically, for the following table:
> CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10),
> VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE
> VARBINARY(2147483647), VB VARBINARY) ;
> 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the
> defined size. This should return the max possible size of the column, so:
> getColumnDisplaySize() should return 10 for column VB10,
> getColumnDisplaySize() should return 2147483647 for column VBHUGE,
> getColumnDisplaySize() should return 2147483647 for column VB, assuming that
> a column defined with no size should default to the maximum size.
> 2. getColumnDisplaySize() returns 40 for all varchar columns that are not
> defined with a size, like in column V in the above CREATE TABLE. I would
> think that a VARCHAR column defined with no size parameter should default to
> the maximum size possible, not to a random number like 40.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[ https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087662#comment-16087662 ] Julian Hyde commented on PHOENIX-2370: -- So I think that 40 is a good pragmatic choice. I seem to recall other JDBC drivers doing this as well. By the way, I don't think the SQL standard allows unbounded varchar and varbinary. But Calcite does, because it is very useful when your data is stored in java Strings. Those types have precision = -1 (see [RelDataType|https://insight.io/github.com/apache/calcite/blob/8cb189f727aafade53708d18bc7e51526da0bf38/core/src/main/java/org/apache/calcite/rel/type/RelDataType.java?line=36]), not 2^31 or some such. After all, infinity is a lot larger than 2^31 :) > ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and > varbinary columns > > > Key: PHOENIX-2370 > URL: https://issues.apache.org/jira/browse/PHOENIX-2370 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.5.0 > Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May > 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Sergio Lob > Labels: newbie, verify > Fix For: 4.12.0 > > Attachments: PHOENIX-2370.patch > > > ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and > varbinary columns. Specifically, for the following table: > CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10), > VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE > VARBINARY(2147483647), VB VARBINARY) ; > 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the > defined size. This should return the max possible size of the column, so: > getColumnDisplaySize() should return 10 for column VB10, > getColumnDisplaySize() should return 2147483647 for column VBHUGE, > getColumnDisplaySize() should return 2147483647 for column VB, assuming that > a column defined with no size should default to the maximum size. > 2. getColumnDisplaySize() returns 40 for all varchar columns that are not > defined with a size, like in column V in the above CREATE TABLE. I would > think that a VARCHAR column defined with no size parameter should default to > the maximum size possible, not to a random number like 40. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[ https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087484#comment-16087484 ] James Taylor commented on PHOENIX-2370: --- Thanks for the patch, [~cskrabak]. Makes sense to change this. What does the sql spec or javadoc say should be returned when a varchar is unbounded? Maybe [~julianhyde] knows? The display size often drives tools such as sqline, so we should confirm result sets display as expected there. > ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and > varbinary columns > > > Key: PHOENIX-2370 > URL: https://issues.apache.org/jira/browse/PHOENIX-2370 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.5.0 > Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May > 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Sergio Lob > Labels: newbie, verify > Fix For: 4.12.0 > > Attachments: PHOENIX-2370.patch > > > ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and > varbinary columns. Specifically, for the following table: > CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10), > VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE > VARBINARY(2147483647), VB VARBINARY) ; > 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the > defined size. This should return the max possible size of the column, so: > getColumnDisplaySize() should return 10 for column VB10, > getColumnDisplaySize() should return 2147483647 for column VBHUGE, > getColumnDisplaySize() should return 2147483647 for column VB, assuming that > a column defined with no size should default to the maximum size. > 2. getColumnDisplaySize() returns 40 for all varchar columns that are not > defined with a size, like in column V in the above CREATE TABLE. I would > think that a VARCHAR column defined with no size parameter should default to > the maximum size possible, not to a random number like 40. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[ https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087325#comment-16087325 ] Csaba Skrabak commented on PHOENIX-2370: [~jamestaylor], what do you think about the 40 vs 2147483647? > ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and > varbinary columns > > > Key: PHOENIX-2370 > URL: https://issues.apache.org/jira/browse/PHOENIX-2370 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.5.0 > Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May > 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Sergio Lob > Labels: newbie, verify > Fix For: 4.12.0 > > Attachments: PHOENIX-2370.patch > > > ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and > varbinary columns. Specifically, for the following table: > CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10), > VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE > VARBINARY(2147483647), VB VARBINARY) ; > 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the > defined size. This should return the max possible size of the column, so: > getColumnDisplaySize() should return 10 for column VB10, > getColumnDisplaySize() should return 2147483647 for column VBHUGE, > getColumnDisplaySize() should return 2147483647 for column VB, assuming that > a column defined with no size should default to the maximum size. > 2. getColumnDisplaySize() returns 40 for all varchar columns that are not > defined with a size, like in column V in the above CREATE TABLE. I would > think that a VARCHAR column defined with no size parameter should default to > the maximum size possible, not to a random number like 40. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[ https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087305#comment-16087305 ] Csaba Skrabak commented on PHOENIX-2370: I have added a test to current master branch and concluded that getColumnDisplaySize now returns 10, 2147483647 and 40 to the vb10, vbhuge and vb fields, respectively, as defined in the description. Assuming that returning 40 for fields without explicit sizes is intentional and expected, there is nothing left to do here. > ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and > varbinary columns > > > Key: PHOENIX-2370 > URL: https://issues.apache.org/jira/browse/PHOENIX-2370 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.5.0 > Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May > 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Sergio Lob > Labels: newbie, verify > Fix For: 4.12.0 > > > ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and > varbinary columns. Specifically, for the following table: > CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10), > VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE > VARBINARY(2147483647), VB VARBINARY) ; > 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the > defined size. This should return the max possible size of the column, so: > getColumnDisplaySize() should return 10 for column VB10, > getColumnDisplaySize() should return 2147483647 for column VBHUGE, > getColumnDisplaySize() should return 2147483647 for column VB, assuming that > a column defined with no size should default to the maximum size. > 2. getColumnDisplaySize() returns 40 for all varchar columns that are not > defined with a size, like in column V in the above CREATE TABLE. I would > think that a VARCHAR column defined with no size parameter should default to > the maximum size possible, not to a random number like 40. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (PHOENIX-2370) ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and varbinary columns
[ https://issues.apache.org/jira/browse/PHOENIX-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087213#comment-16087213 ] Csaba Skrabak commented on PHOENIX-2370: 40 as the varchar size is not a random number but introduced as a default in PHOENIX-1394. Do we want to change that decision now? > ResultSetMetaData.getColumnDisplaySize() returns bad value for varchar and > varbinary columns > > > Key: PHOENIX-2370 > URL: https://issues.apache.org/jira/browse/PHOENIX-2370 > Project: Phoenix > Issue Type: Bug >Affects Versions: 4.5.0 > Environment: Linux lnxx64r6 2.6.32-131.0.15.el6.x86_64 #1 SMP Tue May > 10 15:42:40 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux >Reporter: Sergio Lob > Labels: newbie, verify > Fix For: 4.12.0 > > > ResultSetMetaData.getColumnDisplaySize() returns bad values for varchar and > varbinary columns. Specifically, for the following table: > CREATE TABLE SERGIO (I INTEGER, V10 VARCHAR(10), > VHUGE VARCHAR(2147483647), V VARCHAR, VB10 VARBINARY(10), VBHUGE > VARBINARY(2147483647), VB VARBINARY) ; > 1. getColumnDisplaySize() returns 20 for all varbinary columns, no matter the > defined size. This should return the max possible size of the column, so: > getColumnDisplaySize() should return 10 for column VB10, > getColumnDisplaySize() should return 2147483647 for column VBHUGE, > getColumnDisplaySize() should return 2147483647 for column VB, assuming that > a column defined with no size should default to the maximum size. > 2. getColumnDisplaySize() returns 40 for all varchar columns that are not > defined with a size, like in column V in the above CREATE TABLE. I would > think that a VARCHAR column defined with no size parameter should default to > the maximum size possible, not to a random number like 40. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
