[ 
https://issues.apache.org/jira/browse/PHOENIX-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141950#comment-16141950
 ] 

Samarth Jain commented on PHOENIX-4125:
---------------------------------------

I realized that with PHOENIX-3752, tracing no longer depends on the hadoop 
metrics system. But that change wasn't made to the 4.x-HBase-0.98 branch, 
purposefully. So for branches other than 4.x-HBase-0.98, we can just disable 
the metrics system (I hope there is a way to do that). If there isn't, and I 
know there is JMXCacheBuster that keeps on restarting the metrics system, we 
can always keep tearing it down whenever we tear down our test driver (in 
various @AfterClass methods). 

> Shutdown and start metrics system when mini cluster is shutdown and started
> ---------------------------------------------------------------------------
>
>                 Key: PHOENIX-4125
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4125
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>
> While doing analysis for PHOENIX-4110, I noticed that the metrics system is 
> keeping a lot of garbage around even though we frequently restart the mini 
> cluster. This is because the metrics system is a singleton and is only 
> shutdown when the JVM is shutdown. We should figure out a way to either 
> disable it, or start it only for tests (primarily Tracing related) that use 
> it, or tie it's lifecycle to the mini-cluster's lifecycle.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to