[jira] [Commented] (PHOENIX-4127) Shutdownhook that halts JVM is causing test runs to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142375#comment-16142375
]
James Taylor commented on PHOENIX-4127:
---
This looks like it helps. +1 to checking it in.
> Shutdownhook that halts JVM is causing test runs to fail
>
>
> Key: PHOENIX-4127
> URL: https://issues.apache.org/jira/browse/PHOENIX-4127
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4127_4.x-HBase-0.98.patch, PHOENIX-4127.patch
>
>
> When all the unit tests actually pass, surefire still reports that there was
> an error in the fork. This is because it doesn't like the fact that a forked
> JVM called system.exit() or system.halt(). We have a shutdown hook in
> BaseTest which does that. Such failed runs happen more frequently on the
> 4.x-HBase-0.98 branch. And sometimes on the master and 1.1 branch.
> I know the code was added because we were seeing test runs hang. Since we
> changed a lot of tests since then, I would like to remove that hook and see
> if it helps.
> {code}
> private static String checkClusterInitialized(ReadOnlyProps serverProps)
> throws Exception {
> if (!clusterInitialized) {
> url = setUpTestCluster(config, serverProps);
> clusterInitialized = true;
> Runtime.getRuntime().addShutdownHook(new Thread() {
> @Override
> public void run() {
> logger.info("SHUTDOWN: halting JVM now");
> Runtime.getRuntime().halt(0);
> }
> });
> }
> return url;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4127) Shutdownhook that halts JVM is causing test runs to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142076#comment-16142076
]
Hadoop QA commented on PHOENIX-4127:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12883770/PHOENIX-4127_4.x-HBase-0.98.patch
against 4.x-HBase-0.98 branch at commit
a5fb51948225ee7ee9ece76d233f4a150006e4a9.
ATTACHMENT ID: 12883770
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
53 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1300//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1300//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1300//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1300//console
This message is automatically generated.
> Shutdownhook that halts JVM is causing test runs to fail
>
>
> Key: PHOENIX-4127
> URL: https://issues.apache.org/jira/browse/PHOENIX-4127
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4127_4.x-HBase-0.98.patch, PHOENIX-4127.patch
>
>
> When all the unit tests actually pass, surefire still reports that there was
> an error in the fork. This is because it doesn't like the fact that a forked
> JVM called system.exit() or system.halt(). We have a shutdown hook in
> BaseTest which does that. Such failed runs happen more frequently on the
> 4.x-HBase-0.98 branch. And sometimes on the master and 1.1 branch.
> I know the code was added because we were seeing test runs hang. Since we
> changed a lot of tests since then, I would like to remove that hook and see
> if it helps.
> {code}
> private static String checkClusterInitialized(ReadOnlyProps serverProps)
> throws Exception {
> if (!clusterInitialized) {
> url = setUpTestCluster(config, serverProps);
> clusterInitialized = true;
> Runtime.getRuntime().addShutdownHook(new Thread() {
> @Override
> public void run() {
> logger.info("SHUTDOWN: halting JVM now");
> Runtime.getRuntime().halt(0);
> }
> });
> }
> return url;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PHOENIX-4127) Shutdownhook that halts JVM is causing test runs to fail
[
https://issues.apache.org/jira/browse/PHOENIX-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16142057#comment-16142057
]
Hadoop QA commented on PHOENIX-4127:
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12883770/PHOENIX-4127_4.x-HBase-0.98.patch
against 4.x-HBase-0.98 branch at commit
a5fb51948225ee7ee9ece76d233f4a150006e4a9.
ATTACHMENT ID: 12883770
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
53 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 2 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1299//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1299//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1299//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1299//console
This message is automatically generated.
> Shutdownhook that halts JVM is causing test runs to fail
>
>
> Key: PHOENIX-4127
> URL: https://issues.apache.org/jira/browse/PHOENIX-4127
> Project: Phoenix
> Issue Type: Bug
>Reporter: Samarth Jain
>Assignee: Samarth Jain
> Attachments: PHOENIX-4127_4.x-HBase-0.98.patch, PHOENIX-4127.patch
>
>
> When all the unit tests actually pass, surefire still reports that there was
> an error in the fork. This is because it doesn't like the fact that a forked
> JVM called system.exit() or system.halt(). We have a shutdown hook in
> BaseTest which does that. Such failed runs happen more frequently on the
> 4.x-HBase-0.98 branch. And sometimes on the master and 1.1 branch.
> I know the code was added because we were seeing test runs hang. Since we
> changed a lot of tests since then, I would like to remove that hook and see
> if it helps.
> {code}
> private static String checkClusterInitialized(ReadOnlyProps serverProps)
> throws Exception {
> if (!clusterInitialized) {
> url = setUpTestCluster(config, serverProps);
> clusterInitialized = true;
> Runtime.getRuntime().addShutdownHook(new Thread() {
> @Override
> public void run() {
> logger.info("SHUTDOWN: halting JVM now");
> Runtime.getRuntime().halt(0);
> }
> });
> }
> return url;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
