[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-03-06 Thread Jepson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387441#comment-16387441 ] Jepson commented on PHOENIX-4489: - [~karanmehta93] Very nice, i have compiled, tested, and been ok. >

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337080#comment-16337080 ] Karan Mehta commented on PHOENIX-4489: -- Pushed the patches to all 4.x and 5.x branches. Thanks for

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336970#comment-16336970 ] Hudson commented on PHOENIX-4489: - FAILURE: Integrated in Jenkins build Phoenix-master #1919 (See

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336784#comment-16336784 ] Karan Mehta commented on PHOENIX-4489: -- Apart from master branch, will other branches do I need to

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336783#comment-16336783 ] Karan Mehta commented on PHOENIX-4489: -- Thanks [~gjacoby] and [~jmahonin]. Will commit this. Also

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Josh Mahonin (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336717#comment-16336717 ] Josh Mahonin commented on PHOENIX-4489: --- Thanks for that [~karanmehta93], +1 as well > HBase

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336670#comment-16336670 ] Geoffrey Jacoby commented on PHOENIX-4489: -- +1, [~karanmehta93] > HBase Connection leak in

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336604#comment-16336604 ] Karan Mehta commented on PHOENIX-4489: -- [~jmahonin] Added the new patch without whitespace changes.

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336123#comment-16336123 ] Karan Mehta commented on PHOENIX-4489: -- [~jamestaylor] I will upload a new patch without whitespace

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-23 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336118#comment-16336118 ] James Taylor commented on PHOENIX-4489: --- Where are we at with this one, [~karanmehta93]? > HBase

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-08 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316716#comment-16316716 ] Vincent Poon commented on PHOENIX-4489: --- [~karanmehta93] I think we should fix this - I didn't

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-07 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315655#comment-16315655 ] Karan Mehta commented on PHOENIX-4489: -- [~vincentpoon] Technically, as we discussed it shouldn't

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-07 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315652#comment-16315652 ] Karan Mehta commented on PHOENIX-4489: -- Yes [~jmahonin] The issue exists in {{PhoenixInputFormat}}

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-05 Thread Ethan Wang (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314149#comment-16314149 ] Ethan Wang commented on PHOENIX-4489: - [~karanmehta93] patch +1 white space comment from

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-05 Thread Josh Mahonin (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313883#comment-16313883 ] Josh Mahonin commented on PHOENIX-4489: --- [~karanmehta93] Good find. I suspect I introduced this in

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-05 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313790#comment-16313790 ] James Taylor commented on PHOENIX-4489: --- Let's please spread out the load for code reviews. Maybe

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2018-01-05 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313752#comment-16313752 ] Karan Mehta commented on PHOENIX-4489: -- FYI. [~tdsilva] > HBase Connection leak in Phoenix MR Jobs

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2017-12-24 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302889#comment-16302889 ] Hadoop QA commented on PHOENIX-4489: {color:red}-1 overall{color}. Here are the results of testing

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2017-12-22 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302171#comment-16302171 ] James Taylor commented on PHOENIX-4489: --- Yes, definitely a concern. Let's make sure there are no

[jira] [Commented] (PHOENIX-4489) HBase Connection leak in Phoenix MR Jobs

2017-12-22 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302159#comment-16302159 ] Karan Mehta commented on PHOENIX-4489: -- The fix seems straight forward but want to make sure its