[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387441#comment-16387441
]
Jepson commented on PHOENIX-4489:
-
[~karanmehta93] Very nice, i have compiled, tested, and been ok.
>
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337080#comment-16337080
]
Karan Mehta commented on PHOENIX-4489:
--
Pushed the patches to all 4.x and 5.x branches. Thanks for
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336970#comment-16336970
]
Hudson commented on PHOENIX-4489:
-
FAILURE: Integrated in Jenkins build Phoenix-master #1919 (See
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336784#comment-16336784
]
Karan Mehta commented on PHOENIX-4489:
--
Apart from master branch, will other branches do I need to
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336783#comment-16336783
]
Karan Mehta commented on PHOENIX-4489:
--
Thanks [~gjacoby] and [~jmahonin]. Will commit this. Also
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336717#comment-16336717
]
Josh Mahonin commented on PHOENIX-4489:
---
Thanks for that [~karanmehta93], +1 as well
> HBase
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336670#comment-16336670
]
Geoffrey Jacoby commented on PHOENIX-4489:
--
+1, [~karanmehta93]
> HBase Connection leak in
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336604#comment-16336604
]
Karan Mehta commented on PHOENIX-4489:
--
[~jmahonin] Added the new patch without whitespace changes.
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336123#comment-16336123
]
Karan Mehta commented on PHOENIX-4489:
--
[~jamestaylor] I will upload a new patch without whitespace
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336118#comment-16336118
]
James Taylor commented on PHOENIX-4489:
---
Where are we at with this one, [~karanmehta93]?
> HBase
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16316716#comment-16316716
]
Vincent Poon commented on PHOENIX-4489:
---
[~karanmehta93] I think we should fix this - I didn't
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315655#comment-16315655
]
Karan Mehta commented on PHOENIX-4489:
--
[~vincentpoon]
Technically, as we discussed it shouldn't
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315652#comment-16315652
]
Karan Mehta commented on PHOENIX-4489:
--
Yes [~jmahonin] The issue exists in {{PhoenixInputFormat}}
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16314149#comment-16314149
]
Ethan Wang commented on PHOENIX-4489:
-
[~karanmehta93]
patch +1
white space comment from
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313883#comment-16313883
]
Josh Mahonin commented on PHOENIX-4489:
---
[~karanmehta93] Good find. I suspect I introduced this in
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313790#comment-16313790
]
James Taylor commented on PHOENIX-4489:
---
Let's please spread out the load for code reviews. Maybe
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313752#comment-16313752
]
Karan Mehta commented on PHOENIX-4489:
--
FYI. [~tdsilva]
> HBase Connection leak in Phoenix MR Jobs
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302889#comment-16302889
]
Hadoop QA commented on PHOENIX-4489:
{color:red}-1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302171#comment-16302171
]
James Taylor commented on PHOENIX-4489:
---
Yes, definitely a concern. Let's make sure there are no
[
https://issues.apache.org/jira/browse/PHOENIX-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302159#comment-16302159
]
Karan Mehta commented on PHOENIX-4489:
--
The fix seems straight forward but want to make sure its
20 matches
Mail list logo