Re: Can we commit PIG-3015 (Rewrite of AvroStorage) to trunk?

2013-03-19 Thread Jonathan Coveney
I'll take a look. I think it should be part of the core of Pig. I will comment in the JIRA. Thanks, Cheolsoo 2013/3/19 Cheolsoo Park cheol...@apache.org Hello, Thanks to Joseph Adler's contribution, we have a new AvroStorage ready. Although there are additional requests that we would like

[jira] [Commented] (PIG-3251) Bzip2TextInputFormat requires double the memory of maximum record size

2013-03-19 Thread Koji Noguchi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606445#comment-13606445 ] Koji Noguchi commented on PIG-3251: --- bq. Let me know if you find any problem in your

Re: Review Request: PIG-3015 Rewrite of AvroStorage

2013-03-19 Thread Jonathan Coveney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8104/#review18077 --- src/org/apache/pig/builtin/AvroStorage.java

[jira] [Commented] (PIG-3015) Rewrite of AvroStorage

2013-03-19 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606484#comment-13606484 ] Jonathan Coveney commented on PIG-3015: --- Joseph, as gratitude for the effort you've

[jira] [Commented] (PIG-3215) [piggybank] Add LTSVLoader to load LTSV (Labeled Tab-separated Values) files

2013-03-19 Thread Jonathan Coveney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606491#comment-13606491 ] Jonathan Coveney commented on PIG-3215: --- Updated the review. Basically, we should

[jira] [Commented] (PIG-3252) AvroStorage gives wrong schema for schemas with named records

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606616#comment-13606616 ] Cheolsoo Park commented on PIG-3252: +1. Thank you Mark for the fix!

[jira] [Updated] (PIG-3252) AvroStorage gives wrong schema for schemas with named records

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheolsoo Park updated PIG-3252: --- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk and 0.11.

[jira] [Commented] (PIG-3223) AvroStorage does not handle comma separated input paths

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606658#comment-13606658 ] Cheolsoo Park commented on PIG-3223: [~mkramer], thanks for the explanation. I actually

[jira] [Commented] (PIG-3208) [zebra] TFile should not set io.compression.codec.lzo.buffersize

2013-03-19 Thread Eugene Koontz (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606756#comment-13606756 ] Eugene Koontz commented on PIG-3208: Hi Xuefu, Daniel and Dmitriy, Thanks for

[jira] [Commented] (PIG-3208) [zebra] TFile should not set io.compression.codec.lzo.buffersize

2013-03-19 Thread Eugene Koontz (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606773#comment-13606773 ] Eugene Koontz commented on PIG-3208: Correction, it will take its *setting* from the

[jira] [Commented] (PIG-3208) [zebra] TFile should not set io.compression.codec.lzo.buffersize

2013-03-19 Thread Xuefu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606780#comment-13606780 ] Xuefu Zhang commented on PIG-3208: -- Got it. +1 to the patch. However, I forgot the

[jira] [Created] (PIG-3253) Misleading comment w.r.t getSplitIndex() method in PigSplit.java

2013-03-19 Thread Cheolsoo Park (JIRA)
Cheolsoo Park created PIG-3253: -- Summary: Misleading comment w.r.t getSplitIndex() method in PigSplit.java Key: PIG-3253 URL: https://issues.apache.org/jira/browse/PIG-3253 Project: Pig Issue

[jira] [Updated] (PIG-3253) Misleading comment w.r.t getSplitIndex() method in PigSplit.java

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheolsoo Park updated PIG-3253: --- Status: Patch Available (was: Open) Misleading comment w.r.t getSplitIndex() method in

[jira] [Updated] (PIG-3253) Misleading comment w.r.t getSplitIndex() method in PigSplit.java

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheolsoo Park updated PIG-3253: --- Attachment: PIG-3253.patch The patch removes the comment. Misleading comment w.r.t

[jira] [Commented] (PIG-2641) Create toJSON function for all complex types: tuples, bags and maps

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606861#comment-13606861 ] Daniel Dai commented on PIG-2641: - Looks good. Several minor comments: * Seems it is better

[jira] [Commented] (PIG-2470) Issue with CSVEXcelStorage piggy bank function

2013-03-19 Thread Cheolsoo Park (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606867#comment-13606867 ] Cheolsoo Park commented on PIG-2470: PIG-3141 incorporates the fix. It also adds a unit

[jira] [Commented] (PIG-2470) Issue with CSVEXcelStorage piggy bank function

2013-03-19 Thread Prashant Kommireddi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606932#comment-13606932 ] Prashant Kommireddi commented on PIG-2470: -- Sure, let's do that. You are right, it

[jira] [Commented] (PIG-3190) Add LuceneTokenizer and SnowballTokenizer to Pig - useful text tokenization

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606940#comment-13606940 ] Daniel Dai commented on PIG-3190: - Some comments: * TestStandardTokenize fail due to

[jira] [Commented] (PIG-3208) [zebra] TFile should not set io.compression.codec.lzo.buffersize

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607029#comment-13607029 ] Daniel Dai commented on PIG-3208: - The zebra unit tests on trunk is already broken:

[jira] [Updated] (PIG-3208) [zebra] TFile should not set io.compression.codec.lzo.buffersize

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-3208: Resolution: Fixed Fix Version/s: 0.12 Hadoop Flags: Reviewed Status: Resolved (was:

[jira] [Commented] (PIG-3253) Misleading comment w.r.t getSplitIndex() method in PigSplit.java

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607056#comment-13607056 ] Daniel Dai commented on PIG-3253: - +1 Misleading comment w.r.t

Review Request: [PIG-3173] - Partition filter pushdown does not happen if partition keys condition include a AND and OR construct

2013-03-19 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10035/ --- Review request for pig. Description --- 1) Fixed cases where partition

[jira] [Updated] (PIG-3173) Partition filter push down does not happen partition keys condition include a AND and OR construct

2013-03-19 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohini Palaniswamy updated PIG-3173: Attachment: PIG-3173-1.patch https://reviews.apache.org/r/10035/ Partition

[jira] [Updated] (PIG-3173) Partition filter push down does not happen partition keys condition include a AND and OR construct

2013-03-19 Thread Rohini Palaniswamy (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohini Palaniswamy updated PIG-3173: Fix Version/s: 0.12 Affects Version/s: 0.10.1 Status: Patch Available

Re: Review Request: [PIG-3173] - Partition filter pushdown does not happen if partition keys condition include a AND and OR construct

2013-03-19 Thread Dmitriy Ryaboy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10035/#review18127 ---

[jira] [Commented] (PIG-3110) pig corrupts chararrays with trailing whitespace when converting them to long

2013-03-19 Thread Prashant Kommireddi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607132#comment-13607132 ] Prashant Kommireddi commented on PIG-3110: -- [~daijy] would you like to take a look

[jira] [Commented] (PIG-3110) pig corrupts chararrays with trailing whitespace when converting them to long

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607135#comment-13607135 ] Daniel Dai commented on PIG-3110: - Yes, I will take a look. pig corrupts

[jira] [Commented] (PIG-3222) New UDFContextSignature assignments in Pig 0.11 breaks HCatalog.HCatStorer

2013-03-19 Thread Feng Peng (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607189#comment-13607189 ] Feng Peng commented on PIG-3222: [~daijy], thanks for looking into this. When I ran the

[jira] [Commented] (PIG-3190) Add LuceneTokenizer and SnowballTokenizer to Pig - useful text tokenization

2013-03-19 Thread Russell Jurney (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607209#comment-13607209 ] Russell Jurney commented on PIG-3190: - Thanks for the notes. I'll get it fixed. As to

[jira] [Commented] (PIG-3190) Add LuceneTokenizer and SnowballTokenizer to Pig - useful text tokenization

2013-03-19 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607228#comment-13607228 ] Daniel Dai commented on PIG-3190: - I don't against expanding our builtin collection, but