[jira] [Commented] (PIG-5453) FLATTEN shifting fields incorrectly

2024-05-16 Thread Daniel Dai (Jira)
[ https://issues.apache.org/jira/browse/PIG-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847097#comment-17847097 ] Daniel Dai commented on PIG-5453: - +1 > FLATTEN shifting fields incorrectly >

[jira] [Commented] (PIG-5453) FLATTEN shifting fields incorrectly

2024-04-18 Thread Daniel Dai (Jira)
[ https://issues.apache.org/jira/browse/PIG-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838865#comment-17838865 ] Daniel Dai commented on PIG-5453: - +1 > FLATTEN shifting fields incorrectly >

[jira] [Commented] (PIG-5406) TestJoinLocal imports org.python.google.common.collect.Lists instead of org.google.common.collect.Lists

2022-08-17 Thread Daniel Dai (Jira)
[ https://issues.apache.org/jira/browse/PIG-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17581065#comment-17581065 ] Daniel Dai commented on PIG-5406: - +1 > TestJoinLocal imports org.python.google.common.collect.Lists

[jira] [Commented] (PIG-5404) FLATTEN infers wrong datatype

2020-10-14 Thread Daniel Dai (Jira)
[ https://issues.apache.org/jira/browse/PIG-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214281#comment-17214281 ] Daniel Dai commented on PIG-5404: - +1 > FLATTEN infers wrong datatype > - > >

[jira] [Commented] (PIG-5243) describe with typecast on as-clause shows the types before the typecasting

2020-10-14 Thread Daniel Dai (Jira)
[ https://issues.apache.org/jira/browse/PIG-5243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214280#comment-17214280 ] Daniel Dai commented on PIG-5243: - +1 > describe with typecast on as-clause shows the types before the

[jira] [Commented] (PIG-5372) SAMPLE/RANDOM(udf) before skewed join failing with NPE

2019-01-02 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732373#comment-16732373 ] Daniel Dai commented on PIG-5372: - Wow that's back in 2010 :). I think SkewedPartitioner.setConf is passing

[jira] [Commented] (PIG-5368) Braces without escaping in regexes throws error in recent perl versions

2018-12-10 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715575#comment-16715575 ] Daniel Dai commented on PIG-5368: - Also committed PIG-5368-1.addendum.patch. > Braces without escaping in

[jira] [Commented] (PIG-5370) Union onschema + columnprune dropping used fields

2018-11-30 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705272#comment-16705272 ] Daniel Dai commented on PIG-5370: - +1 > Union onschema + columnprune dropping used fields >

[jira] [Commented] (PIG-5370) Union onschema + columnprune dropping used fields

2018-11-28 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702822#comment-16702822 ] Daniel Dai commented on PIG-5370: - +1, sounds good to me. > Union onschema + columnprune dropping used

[jira] [Resolved] (PIG-5368) Braces without escaping in regexes throws error in recent perl versions

2018-11-20 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5368. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 0.18.0 Patch committed to trunk.

[jira] [Updated] (PIG-5366) Enable PigStreamingDepend to load from current directory in newer Perl versions

2018-10-26 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5366: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 0.18.0 Status: Resolved (was:

[jira] [Commented] (PIG-5366) Enable PigStreamingDepend to load from current directory in newer Perl versions

2018-10-20 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657989#comment-16657989 ] Daniel Dai commented on PIG-5366: - [~abstractdog], assigned to you. > Enable PigStreamingDepend to load

[jira] [Assigned] (PIG-5366) Enable PigStreamingDepend to load from current directory in newer Perl versions

2018-10-20 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5366: --- Assignee: Laszlo Bodor > Enable PigStreamingDepend to load from current directory in newer Perl >

[jira] [Updated] (PIG-4373) Implement PIG-3861 in Tez

2018-07-06 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-4373: Status: Patch Available (was: Open) > Implement PIG-3861 in Tez > - > >

[jira] [Assigned] (PIG-4373) Implement PIG-3861 in Tez

2018-07-06 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-4373: --- Assignee: Daniel Dai (was: Rohini Palaniswamy) > Implement PIG-3861 in Tez >

[jira] [Resolved] (PIG-5329) cwiki training links

2018-01-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5329. - Resolution: Fixed Assignee: Daniel Dai Fix Version/s: site Updated, thanks! > cwiki

[jira] [Comment Edited] (PIG-4608) FOREACH ... UPDATE

2018-01-23 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336593#comment-16336593 ] Daniel Dai edited comment on PIG-4608 at 1/24/18 1:00 AM: -- bq. a = FOREACH b UPDATE

[jira] [Commented] (PIG-4608) FOREACH ... UPDATE

2018-01-23 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336593#comment-16336593 ] Daniel Dai commented on PIG-4608: - bq. a = FOREACH b UPDATE q AS q:int – This should be illegal, right? If

[jira] [Commented] (PIG-4608) FOREACH ... UPDATE

2018-01-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329539#comment-16329539 ] Daniel Dai commented on PIG-4608: - "add" (or append?)/"update xxx as"/"drop" syntax sounds good to me. We

[jira] [Resolved] (PIG-5293) Suspicious code as missing `this' for a member

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5293. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 0.18.0 Patch committed to trunk. Thanks

[jira] [Commented] (PIG-5191) Pig HBase 2.0.0 support

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137884#comment-16137884 ] Daniel Dai commented on PIG-5191: - Looks good. Can you also try if bin/pig would register all dependent

[jira] [Assigned] (PIG-5293) Suspicious code as missing `this' for a member

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5293: --- Assignee: JC > Suspicious code as missing `this' for a member >

[jira] [Commented] (PIG-5293) Suspicious code as missing `this' for a member

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137880#comment-16137880 ] Daniel Dai commented on PIG-5293: - That sounds valid. Can you upload a patch? > Suspicious code as missing

[jira] [Commented] (PIG-5289) update .eclipse.templates/.classpath with latest jars

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137875#comment-16137875 ] Daniel Dai commented on PIG-5289: - I don't think .eclipse.templates is used in eclipse-files. We already use

[jira] [Commented] (PIG-5286) Run verify_pig in e2e with old version of Pig

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137870#comment-16137870 ] Daniel Dai commented on PIG-5286: - Sounds good to me. Running verify_pig on old Pig is more natural. > Run

[jira] [Commented] (PIG-5271) StackOverflowError when compiling in Tez mode (with union and replicated join)

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137589#comment-16137589 ] Daniel Dai commented on PIG-5271: - Looks good to me. [~rohini], do you want a second look? >

[jira] [Comment Edited] (PIG-5272) BagToString Output Schema

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137270#comment-16137270 ] Daniel Dai edited comment on PIG-5272 at 8/22/17 7:41 PM: -- Are you saying your data

[jira] [Commented] (PIG-5272) BagToString Output Schema

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137270#comment-16137270 ] Daniel Dai commented on PIG-5272: - Are you saying your data does not match your declared schema? If you are

[jira] [Updated] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5268: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 0.18.0 Status: Resolved (was:

[jira] [Assigned] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage

2017-08-22 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5268: --- Assignee: BELUGA BEHR > Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage >

[jira] [Commented] (PIG-5201) Null handling on FLATTEN

2017-08-09 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121076#comment-16121076 ] Daniel Dai commented on PIG-5201: - What's your idea for the column padding? > Null handling on FLATTEN >

[jira] [Commented] (PIG-5256) Bytecode generation for POFilter and POForeach

2017-08-09 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121068#comment-16121068 ] Daniel Dai commented on PIG-5256: - Haven't checked the code line by line, but the overall approach looks

[jira] [Commented] (PIG-5201) Null handling on FLATTEN

2017-08-09 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120551#comment-16120551 ] Daniel Dai commented on PIG-5201: - It is equivalent to flatten a scalar. That's sounds fine. How about

[jira] [Updated] (PIG-5254) Hit Ctrl-D to quit grunt shell fail

2017-08-07 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5254: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Patch

[jira] [Commented] (PIG-5282) Upgade to Java 8

2017-08-02 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111280#comment-16111280 ] Daniel Dai commented on PIG-5282: - I don't have problem for that. Hive already move to JDK 8 and we can

[jira] [Resolved] (PIG-5270) Typo in Pig Logging

2017-07-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5270. - Resolution: Fixed Hadoop Flags: Reviewed Committed to trunk. Thank for fixing typo. > Typo in Pig

[jira] [Updated] (PIG-5270) Typo in Pig Logging

2017-07-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5270: Fix Version/s: (was: trunk) (was: 0.17.1) (was: 0.16.1)

[jira] [Assigned] (PIG-5270) Typo in Pig Logging

2017-07-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5270: --- Assignee: Andrew Hutton > Typo in Pig Logging > --- > > Key: PIG-5270

[jira] [Commented] (PIG-4767) Partition filter not pushed down when filter clause references variable from another load path

2017-07-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084758#comment-16084758 ] Daniel Dai commented on PIG-4767: - That's right, PartitionFilterOptimizer and PredicatePushdownOptimizer

[jira] [Commented] (PIG-5264) Remove deprecated keys from PigConfiguration

2017-07-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084623#comment-16084623 ] Daniel Dai commented on PIG-5264: - +1 > Remove deprecated keys from PigConfiguration >

[jira] [Updated] (PIG-5254) Hit Ctrl-D to quit grunt shell fail

2017-06-07 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5254: Fix Version/s: 0.17.1 > Hit Ctrl-D to quit grunt shell fail > --- > >

[jira] [Created] (PIG-5254) Hit Ctrl-D to quit grunt shell fail

2017-06-07 Thread Daniel Dai (JIRA)
Daniel Dai created PIG-5254: --- Summary: Hit Ctrl-D to quit grunt shell fail Key: PIG-5254 URL: https://issues.apache.org/jira/browse/PIG-5254 Project: Pig Issue Type: Bug Components: impl

[jira] [Commented] (PIG-5225) Several unit tests are not annotated with @Test

2017-05-31 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032007#comment-16032007 ] Daniel Dai commented on PIG-5225: - The test is added even before me. The test won't throw exception, it will

[jira] [Resolved] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-05-31 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5216. - Resolution: Fixed Hadoop Flags: Reviewed Also did rebase after spark merge. Patch committed to trunk.

[jira] [Updated] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-05-31 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5216: Attachment: PIG-5216-4.patch Find several issues when running unit tests: 1. In POLoad.setup, we also need to

[jira] [Commented] (PIG-5184) set command to view value of a variable

2017-05-29 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028088#comment-16028088 ] Daniel Dai commented on PIG-5184: - Addressing Rohini's review comments. > set command to view value of a

[jira] [Updated] (PIG-5184) set command to view value of a variable

2017-05-29 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5184: Attachment: PIG-5184-2.patch > set command to view value of a variable >

[jira] [Commented] (PIG-4059) Pig on Spark

2017-05-28 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027728#comment-16027728 ] Daniel Dai commented on PIG-4059: - +1. Didn't get a chance to review the patch, but we shall not further

[jira] [Commented] (PIG-5201) Null handling on FLATTEN

2017-05-26 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026631#comment-16026631 ] Daniel Dai commented on PIG-5201: - It is not a regression, so it is certainly fine to push out. Koji can

[jira] [Commented] (PIG-4662) New optimizer rule: filter nulls before inner joins

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025387#comment-16025387 ] Daniel Dai commented on PIG-4662: - I don't think it would make noticeable performance difference going

[jira] [Commented] (PIG-5194) HiveUDF fails with Spark exec type

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025249#comment-16025249 ] Daniel Dai commented on PIG-5194: - +1 for the HiveUDAF change, thanks for catching this! > HiveUDF fails

[jira] [Commented] (PIG-5231) PigStorage with -schema may produce inconsistent outputs with more fields

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025155#comment-16025155 ] Daniel Dai commented on PIG-5231: - Vote for 3. We pick the first schema in dirs in all LoadFunc, such as

[jira] [Commented] (PIG-5224) Extra foreach from ColumnPrune preventing Accumulator usage

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024919#comment-16024919 ] Daniel Dai commented on PIG-5224: - bq. Well, if next LOForEach is not removing all the columns which are not

[jira] [Resolved] (PIG-3021) Split results missing records when there is null values in the column comparison

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-3021. - Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 0.17.0 +1 for PIG-3021-4.patch. Patch

[jira] [Commented] (PIG-5224) Extra foreach from ColumnPrune preventing Accumulator usage

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024320#comment-16024320 ] Daniel Dai commented on PIG-5224: - The inserted LOForEach remove all the columns which are not used in the

[jira] [Commented] (PIG-5235) Typecast with as-clause fails for tuple/bag with an empty schema

2017-05-25 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024288#comment-16024288 ] Daniel Dai commented on PIG-5235: - +1 > Typecast with as-clause fails for tuple/bag with an empty schema >

[jira] [Commented] (PIG-4924) Translate failures.maxpercent MR setting to Tez

2017-05-24 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024195#comment-16024195 ] Daniel Dai commented on PIG-4924: - +1 > Translate failures.maxpercent MR setting to Tez >

[jira] [Commented] (PIG-4662) New optimizer rule: filter nulls before inner joins

2017-05-24 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024192#comment-16024192 ] Daniel Dai commented on PIG-4662: - I prefer to do it in optimizer, it seems to be more clear. > New

[jira] [Commented] (PIG-4914) Add testcase for join with special characters in chararray

2017-05-24 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024182#comment-16024182 ] Daniel Dai commented on PIG-4914: - This is only for tuple join key, right? String join key of utf8

[jira] [Updated] (PIG-5185) Job name show "DefaultJobName" when running a Python script

2017-05-24 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5185: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Patch

[jira] [Updated] (PIG-5222) Fix Junit Deprecations

2017-04-17 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5222: Attachment: PIG-5222-fixtest.patch TestEvalPipelineLocal.testFunctionInsideFunction,

[jira] [Updated] (PIG-5221) More fs.default.name deprecation warnings

2017-04-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5221: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Switch

[jira] [Updated] (PIG-5222) Fix Junit Deprecations

2017-04-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5222: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Patch

[jira] [Commented] (PIG-5224) Extra foreach from ColumnPrune preventing Accumulator usage

2017-04-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969841#comment-15969841 ] Daniel Dai commented on PIG-5224: - If this is a problem of extra foreach after LOCogroup, why not adding the

[jira] [Updated] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5223: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Both

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969265#comment-15969265 ] Daniel Dai commented on PIG-5223: - Both conditions should be met in limit by variable case. It should not

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969250#comment-15969250 ] Daniel Dai commented on PIG-5223: - mlimitplan is an expression to calculate limit variable. That is, the

[jira] [Comment Edited] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968670#comment-15968670 ] Daniel Dai edited comment on PIG-5223 at 4/14/17 5:54 AM: -- Yes, you can use the

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968670#comment-15968670 ] Daniel Dai commented on PIG-5223: - Yes, you can use the condition (mLimit == -1 && mlimitPlan != null), and

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967121#comment-15967121 ] Daniel Dai commented on PIG-5211: - I must make a mistake when rebasing the patch. Sure, go ahead, thanks

[jira] [Commented] (PIG-5217) Pig Streaming over python multiprocessing

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966570#comment-15966570 ] Daniel Dai commented on PIG-5217: - Are you able to give an example? Pig shall run python as an external

[jira] [Updated] (PIG-5219) IndexOutOfBoundsException when loading multiple directories with different schemas using OrcStorage

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5219: Fix Version/s: 0.17.0 > IndexOutOfBoundsException when loading multiple directories with different > schemas

[jira] [Commented] (PIG-5219) IndexOutOfBoundsException when loading multiple directories with different schemas using OrcStorage

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966567#comment-15966567 ] Daniel Dai commented on PIG-5219: - Pig use the schema in the first ORC file as the schema for the relation.

[jira] [Assigned] (PIG-5219) IndexOutOfBoundsException when loading multiple directories with different schemas using OrcStorage

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5219: --- Assignee: Daniel Dai > IndexOutOfBoundsException when loading multiple directories with different >

[jira] [Commented] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966502#comment-15966502 ] Daniel Dai commented on PIG-5216: - This is a very decent patch. Several comments: 1. I think you also intend

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966292#comment-15966292 ] Daniel Dai commented on PIG-5211: - Also opened PIG-5220 to improve NestedLimitOptimizer. > Optimize Nested

[jira] [Created] (PIG-5220) Improve NestedLimitOptimizer to handle general limit push up

2017-04-12 Thread Daniel Dai (JIRA)
Daniel Dai created PIG-5220: --- Summary: Improve NestedLimitOptimizer to handle general limit push up Key: PIG-5220 URL: https://issues.apache.org/jira/browse/PIG-5220 Project: Pig Issue Type:

[jira] [Updated] (PIG-5211) Optimize Nested Limited Sort

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5211: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Patch

[jira] [Updated] (PIG-5214) search any substring in the input string

2017-04-12 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5214: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Patch

[jira] [Commented] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961987#comment-15961987 ] Daniel Dai commented on PIG-5216: - LoadFuncDecorator.java is not included in the patch. If you are using

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961983#comment-15961983 ] Daniel Dai commented on PIG-5211: - The code changes looks good now. We'd better add several more tests: 1.

[jira] [Assigned] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5216: --- Assignee: Iris Zeng > Customizable Error Handling for Loaders in Pig >

[jira] [Updated] (PIG-5216) Customizable Error Handling for Loaders in Pig

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5216: Fix Version/s: 0.17.0 > Customizable Error Handling for Loaders in Pig >

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961945#comment-15961945 ] Daniel Dai commented on PIG-5211: - Another comment, in OptimizeNestedLimitTransformer, when we iterator

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-08 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961941#comment-15961941 ] Daniel Dai commented on PIG-5211: - There are still two Java 1.8 only code, error message when compiling with

[jira] [Commented] (PIG-3021) Split results missing records when there is null values in the column comparison

2017-04-07 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961565#comment-15961565 ] Daniel Dai commented on PIG-3021: - [~cheolsoo], do you remember why you change POIsNull.java? If all tests

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-07 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960409#comment-15960409 ] Daniel Dai commented on PIG-5211: - Thanks for the patch, pretty good actually. Several comments: 1.

[jira] [Commented] (PIG-5214) search any substring in the input string

2017-04-07 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960357#comment-15960357 ] Daniel Dai commented on PIG-5214: - Thanks for the patch. Left some comments on review board. > search any

[jira] [Updated] (PIG-5210) Option to print MR/Tez plan before launching

2017-04-06 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5210: Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) +1. Patch

[jira] [Updated] (PIG-5210) Option to print MR/Tez plan before launching

2017-04-06 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5210: Description: For pig script, users need to use {{pig -e "explain -script test.pig"}} to print out MR/Tez

[jira] [Commented] (PIG-5211) Optimize Nested Limited Sort

2017-04-04 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954743#comment-15954743 ] Daniel Dai commented on PIG-5211: - Looks pretty good so far. Need to fine tune NestedLimitOptimizer,

[jira] [Commented] (PIG-5210) Option to print MR/Tez plan before launching

2017-04-03 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954222#comment-15954222 ] Daniel Dai commented on PIG-5210: - This will be useful. For python script, it will be hard to do explain and

[jira] [Updated] (PIG-5210) Option to print MR/Tez plan before launching

2017-04-03 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5210: Summary: Option to print MR/Tez plan before launching (was: Print MR/Tez plan before launching) > Option to

[jira] [Updated] (PIG-5210) Option to print MR/Tez plan before launching

2017-04-03 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai updated PIG-5210: Description: Adding an option to print out MR/Tez plan before launching. (was: Set pig.print.exec.plan

[jira] [Commented] (PIG-5201) Null handling on FLATTEN

2017-04-03 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15954167#comment-15954167 ] Daniel Dai commented on PIG-5201: - Thanks for pointing out, yes, PIG-2537 is for tuple, for bag, I agree

[jira] [Commented] (PIG-5201) Null handling on FLATTEN

2017-04-01 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952064#comment-15952064 ] Daniel Dai commented on PIG-5201: - This is PIG-2537, this is a bug we shall fix. > Null handling on FLATTEN

[jira] [Assigned] (PIG-5210) Print MR/Tez plan before launching

2017-03-31 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai reassigned PIG-5210: --- Assignee: Lili Yu > Print MR/Tez plan before launching > -- > >

[jira] [Commented] (PIG-4677) Display failure information on stop on failure

2017-03-31 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951709#comment-15951709 ] Daniel Dai commented on PIG-4677: - +1 on PIG-4677-fixflakytest.patch. > Display failure information on stop

[jira] [Commented] (PIG-4677) Display failure information on stop on failure

2017-03-30 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-4677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15948477#comment-15948477 ] Daniel Dai commented on PIG-4677: - +1 > Display failure information on stop on failure >

[jira] [Resolved] (PIG-5190) ant docs issue by pig-5110

2017-03-15 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Dai resolved PIG-5190. - Resolution: Invalid > ant docs issue by pig-5110 > -- > > Key:

  1   2   3   4   5   6   7   8   9   10   >