[jira] [Updated] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
[
https://issues.apache.org/jira/browse/PIG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5267:
-
Resolution: Won't Fix
Status: Resolved (was: Patch Available)
> Review of org.apache.pig.impl.io.BufferedPositionedInputStream
> --
>
> Key: PIG-5267
> URL: https://issues.apache.org/jira/browse/PIG-5267
> Project: Pig
> Issue Type: Improvement
> Components: impl
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5267.1.patch
>
>
> There appears to be some unused code i.e., {{readLine}} and there is a buffer
> size of 1K bytes.
> I propose removing the unused code, and allowing the buffer size to be
> determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
[
https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16087361#comment-16087361
]
BELUGA BEHR commented on PIG-5268:
--
[~rohini] [~nkollar]
I understand that these trivial changes can be burdensome for the gain, but
attracting more developers can sometimes hinge on how beat-up the code is.
Additionally someone who is evaluating the code base to build a product on,
they may be turned off by dead code, bad formatting, and bad code re-use. I
know I would question it. I would question how much care was put into a
product.
So, I don't think there's anything wrong with putting some polish and shine on
a project used by many production systems. My goal would be to, over time,
mold the project into a better direction that people open up and are excited
by. These are marked appropriately as trivial. Spare cycles can be dedicated
to some cleanup.
I have a customer interested in using Pig, so I was just starting to get a feel
for the project by submitting a couple of trivial patches. I don't know how
helpful I'll be on full feature requests, but I can review the open tickets.
Thanks for considering this patch.
> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
>
>
> Key: PIG-5268
> URL: https://issues.apache.org/jira/browse/PIG-5268
> Project: Pig
> Issue Type: Improvement
> Components: data
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5268.1.patch, PIG-5268.2.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
[
https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075578#comment-16075578
]
BELUGA BEHR commented on PIG-5268:
--
[~nkollar] Thanks for the review. I have made the requested changes.
> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
>
>
> Key: PIG-5268
> URL: https://issues.apache.org/jira/browse/PIG-5268
> Project: Pig
> Issue Type: Improvement
> Components: data
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5268.1.patch, PIG-5268.2.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
[
https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5268:
-
Attachment: PIG-5268.2.patch
> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
>
>
> Key: PIG-5268
> URL: https://issues.apache.org/jira/browse/PIG-5268
> Project: Pig
> Issue Type: Improvement
> Components: data
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5268.1.patch, PIG-5268.2.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
[
https://issues.apache.org/jira/browse/PIG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5267:
-
Attachment: PIG-5268.1.patch
> Review of org.apache.pig.impl.io.BufferedPositionedInputStream
> --
>
> Key: PIG-5267
> URL: https://issues.apache.org/jira/browse/PIG-5267
> Project: Pig
> Issue Type: Improvement
> Components: impl
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5267.1.patch
>
>
> There appears to be some unused code i.e., {{readLine}} and there is a buffer
> size of 1K bytes.
> I propose removing the unused code, and allowing the buffer size to be
> determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
[
https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5268:
-
Status: Patch Available (was: Open)
> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
>
>
> Key: PIG-5268
> URL: https://issues.apache.org/jira/browse/PIG-5268
> Project: Pig
> Issue Type: Improvement
> Components: data
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5268.1.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
[
https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5268:
-
Attachment: PIG-5268.1.patch
> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
>
>
> Key: PIG-5268
> URL: https://issues.apache.org/jira/browse/PIG-5268
> Project: Pig
> Issue Type: Improvement
> Components: data
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5268.1.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
BELUGA BEHR created PIG-5268:
Summary: Review of
org.apache.pig.backend.hadoop.datastorage.HDataStorage
Key: PIG-5268
URL: https://issues.apache.org/jira/browse/PIG-5268
Project: Pig
Issue Type: Improvement
Components: data
Affects Versions: 0.17.0
Reporter: BELUGA BEHR
Priority: Trivial
# Optimize for case where {{asCollection}} is empty
# Tidy up
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
[
https://issues.apache.org/jira/browse/PIG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5267:
-
Attachment: (was: PIG-5268.1.patch)
> Review of org.apache.pig.impl.io.BufferedPositionedInputStream
> --
>
> Key: PIG-5267
> URL: https://issues.apache.org/jira/browse/PIG-5267
> Project: Pig
> Issue Type: Improvement
> Components: impl
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5267.1.patch
>
>
> There appears to be some unused code i.e., {{readLine}} and there is a buffer
> size of 1K bytes.
> I propose removing the unused code, and allowing the buffer size to be
> determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
[
https://issues.apache.org/jira/browse/PIG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5267:
-
Status: Patch Available (was: Open)
> Review of org.apache.pig.impl.io.BufferedPositionedInputStream
> --
>
> Key: PIG-5267
> URL: https://issues.apache.org/jira/browse/PIG-5267
> Project: Pig
> Issue Type: Improvement
> Components: impl
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5267.1.patch
>
>
> There appears to be some unused code i.e., {{readLine}} and there is a buffer
> size of 1K bytes.
> I propose removing the unused code, and allowing the buffer size to be
> determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
[
https://issues.apache.org/jira/browse/PIG-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
BELUGA BEHR updated PIG-5267:
-
Attachment: PIG-5267.1.patch
> Review of org.apache.pig.impl.io.BufferedPositionedInputStream
> --
>
> Key: PIG-5267
> URL: https://issues.apache.org/jira/browse/PIG-5267
> Project: Pig
> Issue Type: Improvement
> Components: impl
>Affects Versions: 0.17.0
>Reporter: BELUGA BEHR
>Priority: Trivial
> Attachments: PIG-5267.1.patch
>
>
> There appears to be some unused code i.e., {{readLine}} and there is a buffer
> size of 1K bytes.
> I propose removing the unused code, and allowing the buffer size to be
> determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Created] (PIG-5267) Review of org.apache.pig.impl.io.BufferedPositionedInputStream
BELUGA BEHR created PIG-5267:
Summary: Review of
org.apache.pig.impl.io.BufferedPositionedInputStream
Key: PIG-5267
URL: https://issues.apache.org/jira/browse/PIG-5267
Project: Pig
Issue Type: Improvement
Components: impl
Affects Versions: 0.17.0
Reporter: BELUGA BEHR
Priority: Trivial
There appears to be some unused code i.e., {{readLine}} and there is a buffer
size of 1K bytes.
I propose removing the unused code, and allowing the buffer size to be
determined by the JVM instead of hard-coded value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
