[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482077#comment-13482077
]
Koji Noguchi commented on PIG-2975:
---
bq. Now I am running all the tests with your fix and
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482072#comment-13482072
]
Cheolsoo Park commented on PIG-2975:
Thank you Koji!
Now I am running all the tests wit
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482064#comment-13482064
]
Jonathan Coveney commented on PIG-2975:
---
'twas a delight. On to the next one ;)
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482063#comment-13482063
]
Koji Noguchi commented on PIG-2975:
---
Thanks Jonathan, Gianmarco and Cheolsoo!
(and sorry
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482057#comment-13482057
]
Jonathan Coveney commented on PIG-2975:
---
Thanks for the great job, Koji. It's in!
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481790#comment-13481790
]
Jonathan Coveney commented on PIG-2975:
---
I'm going to give it one last look-over and m
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481770#comment-13481770
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Guys, great job i
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481761#comment-13481761
]
Koji Noguchi commented on PIG-2975:
---
bq. Would it have been the same before?
Yes. My test
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481748#comment-13481748
]
Jonathan Coveney commented on PIG-2975:
---
Would it have been the same before? A seriali
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481628#comment-13481628
]
Jonathan Coveney commented on PIG-2975:
---
Koji,
It's been a pleasure :)
Ok, I'm king
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481548#comment-13481548
]
Jonathan Coveney commented on PIG-2975:
---
Koji,
I am digging this!
A couple stylistic
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480455#comment-13480455
]
Jonathan Coveney commented on PIG-2975:
---
This is one benefit (and in some senses, the
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480442#comment-13480442
]
Koji Noguchi commented on PIG-2975:
---
bq. One thing I worry about this new sort order is, w
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480413#comment-13480413
]
Koji Noguchi commented on PIG-2975:
---
{quote}
pig-2975-trunk_v04-purerawcompare.txt
222
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480393#comment-13480393
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Indeed, my idea t
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480382#comment-13480382
]
Koji Noguchi commented on PIG-2975:
---
bq. but I feel that it would be good to keep it stabl
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480381#comment-13480381
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Personally I woul
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480378#comment-13480378
]
Jonathan Coveney commented on PIG-2975:
---
As a side note, Koji, if you make a new jira
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480374#comment-13480374
]
Jonathan Coveney commented on PIG-2975:
---
Gianmarco,
That's what I'm currently ponderi
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480373#comment-13480373
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Yes, I was referr
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480340#comment-13480340
]
Koji Noguchi commented on PIG-2975:
---
bq. by including the 4 bytes in the comparison I am a
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480309#comment-13480309
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Personally I don'
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480301#comment-13480301
]
Koji Noguchi commented on PIG-2975:
---
bq. As far as the switch approach, I don't think it i
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480296#comment-13480296
]
Koji Noguchi commented on PIG-2975:
---
Forgot to mention one more alternative. Take out the
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480266#comment-13480266
]
Jonathan Coveney commented on PIG-2975:
---
I agree with everything Gianmarco said.
As f
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480247#comment-13480247
]
Gianmarco De Francisci Morales commented on PIG-2975:
-
Hi,
We use ByteBu
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480231#comment-13480231
]
Jonathan Coveney commented on PIG-2975:
---
Hmm, ok, well, that's a good change to keep i
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480190#comment-13480190
]
Jonathan Coveney commented on PIG-2975:
---
Koji,
That is super reasonable. I hate bugs
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480192#comment-13480192
]
Jonathan Coveney commented on PIG-2975:
---
Also: I've been loving the contribution from
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480153#comment-13480153
]
Koji Noguchi commented on PIG-2975:
---
bq. I am going to roll up my sleeves and do this rig
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480146#comment-13480146
]
Jonathan Coveney commented on PIG-2975:
---
Oof, thanks for benchmarking. I am going to r
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480103#comment-13480103
]
Koji Noguchi commented on PIG-2975:
---
bq. I don't think we need to sacrifice performance if
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479523#comment-13479523
]
Jonathan Coveney commented on PIG-2975:
---
FWIW I think my patch fixes this, and I don't
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479421#comment-13479421
]
Jonathan Coveney commented on PIG-2975:
---
Koji,
I don't think we need to sacrifice per
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479404#comment-13479404
]
Koji Noguchi commented on PIG-2975:
---
Silly me. Result of above script was
{noformat}
(0)
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479402#comment-13479402
]
Koji Noguchi commented on PIG-2975:
---
bq. Result incorrect (when order-by used). [0.11 and
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478611#comment-13478611
]
Koji Noguchi commented on PIG-2975:
---
bq. you can use BinSedesTuple.BinInterSedesTupleRawC
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478262#comment-13478262
]
Koji Noguchi commented on PIG-2975:
---
bq. Why does it jump a static 4 bytes?
Because Bytes
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478227#comment-13478227
]
Jonathan Coveney commented on PIG-2975:
---
Another option, of course, is changing the ra
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478220#comment-13478220
]
Jonathan Coveney commented on PIG-2975:
---
One possibility, Koji, is that in the constru
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478216#comment-13478216
]
Jonathan Coveney commented on PIG-2975:
---
Ah, I didn't see that. That's what potentiall
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478213#comment-13478213
]
Jonathan Coveney commented on PIG-2975:
---
Quick first answer to your questions:
1. Hrm,
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478208#comment-13478208
]
Koji Noguchi commented on PIG-2975:
---
bq. Can I assume the param to NullableBytesWritable c
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478194#comment-13478194
]
Jonathan Coveney commented on PIG-2975:
---
Great work, Koji. A test specifically aimed a
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477547#comment-13477547
]
Cheolsoo Park commented on PIG-2975:
Here is the full list of tests that will be fixed b
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477468#comment-13477468
]
Cheolsoo Park commented on PIG-2975:
Hi Koji, this is a good finding!
It seems that sev
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477399#comment-13477399
]
Koji Noguchi commented on PIG-2975:
---
bq. (For larger bytearray whose size does not fit in
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477394#comment-13477394
]
Koji Noguchi commented on PIG-2975:
---
This took me much longer to understand than I first a
[
https://issues.apache.org/jira/browse/PIG-2975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476447#comment-13476447
]
Koji Noguchi commented on PIG-2975:
---
I haven't had time to look into detail but reverting
49 matches
Mail list logo
