[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Jin Sun (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969542#comment-15969542 ] Jin Sun commented on PIG-5223: -- Thanks Koji. I will make a small fix later today before we merge to trunk. >

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Koji Noguchi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969360#comment-15969360 ] Koji Noguchi commented on PIG-5223: --- Thanks Jin Sun, Daniel! With the proposed patch, confirmed that it

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969265#comment-15969265 ] Daniel Dai commented on PIG-5223: - Both conditions should be met in limit by variable case. It should not

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Jin Sun (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969257#comment-15969257 ] Jin Sun commented on PIG-5223: -- then should it be mLimit is -1 || mlimitPlan is not null ? Please correct me if

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969250#comment-15969250 ] Daniel Dai commented on PIG-5223: - mlimitplan is an expression to calculate limit variable. That is, the

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-14 Thread Jin Sun (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969105#comment-15969105 ] Jin Sun commented on PIG-5223: -- Can you explain what is mlimitplan or LogicalExpressionPlan in general, and why

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Daniel Dai (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968670#comment-15968670 ] Daniel Dai commented on PIG-5223: - Yes, you can use the condition (mLimit == -1 && mlimitPlan != null), and

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Jin Sun (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968655#comment-15968655 ] Jin Sun commented on PIG-5223: -- Hey [~daijy] The second test failed should be easily fixed by changing "in" to

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Jin Sun (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968342#comment-15968342 ] Jin Sun commented on PIG-5223: -- I will take a look later today. Probably need some help from you guys later on.

[jira] [Commented] (PIG-5223) TestLimitVariable.testNestedLimitVariable1 and TestSecondarySortMR.testNestedLimitedSort failing

2017-04-13 Thread Koji Noguchi (JIRA)
[ https://issues.apache.org/jira/browse/PIG-5223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15968253#comment-15968253 ] Koji Noguchi commented on PIG-5223: --- [~jins], [~daijy], let me know if one of you can take this. If not,