Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/#review20127 ---

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-03 Thread Johnny Zhang
On May 3, 2013, 6:53 p.m., Rohini Palaniswamy wrote: Thanks for the comments, Rohini! appreciate. I will post the revised patch very soon. - Johnny --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-03 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/ --- (Updated May 3, 2013, 7:30 p.m.) Review request for pig. Changes ---

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-03 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/#review20138 --- Ship it! Thanks Johnny. Looks good. - Rohini Palaniswamy On May

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-02 Thread Johnny Zhang
On April 30, 2013, 8:07 p.m., Rohini Palaniswamy wrote: contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java, line 160 https://reviews.apache.org/r/10351/diff/1/?file=279039#file279039line160 Pattern should be a private static variable.

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-02 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/ --- (Updated May 3, 2013, 12:27 a.m.) Review request for pig. Changes ---

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-02 Thread Johnny Zhang
On April 30, 2013, 8:07 p.m., Rohini Palaniswamy wrote: contrib/piggybank/java/src/main/java/org/apache/pig/piggybank/storage/avro/AvroStorageUtils.java, line 146 https://reviews.apache.org/r/10351/diff/1/?file=279039#file279039line146 Doing a globStatus again on a known file

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-05-02 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/ --- (Updated May 3, 2013, 12:33 a.m.) Review request for pig. Description

Re: Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-04-30 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/#review19974 ---

Review Request: PIG-3223 AvroStorage does not handle comma separated input paths

2013-04-08 Thread Johnny Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10351/ --- Review request for pig. Description --- we want to support comma