Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16463/#review30905 --- Ship it! Ship It! - Rohini Palaniswamy On Dec. 27, 2013, 6:31 a.

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16463/ --- (Updated Dec. 27, 2013, 6:31 a.m.) Review request for pig, Alex Bain, Daniel Da

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Cheolsoo Park
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 189 > > > > > > Any reason for adding this newly within tests? tearDown() already has > > it. > > Cheol

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Rohini Palaniswamy
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 189 > > > > > > Any reason for adding this newly within tests? tearDown() already has > > it. > > Cheol

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Cheolsoo Park
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 189 > > > > > > Any reason for adding this newly within tests? tearDown() already has > > it. > > Cheol

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Rohini Palaniswamy
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 189 > > > > > > Any reason for adding this newly within tests? tearDown() already has > > it. > > Cheol

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Cheolsoo Park
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 189 > > > > > > Any reason for adding this newly within tests? tearDown() already has > > it. > > Cheol

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Rohini Palaniswamy
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > test/org/apache/pig/test/TestAccumulator.java, line 114 > > > > > > Why do we specifically need homeDirOnDfs? Isn't that the default > > current directory?

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Cheolsoo Park
> On Dec. 26, 2013, 4:45 p.m., Rohini Palaniswamy wrote: > > Patch looks good. Just few minor review comments. > > > > > Note that 3 test cases in TestAccumulator are annotated as @Ignore > > > because SecondaryKeyOptimizer in Tez is not implement yet. The test cases > > > expect accumulator o

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-26 Thread Rohini Palaniswamy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16463/#review30867 --- Patch looks good. Just few minor review comments. > Note that 3 tes

Re: Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-25 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16463/ --- (Updated Dec. 26, 2013, 6:11 a.m.) Review request for pig, Alex Bain, Daniel Da

Review Request 16463: PIG-3636 Implement accumulator optimization in Tez

2013-12-25 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16463/ --- Review request for pig, Alex Bain, Daniel Dai, Mark Wagner, and Rohini Palaniswa