Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-12-12 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/#review64932 --- Ship it! Ran unit tests and e2e tests. - Cheolsoo Park On Dec.

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-12-07 Thread Quang-Nhat HOANG-XUAN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/ --- (Updated Dec. 7, 2014, 12:32 p.m.) Review request for pig. Bugs: PIG-4066

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-11-17 Thread Quang-Nhat HOANG-XUAN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/ --- (Updated Nov. 17, 2014, 10:50 a.m.) Review request for pig. Bugs: PIG-4066

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-11-04 Thread Quang-Nhat HOANG-XUAN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/ --- (Updated Nov. 4, 2014, 8:56 a.m.) Review request for pig. Bugs: PIG-4066

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-11-04 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/#review59776 --- Let me run unit tests.

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-11-04 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/#review59777 --- I am also wondering whether RollupHIIOptimizer has any side effect

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-09-16 Thread Quang-Nhat HOANG-XUAN
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/ --- (Updated Sept. 16, 2014, 1:31 p.m.) Review request for pig. Bugs: PIG-4066

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-07-25 Thread Quang-Nhat HOANG-XUAN
On July 24, 2014, 7:46 p.m., Cheolsoo Park wrote: Quang-Nhat HOANG-XUAN, thank you very much for the patch. I briefly went it over and found some high-level issues to be address- 1) Please rebase your patch to trunk. New features are only committed into trunk. 2) Please avoid

Re: Review Request 23804: PIG-4066 An optimization for ROLLUP operation on Pig

2014-07-24 Thread Cheolsoo Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23804/#review48543 --- Quang-Nhat HOANG-XUAN, thank you very much for the patch. I